Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0019131
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 02. Master data managementmajoralways2011-11-22 11:112011-12-17 03:07
ReportermaiteView Statuspublic 
Assigned Tojecharri 
PriorityurgentResolutionfixedFixed in Version3.0MP7
StatusclosedFix in branchFixed in SCM revision2462f2ed8dae
ProjectionnoneETAnoneTarget Version3.0MP7
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0019131: Fields that depends on other field (typically, checkbox field), should be clean when main field is unchecked

DescriptionFields that depends on other field (typically, checkbox field), should be clean when main field is unchecked. For example:
-FieldA is checkbox field
-When fieldA is selected, then fieldB and fieldC are displayed
-If fieldA is uncheked, fieldB and fieldC should be cleared as they are dependent fields
Steps To Reproduce1. Go to Payment Terms window
2. Mark field "Fixed due date", realize that "Maturity Date 1", "Maturity Date 2" and "Maturity Date 3" fields are displayed
3. Set values for this fields
4. Uncheck "Fixed due date" but in grid view you can see that "Maturity Date 1", "Maturity Date 2" and "Maturity Date 3" fields are still filled and affect on application behaviour

[To verify that they affect on application behaviour you can do following test:
- Create Payment Term A as: Overdue Payment Days Rule=60 ; Fixed Due date=Y; Maturity date 1=10;Maturity date 2=20;Maturity date 3=30; Fixed Due date=N
- Create Payment Term B as: Overdue Payment Days Rule=60 ; Fixed Due date=N
- Register sales invoice using each payment term and realize that "due date" field in payment plan tab is different, when it should be the same]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0043083)
alostale (manager)
2011-11-22 17:28

 Some comments:
1. These fields are shown or hidden based on display logic. Display logic is for displaying and not for erasing values. Cleaning them would be a hidden API change which might lead to unexpected behavior in many other places. So the proposed fix about cleaning up the "dependent" fields IS NOT going to be implemented.
2. If in this case the clean up makes sense for this concrete use case, this should be implemented as callout or trigger for this functionality.
(0043084)
alostale (manager)
2011-11-22 17:32

 Updating category (it is not actually a platform issue) and reassigning it
(0043404)
jonalegriaesarte (reporter)
2011-11-28 13:03

 The process will be checked to obtain the correct due date.
(0043491)
jonalegriaesarte (reporter)
2011-11-30 12:32

 Changed to MP7 due to other priorities
(0043753)
hgbot (developer)
2011-12-09 11:31

 Repository: erp/devel/pi
Changeset: f4a9ad42e48a85d62af056eb177136d96ef6d431
Author: Javier Etxarri <javier.echarri <at> openbravo.com>
Date: Fri Dec 02 14:40:09 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f4a9ad42e48a85d62af056eb177136d96ef6d431 [^]

Fixes issue 19131: Fields that depends on other fields, should be clean.
Finally the trigger has been modified, so the user can not uncheck the checkbox Fixed Due Date with data in the fields Maturity Date

---
M src-db/database/model/triggers/C_PAYMENTTERM_TRG.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
---
(0043826)
hudsonbot (developer)
2011-12-13 16:43

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8a06361cc265 [^]

Maturity status: Test
(0043898)
hgbot (developer)
2011-12-15 16:54

 Repository: erp/devel/pi
Changeset: 2462f2ed8daeaae70f332e65e93075a8531c9d8c
Author: Javier Etxarri <javier.echarri <at> openbravo.com>
Date: Thu Dec 15 16:54:17 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/2462f2ed8daeaae70f332e65e93075a8531c9d8c [^]

Fixes issue 19131: Fields that depends on other field.
The solution is simple, before take the values of fixmonthday fields, the field isduefixed is revised if it is checked or not

---
M modules/org.openbravo.advpaymentmngt/src-db/database/model/functions/APRM_GEN_PAYMENTSCHEDULE_INV.xml
---
(0043903)
maite (developer)
2011-12-16 08:55

 verified
(0043925)
hudsonbot (developer)
2011-12-17 03:07

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/919bff4169c5 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2011-11-22 11:11 maite New Issue
2011-11-22 11:11 maite Assigned To => alostale
2011-11-22 11:11 maite Modules => Core
2011-11-22 11:11 maite Target Version => 3.0MP6
2011-11-22 11:12 maite Issue Monitored: networkb
2011-11-22 17:28 alostale Note Added: 0043083
2011-11-22 17:32 alostale Note Added: 0043084
2011-11-22 17:32 alostale Assigned To alostale => jonalegriaesarte
2011-11-22 17:32 alostale Category A. Platform => 02. Master data management
2011-11-28 13:03 jonalegriaesarte Note Added: 0043404
2011-11-28 13:41 jonalegriaesarte Assigned To jonalegriaesarte => jecharri
2011-11-30 12:32 jonalegriaesarte Note Added: 0043491
2011-11-30 12:32 jonalegriaesarte Target Version 3.0MP6 => 3.0MP7
2011-12-09 11:31 hgbot Checkin
2011-12-09 11:31 hgbot Note Added: 0043753
2011-12-09 11:31 hgbot Status new => resolved
2011-12-09 11:31 hgbot Resolution open => fixed
2011-12-09 11:31 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f4a9ad42e48a85d62af056eb177136d96ef6d431 [^]
2011-12-12 13:23 jecharri Status resolved => new
2011-12-12 13:23 jecharri Resolution fixed => open
2011-12-13 16:43 hudsonbot Checkin
2011-12-13 16:43 hudsonbot Note Added: 0043826
2011-12-15 16:54 hgbot Checkin
2011-12-15 16:54 hgbot Note Added: 0043898
2011-12-15 16:54 hgbot Status new => resolved
2011-12-15 16:54 hgbot Resolution open => fixed
2011-12-15 16:54 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/f4a9ad42e48a85d62af056eb177136d96ef6d431 [^] => http://code.openbravo.com/erp/devel/pi/rev/2462f2ed8daeaae70f332e65e93075a8531c9d8c [^]
2011-12-16 08:55 maite Note Added: 0043903
2011-12-16 08:55 maite Status resolved => closed
2011-12-16 08:55 maite Fixed in Version => 3.0MP7
2011-12-17 03:07 hudsonbot Checkin
2011-12-17 03:07 hudsonbot Note Added: 0043925

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker