Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019131Openbravo ERP02. Master data managementpublic2011-11-22 11:112011-12-17 03:07
Reportermaite 
Assigned Tojecharri 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP7Fixed in Version3.0MP7 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019131: Fields that depends on other field (typically, checkbox field), should be clean when main field is unchecked
DescriptionFields that depends on other field (typically, checkbox field), should be clean when main field is unchecked. For example:
-FieldA is checkbox field
-When fieldA is selected, then fieldB and fieldC are displayed
-If fieldA is uncheked, fieldB and fieldC should be cleared as they are dependent fields
Steps To Reproduce1. Go to Payment Terms window
2. Mark field "Fixed due date", realize that "Maturity Date 1", "Maturity Date 2" and "Maturity Date 3" fields are displayed
3. Set values for this fields
4. Uncheck "Fixed due date" but in grid view you can see that "Maturity Date 1", "Maturity Date 2" and "Maturity Date 3" fields are still filled and affect on application behaviour

[To verify that they affect on application behaviour you can do following test:
- Create Payment Term A as: Overdue Payment Days Rule=60 ; Fixed Due date=Y; Maturity date 1=10;Maturity date 2=20;Maturity date 3=30; Fixed Due date=N
- Create Payment Term B as: Overdue Payment Days Rule=60 ; Fixed Due date=N
- Register sales invoice using each payment term and realize that "due date" field in payment plan tab is different, when it should be the same]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-11-22 11:11maiteNew Issue
2011-11-22 11:11maiteAssigned To => alostale
2011-11-22 11:11maiteModules => Core
2011-11-22 11:11maiteTarget Version => 3.0MP6
2011-11-22 11:12maiteIssue Monitored: networkb
2011-11-22 17:28alostaleNote Added: 0043083
2011-11-22 17:32alostaleNote Added: 0043084
2011-11-22 17:32alostaleAssigned Toalostale => jonalegriaesarte
2011-11-22 17:32alostaleCategoryA. Platform => 02. Master data management
2011-11-28 13:03jonalegriaesarteNote Added: 0043404
2011-11-28 13:41jonalegriaesarteAssigned Tojonalegriaesarte => jecharri
2011-11-30 12:32jonalegriaesarteNote Added: 0043491
2011-11-30 12:32jonalegriaesarteTarget Version3.0MP6 => 3.0MP7
2011-12-09 11:31hgbotCheckin
2011-12-09 11:31hgbotNote Added: 0043753
2011-12-09 11:31hgbotStatusnew => resolved
2011-12-09 11:31hgbotResolutionopen => fixed
2011-12-09 11:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f4a9ad42e48a85d62af056eb177136d96ef6d431 [^]
2011-12-12 13:23jecharriStatusresolved => new
2011-12-12 13:23jecharriResolutionfixed => open
2011-12-13 16:43hudsonbotCheckin
2011-12-13 16:43hudsonbotNote Added: 0043826
2011-12-15 16:54hgbotCheckin
2011-12-15 16:54hgbotNote Added: 0043898
2011-12-15 16:54hgbotStatusnew => resolved
2011-12-15 16:54hgbotResolutionopen => fixed
2011-12-15 16:54hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/f4a9ad42e48a85d62af056eb177136d96ef6d431 [^] => http://code.openbravo.com/erp/devel/pi/rev/2462f2ed8daeaae70f332e65e93075a8531c9d8c [^]
2011-12-16 08:55maiteNote Added: 0043903
2011-12-16 08:55maiteStatusresolved => closed
2011-12-16 08:55maiteFixed in Version => 3.0MP7
2011-12-17 03:07hudsonbotCheckin
2011-12-17 03:07hudsonbotNote Added: 0043925

Notes
(0043083)
alostale   
2011-11-22 17:28   
Some comments:
1. These fields are shown or hidden based on display logic. Display logic is for displaying and not for erasing values. Cleaning them would be a hidden API change which might lead to unexpected behavior in many other places. So the proposed fix about cleaning up the "dependent" fields IS NOT going to be implemented.
2. If in this case the clean up makes sense for this concrete use case, this should be implemented as callout or trigger for this functionality.
(0043084)
alostale   
2011-11-22 17:32   
Updating category (it is not actually a platform issue) and reassigning it
(0043404)
jonalegriaesarte   
2011-11-28 13:03   
The process will be checked to obtain the correct due date.
(0043491)
jonalegriaesarte   
2011-11-30 12:32   
Changed to MP7 due to other priorities
(0043753)
hgbot   
2011-12-09 11:31   
Repository: erp/devel/pi
Changeset: f4a9ad42e48a85d62af056eb177136d96ef6d431
Author: Javier Etxarri <javier.echarri <at> openbravo.com>
Date: Fri Dec 02 14:40:09 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f4a9ad42e48a85d62af056eb177136d96ef6d431 [^]

Fixes issue 19131: Fields that depends on other fields, should be clean.
Finally the trigger has been modified, so the user can not uncheck the checkbox Fixed Due Date with data in the fields Maturity Date

---
M src-db/database/model/triggers/C_PAYMENTTERM_TRG.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
---
(0043826)
hudsonbot   
2011-12-13 16:43   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8a06361cc265 [^]

Maturity status: Test
(0043898)
hgbot   
2011-12-15 16:54   
Repository: erp/devel/pi
Changeset: 2462f2ed8daeaae70f332e65e93075a8531c9d8c
Author: Javier Etxarri <javier.echarri <at> openbravo.com>
Date: Thu Dec 15 16:54:17 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/2462f2ed8daeaae70f332e65e93075a8531c9d8c [^]

Fixes issue 19131: Fields that depends on other field.
The solution is simple, before take the values of fixmonthday fields, the field isduefixed is revised if it is checked or not

---
M modules/org.openbravo.advpaymentmngt/src-db/database/model/functions/APRM_GEN_PAYMENTSCHEDULE_INV.xml
---
(0043903)
maite   
2011-12-16 08:55   
verified
(0043925)
hudsonbot   
2011-12-17 03:07   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/919bff4169c5 [^]

Maturity status: Test