Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0019127
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementminorsometimes2011-11-21 19:392011-11-30 15:50
Reportereduardo_ArgalView Statuspublic 
Assigned Toeduardo_Argal 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchpiFixed in SCM revision2b117851284f
ProjectionnoneETAnoneTarget Versionpi
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0019127: Credit module script loops all business partners

DescriptionCredit module script loops all business partners to fulfill credit payment tab info while it may not be necessary.
As module scripts are executed on every update, improving performance can be important.
A change in code to loop just those business partners which needs to be updated will improve a lot performance
Steps To Reproducerun "ant smartbuild -Dlocal=no" and mind that module script takes too long.
Proposed SolutionModify primary sql just to loop those business partners which contains payments that needs to be updated
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0019128pi closededuardo_Argal Credit module script loops all business partners 

-  Notes
(0043025)
hgbot (developer)
2011-11-21 19:42

 Repository: erp/devel/pi
Changeset: 2b117851284f72fc12914de21fc4de18dd96741f
Author: Eduardo Argal Guibert <eduardo.argal <at> openbravo.com>
Date: Mon Nov 21 19:42:18 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/2b117851284f72fc12914de21fc4de18dd96741f [^]

fixes bug 19127: Credit module script loops all business partners

---
M modules/org.openbravo.advpaymentmngt/build/classes/org/openbravo/advpaymentmngt/modulescript/LinkCreditPaymentsData.class
M modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/org/openbravo/advpaymentmngt/modulescript/LinkCreditPayments_data.xsql
M modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/src/org/openbravo/advpaymentmngt/modulescript/LinkCreditPaymentsData.java
---
(0043026)
eduardo_Argal (developer)
2011-11-21 20:06

 Test plan:

generate some payments consuming credit in an instance with some thousands of business partners on mp5, where there was no credit payment tab and run "ant smartbuild -Dlocal=no". Mind that now performance is better

Regressions: the risk of regressions is low. Just broken modulescript could introduce one and it has already been tested
(0043067)
hudsonbot (developer)
2011-11-22 03:50

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ebd713dfe507 [^]

Maturity status: Test
(0043587)
vmromanos (manager)
2011-11-30 15:50

 Code review OK
Testing OK. The module script continues to work as designed after this change.

- Issue History
Date Modified Username Field Change
2011-11-21 19:39 eduardo_Argal New Issue
2011-11-21 19:39 eduardo_Argal Assigned To => eduardo_Argal
2011-11-21 19:39 eduardo_Argal Modules => Core
2011-11-21 19:40 eduardo_Argal Modules Core => Advanced Payables and Receivables Mngmt
2011-11-21 19:42 eduardo_Argal Status new => scheduled
2011-11-21 19:42 eduardo_Argal fix_in_branch => pi
2011-11-21 19:42 hgbot Checkin
2011-11-21 19:42 hgbot Note Added: 0043025
2011-11-21 19:42 hgbot Status scheduled => resolved
2011-11-21 19:42 hgbot Resolution open => fixed
2011-11-21 19:42 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2b117851284f72fc12914de21fc4de18dd96741f [^]
2011-11-21 20:06 eduardo_Argal Note Added: 0043026
2011-11-22 03:50 hudsonbot Checkin
2011-11-22 03:50 hudsonbot Note Added: 0043067
2011-11-30 15:50 vmromanos Note Added: 0043587
2011-11-30 15:50 vmromanos Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker