Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019127Openbravo ERP09. Financial managementpublic2011-11-21 19:392011-11-30 15:50
Reportereduardo_Argal 
Assigned Toeduardo_Argal 
PrioritynormalSeverityminorReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionpiFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019127: Credit module script loops all business partners
DescriptionCredit module script loops all business partners to fulfill credit payment tab info while it may not be necessary.
As module scripts are executed on every update, improving performance can be important.
A change in code to loop just those business partners which needs to be updated will improve a lot performance
Steps To Reproducerun "ant smartbuild -Dlocal=no" and mind that module script takes too long.
Proposed SolutionModify primary sql just to loop those business partners which contains payments that needs to be updated
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0019128pi closed eduardo_Argal Credit module script loops all business partners 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-11-21 19:39eduardo_ArgalNew Issue
2011-11-21 19:39eduardo_ArgalAssigned To => eduardo_Argal
2011-11-21 19:39eduardo_ArgalModules => Core
2011-11-21 19:40eduardo_ArgalModulesCore => Advanced Payables and Receivables Mngmt
2011-11-21 19:42eduardo_ArgalStatusnew => scheduled
2011-11-21 19:42eduardo_Argalfix_in_branch => pi
2011-11-21 19:42hgbotCheckin
2011-11-21 19:42hgbotNote Added: 0043025
2011-11-21 19:42hgbotStatusscheduled => resolved
2011-11-21 19:42hgbotResolutionopen => fixed
2011-11-21 19:42hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2b117851284f72fc12914de21fc4de18dd96741f [^]
2011-11-21 20:06eduardo_ArgalNote Added: 0043026
2011-11-22 03:50hudsonbotCheckin
2011-11-22 03:50hudsonbotNote Added: 0043067
2011-11-30 15:50vmromanosNote Added: 0043587
2011-11-30 15:50vmromanosStatusresolved => closed

Notes
(0043025)
hgbot   
2011-11-21 19:42   
Repository: erp/devel/pi
Changeset: 2b117851284f72fc12914de21fc4de18dd96741f
Author: Eduardo Argal Guibert <eduardo.argal <at> openbravo.com>
Date: Mon Nov 21 19:42:18 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/2b117851284f72fc12914de21fc4de18dd96741f [^]

fixes bug 19127: Credit module script loops all business partners

---
M modules/org.openbravo.advpaymentmngt/build/classes/org/openbravo/advpaymentmngt/modulescript/LinkCreditPaymentsData.class
M modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/org/openbravo/advpaymentmngt/modulescript/LinkCreditPayments_data.xsql
M modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/src/org/openbravo/advpaymentmngt/modulescript/LinkCreditPaymentsData.java
---
(0043026)
eduardo_Argal   
2011-11-21 20:06   
Test plan:

generate some payments consuming credit in an instance with some thousands of business partners on mp5, where there was no credit payment tab and run "ant smartbuild -Dlocal=no". Mind that now performance is better

Regressions: the risk of regressions is low. Just broken modulescript could introduce one and it has already been tested
(0043067)
hudsonbot   
2011-11-22 03:50   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ebd713dfe507 [^]

Maturity status: Test
(0043587)
vmromanos   
2011-11-30 15:50   
Code review OK
Testing OK. The module script continues to work as designed after this change.