Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0018781
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajorhave not tried2011-10-17 09:122011-11-04 13:57
ReportermtaalView Statuspublic 
Assigned Tomtaal 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision36a68ff40ca2
ProjectionnoneETAnoneTarget Version3.0MP5
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0018781: Javascript: local vars are not declared

DescriptionThere are many occurences of local vars not being declared in the javascript code.
Steps To ReproduceApply the attached jslint diff to enable checking of non-local declared vars.
TagsNo tags attached.
Attached Fileslog file icon errors.log [^] (79,497 bytes) 2011-10-17 09:12
diff file icon jslint.diff [^] (534 bytes) 2011-10-17 09:13 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 00187823.0MP5 closedmarvintm Unclear/undefined variable 
related to defect 00187923.0MP5 closedmirurita Advanced payment javascript uses undeclared variables 

-  Notes
(0041858)
hgbot (developer)
2011-10-17 17:44

 Repository: erp/devel/pi
Changeset: 36a68ff40ca2dbc70f7c750449142179723717f3
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Oct 17 17:44:04 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/36a68ff40ca2dbc70f7c750449142179723717f3 [^]

Fixes issue 18781: Javascript: local vars are not declared

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-checkbox.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-datechooser.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-fk-filter.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-list.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-section-audit.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js
M modules/org.openbravo.client.widgets/web/org.openbravo.client.widgets/js/ob-gcal.js
M modules/org.openbravo.client.widgets/web/org.openbravo.client.widgets/js/ob-twitter.js
---
(0042007)
hudsonbot (viewer)
2011-10-23 13:41

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/35bf0a7aa166 [^]

Maturity status: Test
(0042075)
hgbot (developer)
2011-10-24 23:22

 Repository: erp/devel/pi
Changeset: 103c7719b60156218abf0b3922f3dec52d858785
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Mon Oct 24 23:16:22 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/103c7719b60156218abf0b3922f3dec52d858785 [^]

Issue 18781: Annotate source code with available globals

---
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-link-widget.js
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-widget.js
---
(0042076)
hgbot (developer)
2011-10-24 23:22

 Repository: erp/devel/pi
Changeset: fc3f177182834c7df69f1d8fccbdcd2c2f8c863d
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Mon Oct 24 23:17:12 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/fc3f177182834c7df69f1d8fccbdcd2c2f8c863d [^]

Issue 18781: Annotate the source code with available globals

---
M modules/org.openbravo.client.myob/web/org.openbravo.client.myob/js/ob-community-branding-widget.js
---
(0042077)
hgbot (developer)
2011-10-24 23:22

 Repository: erp/devel/pi
Changeset: b249bed2371e9e8295427c4d02edf0e8b524dae0
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Mon Oct 24 23:20:02 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b249bed2371e9e8295427c4d02edf0e8b524dae0 [^]

Issue 18781: Fixes use of undeclared variables

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-search.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
(0042078)
hgbot (developer)
2011-10-24 23:22

 Repository: erp/devel/pi
Changeset: 62ad106caee506009f6d6621fa194589bf0a86d2
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Mon Oct 24 23:21:34 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/62ad106caee506009f6d6621fa194589bf0a86d2 [^]

Issue 18781: Enabled the detection of undeclared variables

---
M modules/org.openbravo.client.kernel/jslint/jslint
---
(0042148)
hgbot (developer)
2011-10-27 12:26

 Repository: erp/devel/pi
Changeset: f3e6dd15400b0dc8f4ecfd50b36ada8046de62a2
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Thu Oct 27 12:26:01 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f3e6dd15400b0dc8f4ecfd50b36ada8046de62a2 [^]

Issue 18781: Added an undeclared variable

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-grid.js
---
(0042421)
iperdomo (viewer)
2011-10-31 17:37

 The jslint script already includes the --undef flag.
Tested on pi @ rev b2c924670350
(0042555)
hudsonbot (viewer)
2011-11-04 13:56

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d10da320df2a [^]

Maturity status: Test
(0042556)
hudsonbot (viewer)
2011-11-04 13:56

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d10da320df2a [^]

Maturity status: Test
(0042557)
hudsonbot (viewer)
2011-11-04 13:56

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d10da320df2a [^]

Maturity status: Test
(0042558)
hudsonbot (viewer)
2011-11-04 13:56

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d10da320df2a [^]

Maturity status: Test
(0042581)
hudsonbot (viewer)
2011-11-04 13:57

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d10da320df2a [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2011-10-17 09:12 mtaal New Issue
2011-10-17 09:12 mtaal Assigned To => mtaal
2011-10-17 09:12 mtaal File Added: errors.log
2011-10-17 09:12 mtaal Modules => Core
2011-10-17 09:12 mtaal OBNetwork customer => No
2011-10-17 09:13 mtaal File Added: jslint.diff
2011-10-17 09:29 mtaal Relationship added related to 0018782
2011-10-17 17:44 hgbot Checkin
2011-10-17 17:44 hgbot Note Added: 0041858
2011-10-17 17:44 hgbot Status new => resolved
2011-10-17 17:44 hgbot Resolution open => fixed
2011-10-17 17:44 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/36a68ff40ca2dbc70f7c750449142179723717f3 [^]
2011-10-17 17:50 mtaal Relationship added related to 0018792
2011-10-23 13:41 hudsonbot Checkin
2011-10-23 13:41 hudsonbot Note Added: 0042007
2011-10-24 23:22 hgbot Checkin
2011-10-24 23:22 hgbot Note Added: 0042075
2011-10-24 23:22 hgbot Checkin
2011-10-24 23:22 hgbot Note Added: 0042076
2011-10-24 23:22 hgbot Checkin
2011-10-24 23:22 hgbot Note Added: 0042077
2011-10-24 23:22 hgbot Checkin
2011-10-24 23:22 hgbot Note Added: 0042078
2011-10-27 12:26 hgbot Checkin
2011-10-27 12:26 hgbot Note Added: 0042148
2011-10-31 17:37 iperdomo Note Added: 0042421
2011-10-31 17:37 iperdomo Status resolved => closed
2011-11-04 13:56 hudsonbot Checkin
2011-11-04 13:56 hudsonbot Note Added: 0042555
2011-11-04 13:56 hudsonbot Checkin
2011-11-04 13:56 hudsonbot Note Added: 0042556
2011-11-04 13:56 hudsonbot Checkin
2011-11-04 13:56 hudsonbot Note Added: 0042557
2011-11-04 13:56 hudsonbot Checkin
2011-11-04 13:56 hudsonbot Note Added: 0042558
2011-11-04 13:57 hudsonbot Checkin
2011-11-04 13:57 hudsonbot Note Added: 0042581

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker