Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0018781Openbravo ERPA. Platformpublic2011-10-17 09:122011-11-04 13:57
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP5Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0018781: Javascript: local vars are not declared
DescriptionThere are many occurences of local vars not being declared in the javascript code.
Steps To ReproduceApply the attached jslint diff to enable checking of non-local declared vars.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00187823.0MP5 closed marvintm Unclear/undefined variable 
related to defect 00187923.0MP5 closed mirurita Advanced payment javascript uses undeclared variables 
Attached Fileslog errors.log (79,497) 2011-10-17 09:12
https://issues.openbravo.com/file_download.php?file_id=4644&type=bug
diff jslint.diff (534) 2011-10-17 09:13
https://issues.openbravo.com/file_download.php?file_id=4645&type=bug
Issue History
Date ModifiedUsernameFieldChange
2011-10-17 09:12mtaalNew Issue
2011-10-17 09:12mtaalAssigned To => mtaal
2011-10-17 09:12mtaalFile Added: errors.log
2011-10-17 09:12mtaalModules => Core
2011-10-17 09:13mtaalFile Added: jslint.diff
2011-10-17 09:29mtaalRelationship addedrelated to 0018782
2011-10-17 17:44hgbotCheckin
2011-10-17 17:44hgbotNote Added: 0041858
2011-10-17 17:44hgbotStatusnew => resolved
2011-10-17 17:44hgbotResolutionopen => fixed
2011-10-17 17:44hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/36a68ff40ca2dbc70f7c750449142179723717f3 [^]
2011-10-17 17:50mtaalRelationship addedrelated to 0018792
2011-10-23 13:41hudsonbotCheckin
2011-10-23 13:41hudsonbotNote Added: 0042007
2011-10-24 23:22hgbotCheckin
2011-10-24 23:22hgbotNote Added: 0042075
2011-10-24 23:22hgbotCheckin
2011-10-24 23:22hgbotNote Added: 0042076
2011-10-24 23:22hgbotCheckin
2011-10-24 23:22hgbotNote Added: 0042077
2011-10-24 23:22hgbotCheckin
2011-10-24 23:22hgbotNote Added: 0042078
2011-10-27 12:26hgbotCheckin
2011-10-27 12:26hgbotNote Added: 0042148
2011-10-31 17:37iperdomoNote Added: 0042421
2011-10-31 17:37iperdomoStatusresolved => closed
2011-11-04 13:56hudsonbotCheckin
2011-11-04 13:56hudsonbotNote Added: 0042555
2011-11-04 13:56hudsonbotCheckin
2011-11-04 13:56hudsonbotNote Added: 0042556
2011-11-04 13:56hudsonbotCheckin
2011-11-04 13:56hudsonbotNote Added: 0042557
2011-11-04 13:56hudsonbotCheckin
2011-11-04 13:56hudsonbotNote Added: 0042558
2011-11-04 13:57hudsonbotCheckin
2011-11-04 13:57hudsonbotNote Added: 0042581

Notes
(0041858)
hgbot   
2011-10-17 17:44   
Repository: erp/devel/pi
Changeset: 36a68ff40ca2dbc70f7c750449142179723717f3
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Oct 17 17:44:04 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/36a68ff40ca2dbc70f7c750449142179723717f3 [^]

Fixes issue 18781: Javascript: local vars are not declared

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-checkbox.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-datechooser.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-fk-filter.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-list.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-section-audit.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js
M modules/org.openbravo.client.widgets/web/org.openbravo.client.widgets/js/ob-gcal.js
M modules/org.openbravo.client.widgets/web/org.openbravo.client.widgets/js/ob-twitter.js
---
(0042007)
hudsonbot   
2011-10-23 13:41   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/35bf0a7aa166 [^]

Maturity status: Test
(0042075)
hgbot   
2011-10-24 23:22   
Repository: erp/devel/pi
Changeset: 103c7719b60156218abf0b3922f3dec52d858785
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Mon Oct 24 23:16:22 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/103c7719b60156218abf0b3922f3dec52d858785 [^]

Issue 18781: Annotate source code with available globals

---
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-link-widget.js
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-widget.js
---
(0042076)
hgbot   
2011-10-24 23:22   
Repository: erp/devel/pi
Changeset: fc3f177182834c7df69f1d8fccbdcd2c2f8c863d
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Mon Oct 24 23:17:12 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/fc3f177182834c7df69f1d8fccbdcd2c2f8c863d [^]

Issue 18781: Annotate the source code with available globals

---
M modules/org.openbravo.client.myob/web/org.openbravo.client.myob/js/ob-community-branding-widget.js
---
(0042077)
hgbot   
2011-10-24 23:22   
Repository: erp/devel/pi
Changeset: b249bed2371e9e8295427c4d02edf0e8b524dae0
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Mon Oct 24 23:20:02 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b249bed2371e9e8295427c4d02edf0e8b524dae0 [^]

Issue 18781: Fixes use of undeclared variables

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-search.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
(0042078)
hgbot   
2011-10-24 23:22   
Repository: erp/devel/pi
Changeset: 62ad106caee506009f6d6621fa194589bf0a86d2
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Mon Oct 24 23:21:34 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/62ad106caee506009f6d6621fa194589bf0a86d2 [^]

Issue 18781: Enabled the detection of undeclared variables

---
M modules/org.openbravo.client.kernel/jslint/jslint
---
(0042148)
hgbot   
2011-10-27 12:26   
Repository: erp/devel/pi
Changeset: f3e6dd15400b0dc8f4ecfd50b36ada8046de62a2
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Thu Oct 27 12:26:01 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f3e6dd15400b0dc8f4ecfd50b36ada8046de62a2 [^]

Issue 18781: Added an undeclared variable

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-grid.js
---
(0042421)
iperdomo   
2011-10-31 17:37   
The jslint script already includes the --undef flag.
Tested on pi @ rev b2c924670350
(0042555)
hudsonbot   
2011-11-04 13:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d10da320df2a [^]

Maturity status: Test
(0042556)
hudsonbot   
2011-11-04 13:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d10da320df2a [^]

Maturity status: Test
(0042557)
hudsonbot   
2011-11-04 13:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d10da320df2a [^]

Maturity status: Test
(0042558)
hudsonbot   
2011-11-04 13:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d10da320df2a [^]

Maturity status: Test
(0042581)
hudsonbot   
2011-11-04 13:57   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d10da320df2a [^]

Maturity status: Test