Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0018375 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| feature request | [Openbravo ERP] A. Platform | major | always | 2011-08-29 15:03 | 2011-11-03 16:32 | |||
| Reporter | pjuvara | View Status | public | |||||
| Assigned To | dbaz | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 42932d481107 | ||||
| Projection | none | ETA | none | Target Version | 3.0MP5 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0018375: Logo images should automatically resize | |||||||
| Description | Openbravo allows user to specify a number of company logos. Each logo is expected to be in a specific size. However, finding the size is difficult and requiring users to resize logos is just unpractical and not what users expect (most applications resize images automatically). If users upload the image in the wrong size, the image is either cut or it overlaps other elements on the screen. (see http://wiki.openbravo.com/wiki/ERP_2.50:Configuration_Manual/Personalizing_Openbravo_ERP#Adding_your_company_logo [^] for the list of logos and expected sizes - this applies to 2.50 but it is the same with Openbravo 3) We need to implement the following improvements: 1) Modify the on line help to list the expected size of each image. 2) When images are uploaded, if they exceed the expected size they should be scaled down to fit within the expected dimension. 3) Images should be scaled down respecting the ratio, to avoid distortion of logos. 4) The resize action should be performed before the images are saved in the database to avoid to have to perform it every time or to delegate it to the browser. If user uploads a 20Mpx image, we should not ask the browser to download 20Mpx to then render only 197x55. 5) If images are smaller than the expected size, they should not be resized but rendered centered in the space allocated to them. | |||||||
| Steps To Reproduce | See above. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0040807) iciordia (viewer) 2011-09-07 17:04 |
Let me restate the improvements to fix this issue: Must have: -There should be a clear message when uploading images about the expected size of the image to be uploaded -If the uploaded image does not fit the expected size the system should warn the user -If images are smaller than the expected size, they should not be resized but rendered centered in the space allocated to them. -Update the on line help to list the expected size of each image. Nice to have: -When images are uploaded, if they exceed the expected size they should be scaled down to fit within the expected dimension. In any case the user should get a message (the image does not fit, it is gonna be automatically adjusted, it might distort it). If an image is scaled down the system should respect the ratio, to avoid distortion of logos. The resize action should be performed before the images are saved in the database to avoid to have to perform it every time or to delegate it to the browser. If user uploads a 20Mpx image, we should not ask the browser to download 20Mpx to then render only 197x55. |
|
(0041796) hgbot (developer) 2011-10-13 13:02 |
Repository: erp/devel/pi Changeset: 42932d481107b4435a1a4ba0ae9ee7c804b5ffb1 Author: David Baz Fayos <david.baz <at> openbravo.com> Date: Thu Oct 13 12:59:46 2011 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/42932d481107b4435a1a4ba0ae9ee7c804b5ffb1 [^] Fixed issue 18375: Now logos are automatically resized to the proper size when is uploaded --- M src-db/database/sourcedata/AD_COLUMN.xml --- |
|
(0041892) hudsonbot (viewer) 2011-10-18 17:26 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/3a0e09f510aa [^] Maturity status: Test |
|
(0041956) hgbot (developer) 2011-10-20 17:10 |
Repository: erp/devel/pi Changeset: 6dac50585cc3f21c965b1214fb5a80f79a4a3444 Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Thu Oct 20 17:10:05 2011 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/6dac50585cc3f21c965b1214fb5a80f79a4a3444 [^] Related to issue 18375. Set Action column as mandatory --- M src-db/database/model/tables/AD_COLUMN.xml M src-db/database/sourcedata/AD_COLUMN.xml --- |
|
(0042032) hudsonbot (viewer) 2011-10-23 13:42 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/35bf0a7aa166 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2011-08-29 15:03 | pjuvara | New Issue | |
| 2011-08-29 15:03 | pjuvara | Assigned To | => alostale |
| 2011-08-29 15:03 | pjuvara | Modules | => Core |
| 2011-08-29 15:03 | pjuvara | OBNetwork customer | => No |
| 2011-08-30 14:53 | rgoris | Issue Monitored: rgoris | |
| 2011-08-30 16:11 | rgoris | Assigned To | alostale => dbaz |
| 2011-08-30 16:11 | rgoris | Target Version | => 3.0MP4 |
| 2011-08-30 16:12 | rgoris | Status | new => scheduled |
| 2011-08-30 16:12 | rgoris | fix_in_branch | => pi |
| 2011-09-07 17:04 | iciordia | Note Added: 0040807 | |
| 2011-10-03 16:16 | dbaz | Target Version | 3.0MP4 => 3.0MP5 |
| 2011-10-03 16:16 | dbaz | fix_in_branch | pi => |
| 2011-10-13 13:02 | hgbot | Checkin | |
| 2011-10-13 13:02 | hgbot | Note Added: 0041796 | |
| 2011-10-13 13:02 | hgbot | Status | scheduled => resolved |
| 2011-10-13 13:02 | hgbot | Resolution | open => fixed |
| 2011-10-13 13:02 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/42932d481107b4435a1a4ba0ae9ee7c804b5ffb1 [^] |
| 2011-10-18 17:26 | hudsonbot | Checkin | |
| 2011-10-18 17:26 | hudsonbot | Note Added: 0041892 | |
| 2011-10-20 17:10 | hgbot | Checkin | |
| 2011-10-20 17:10 | hgbot | Note Added: 0041956 | |
| 2011-10-23 13:42 | hudsonbot | Checkin | |
| 2011-10-23 13:42 | hudsonbot | Note Added: 0042032 | |
| 2011-11-03 16:32 | marvintm | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |