Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0018375Openbravo ERPA. Platformpublic2011-08-29 15:032011-11-03 16:32
Reporterpjuvara 
Assigned Todbaz 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP5Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0018375: Logo images should automatically resize
DescriptionOpenbravo allows user to specify a number of company logos. Each logo is expected to be in a specific size.

However, finding the size is difficult and requiring users to resize logos is just unpractical and not what users expect (most applications resize images automatically).

If users upload the image in the wrong size, the image is either cut or it overlaps other elements on the screen.

(see http://wiki.openbravo.com/wiki/ERP_2.50:Configuration_Manual/Personalizing_Openbravo_ERP#Adding_your_company_logo [^] for the list of logos and expected sizes - this applies to 2.50 but it is the same with Openbravo 3)

We need to implement the following improvements:
1) Modify the on line help to list the expected size of each image.
2) When images are uploaded, if they exceed the expected size they should be scaled down to fit within the expected dimension.
3) Images should be scaled down respecting the ratio, to avoid distortion of logos.
4) The resize action should be performed before the images are saved in the database to avoid to have to perform it every time or to delegate it to the browser. If user uploads a 20Mpx image, we should not ask the browser to download 20Mpx to then render only 197x55.
5) If images are smaller than the expected size, they should not be resized but rendered centered in the space allocated to them.
Steps To ReproduceSee above.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-08-29 15:03pjuvaraNew Issue
2011-08-29 15:03pjuvaraAssigned To => alostale
2011-08-29 15:03pjuvaraModules => Core
2011-08-29 15:03pjuvaraOBNetwork customer => No
2011-08-30 14:53rgorisIssue Monitored: rgoris
2011-08-30 16:11rgorisAssigned Toalostale => dbaz
2011-08-30 16:11rgorisTarget Version => 3.0MP4
2011-08-30 16:12rgorisStatusnew => scheduled
2011-08-30 16:12rgorisfix_in_branch => pi
2011-09-07 17:04iciordiaNote Added: 0040807
2011-10-03 16:16dbazTarget Version3.0MP4 => 3.0MP5
2011-10-03 16:16dbazfix_in_branchpi =>
2011-10-13 13:02hgbotCheckin
2011-10-13 13:02hgbotNote Added: 0041796
2011-10-13 13:02hgbotStatusscheduled => resolved
2011-10-13 13:02hgbotResolutionopen => fixed
2011-10-13 13:02hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/42932d481107b4435a1a4ba0ae9ee7c804b5ffb1 [^]
2011-10-18 17:26hudsonbotCheckin
2011-10-18 17:26hudsonbotNote Added: 0041892
2011-10-20 17:10hgbotCheckin
2011-10-20 17:10hgbotNote Added: 0041956
2011-10-23 13:42hudsonbotCheckin
2011-10-23 13:42hudsonbotNote Added: 0042032
2011-11-03 16:32marvintmStatusresolved => closed

Notes
(0040807)
iciordia   
2011-09-07 17:04   
Let me restate the improvements to fix this issue:

Must have:
-There should be a clear message when uploading images about the expected size of the image to be uploaded
-If the uploaded image does not fit the expected size the system should warn the user
-If images are smaller than the expected size, they should not be resized but rendered centered in the space allocated to them.
-Update the on line help to list the expected size of each image.

Nice to have:
-When images are uploaded, if they exceed the expected size they should be scaled down to fit within the expected dimension. In any case the user should get a message (the image does not fit, it is gonna be automatically adjusted, it might distort it). If an image is scaled down the system should respect the ratio, to avoid distortion of logos. The resize action should be performed before the images are saved in the database to avoid to have to perform it every time or to delegate it to the browser. If user uploads a 20Mpx image, we should not ask the browser to download 20Mpx to then render only 197x55.
(0041796)
hgbot   
2011-10-13 13:02   
Repository: erp/devel/pi
Changeset: 42932d481107b4435a1a4ba0ae9ee7c804b5ffb1
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Thu Oct 13 12:59:46 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/42932d481107b4435a1a4ba0ae9ee7c804b5ffb1 [^]

Fixed issue 18375: Now logos are automatically resized to the proper size when is uploaded

---
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0041892)
hudsonbot   
2011-10-18 17:26   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/3a0e09f510aa [^]

Maturity status: Test
(0041956)
hgbot   
2011-10-20 17:10   
Repository: erp/devel/pi
Changeset: 6dac50585cc3f21c965b1214fb5a80f79a4a3444
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Oct 20 17:10:05 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6dac50585cc3f21c965b1214fb5a80f79a4a3444 [^]

Related to issue 18375. Set Action column as mandatory

---
M src-db/database/model/tables/AD_COLUMN.xml
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0042032)
hudsonbot   
2011-10-23 13:42   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/35bf0a7aa166 [^]

Maturity status: Test