Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0018274
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] E. Translationmajoralways2011-08-12 15:152011-08-17 18:11
Reporterneil_smithView Statuspublic 
Assigned Toiperdomo 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisionf574dedd5134
ProjectionnoneETAnoneTarget Version3.0MP3
OSAnyDatabasePostgreSQLJava version
OS VersionDatabase versionAnt version
Product Version3.0MP0SCM revision 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0018274: Translation problem - JSCompressor error

DescriptionI'm having a weird error on my OB 3.0.12774.

I've been working with the english version, and all works fine.
I then tried to install our french translation (via XML files that I took from our 2.5 version), but my purchase order window doesn't work any more...
It works in English, but if I change the language to french, doesn't work.
The error I get is :

ERROR org.openbravo.client.kernel.JSCompressor - Unterminated string literal at line 47 and column 0
net.matthaynes.jsmin.JSMin$UnterminatedStringLiteralException: Unterminated string literal at line 47 and column 0
at net.matthaynes.jsmin.JSMin.action(Unknown Source)
at net.matthaynes.jsmin.JSMin.jsmin(Unknown Source)
at org.openbravo.client.kernel.JSCompressor.compress (JSCompressor.java:57)
...

I tried debuggins JSCompressor and outputting all that it passes to JSMin and I found that the error occured while processing the tab named "Commande d'Achat", and the ' in the name made the whole thing fail... If the ' is in the window name, in the field name, ... it works, but not in the tab name.
Steps To ReproduceTranslate any tab name to something with an ' in it.
Proposed SolutionEscape all special characters
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0018729 closedalostale Translation problem - JSCompressor error 

-  Notes
(0040169)
iperdomo (viewer)
2011-08-12 15:36

 @neil_smith:
Can you please attach the XML files you used for reproducing the issue?

Thanks,

Iván
(0040171)
neil_smith (viewer)
2011-08-15 10:01

 @Iván:
Sorry, I corrected all my XML files so there aren't any ' in them any more...
But you can simply enter the translation of a tab name and put a ' in it and you will get the bug.

Have a nice day
Neil.
(0040237)
hgbot (developer)
2011-08-16 19:28

 Repository: erp/devel/pi
Changeset: f574dedd5134ba8eb0654a208d558f660ec72a77
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Tue Aug 16 19:28:30 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f574dedd5134ba8eb0654a208d558f660ec72a77 [^]

Fixes issue 18274: The tab name was not properly escaped
- If a tab name contains a quote (') the generated code is broken

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/templates/ob-view-tab.js.ftl
---
(0040252)
adrianromero (viewer)
2011-08-17 12:15

 Verified
(0040282)
hudsonbot (viewer)
2011-08-17 18:11

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5922b23c1f55 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2011-08-12 15:15 neil_smith New Issue
2011-08-12 15:15 neil_smith Assigned To => alostale
2011-08-12 15:15 neil_smith Modules => Core
2011-08-12 15:35 iperdomo Assigned To alostale => iperdomo
2011-08-12 15:35 iperdomo Status new => scheduled
2011-08-12 15:35 iperdomo fix_in_branch => pi
2011-08-12 15:36 iperdomo OBNetwork customer => No
2011-08-12 15:36 iperdomo Target Version => 3.0MP3
2011-08-12 15:36 iperdomo fix_in_branch pi =>
2011-08-12 15:36 iperdomo Note Added: 0040169
2011-08-15 10:01 neil_smith Note Added: 0040171
2011-08-16 19:28 hgbot Checkin
2011-08-16 19:28 hgbot Note Added: 0040237
2011-08-16 19:28 hgbot Status scheduled => resolved
2011-08-16 19:28 hgbot Resolution open => fixed
2011-08-16 19:28 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f574dedd5134ba8eb0654a208d558f660ec72a77 [^]
2011-08-17 12:15 adrianromero Note Added: 0040252
2011-08-17 12:15 adrianromero Status resolved => closed
2011-08-17 18:11 hudsonbot Checkin
2011-08-17 18:11 hudsonbot Note Added: 0040282
2012-06-15 16:33 alostale Relationship added related to 0018729

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker