Openbravo Issue Tracking System - Openbravo ERP |
View Issue Details |
|
ID | Project | Category | View Status | Date Submitted | Last Update |
0018274 | Openbravo ERP | E. Translation | public | 2011-08-12 15:15 | 2011-08-17 18:11 |
|
Reporter | neil_smith | |
Assigned To | iperdomo | |
Priority | normal | Severity | major | Reproducibility | always |
Status | closed | Resolution | fixed | |
Platform | | OS | 5 | OS Version | |
Product Version | 3.0MP0 | |
Target Version | 3.0MP3 | Fixed in Version | | |
Merge Request Status | |
Review Assigned To | |
OBNetwork customer | No |
Web browser | |
Modules | Core |
Support ticket | |
Regression level | |
Regression date | |
Regression introduced in release | |
Regression introduced by commit | |
Triggers an Emergency Pack | No |
|
Summary | 0018274: Translation problem - JSCompressor error |
Description | I'm having a weird error on my OB 3.0.12774.
I've been working with the english version, and all works fine.
I then tried to install our french translation (via XML files that I took from our 2.5 version), but my purchase order window doesn't work any more...
It works in English, but if I change the language to french, doesn't work.
The error I get is :
ERROR org.openbravo.client.kernel.JSCompressor - Unterminated string literal at line 47 and column 0
net.matthaynes.jsmin.JSMin$UnterminatedStringLiteralException: Unterminated string literal at line 47 and column 0
at net.matthaynes.jsmin.JSMin.action(Unknown Source)
at net.matthaynes.jsmin.JSMin.jsmin(Unknown Source)
at org.openbravo.client.kernel.JSCompressor.compress (JSCompressor.java:57)
...
I tried debuggins JSCompressor and outputting all that it passes to JSMin and I found that the error occured while processing the tab named "Commande d'Achat", and the ' in the name made the whole thing fail... If the ' is in the window name, in the field name, ... it works, but not in the tab name. |
Steps To Reproduce | Translate any tab name to something with an ' in it. |
Proposed Solution | Escape all special characters |
Additional Information | |
Tags | No tags attached. |
Relationships | related to | defect | 0018729 | | closed | alostale | Translation problem - JSCompressor error |
|
Attached Files | |
|
Issue History |
Date Modified | Username | Field | Change |
2011-08-12 15:15 | neil_smith | New Issue | |
2011-08-12 15:15 | neil_smith | Assigned To | => alostale |
2011-08-12 15:15 | neil_smith | Modules | => Core |
2011-08-12 15:35 | iperdomo | Assigned To | alostale => iperdomo |
2011-08-12 15:35 | iperdomo | Status | new => scheduled |
2011-08-12 15:35 | iperdomo | fix_in_branch | => pi |
2011-08-12 15:36 | iperdomo | OBNetwork customer | => No |
2011-08-12 15:36 | iperdomo | Target Version | => 3.0MP3 |
2011-08-12 15:36 | iperdomo | fix_in_branch | pi => |
2011-08-12 15:36 | iperdomo | Note Added: 0040169 | |
2011-08-15 10:01 | neil_smith | Note Added: 0040171 | |
2011-08-16 19:28 | hgbot | Checkin | |
2011-08-16 19:28 | hgbot | Note Added: 0040237 | |
2011-08-16 19:28 | hgbot | Status | scheduled => resolved |
2011-08-16 19:28 | hgbot | Resolution | open => fixed |
2011-08-16 19:28 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/f574dedd5134ba8eb0654a208d558f660ec72a77 [^] |
2011-08-17 12:15 | adrianromero | Note Added: 0040252 | |
2011-08-17 12:15 | adrianromero | Status | resolved => closed |
2011-08-17 18:11 | hudsonbot | Checkin | |
2011-08-17 18:11 | hudsonbot | Note Added: 0040282 | |
2012-06-15 16:33 | alostale | Relationship added | related to 0018729 |
Notes |
|
|
@neil_smith:
Can you please attach the XML files you used for reproducing the issue?
Thanks,
Iván |
|
|
|
@Iván:
Sorry, I corrected all my XML files so there aren't any ' in them any more...
But you can simply enter the translation of a tab name and put a ' in it and you will get the bug.
Have a nice day
Neil. |
|
|
(0040237)
|
hgbot
|
2011-08-16 19:28
|
|
Repository: erp/devel/pi
Changeset: f574dedd5134ba8eb0654a208d558f660ec72a77
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Tue Aug 16 19:28:30 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f574dedd5134ba8eb0654a208d558f660ec72a77 [^]
Fixes issue 18274: The tab name was not properly escaped
- If a tab name contains a quote (') the generated code is broken
---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/templates/ob-view-tab.js.ftl
---
|
|
|
|
|
|
|
|