Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0017810
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Y. DBSourceManagerminorhave not tried2011-06-28 13:532011-07-06 02:41
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision9d15a8304226
ProjectionnoneETAnoneTarget Version3.0MP1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0017810: Function&Trigger-Standardization on pgsql could be made 5-10s faster

Descriptionby removing one translation regex which is not changing anything.


    append(new ByLineTranslation(new ReplacePatTranslation(
        "(.+?)(v_pesos|v_units|v_tens|v_hundreds|v_tenys|v_twentys)(\\[)(.+?)(\\])([^\\)]+?)$",
        "$1$2[$4]$6")));

This regex in the PostgrePLSQLStandardization does not do any changes to the string but takes some (accumulated) 5-10s at runtime (depending on system).

Steps To Reproducen/a
Proposed SolutionRemove the regex as it doesn't do any changes.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
depends on backport 0017811 closedshuehner Function&Trigger-Standardization on pgsql could be made 5-10s faster 

-  Notes
(0038561)
hgbot (developer)
2011-06-28 15:37

Repository: erp/devel/pi
Changeset: e1d5f2393ed8deaae82b028ce879053d04108e5a
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue Jun 28 14:07:26 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e1d5f2393ed8deaae82b028ce879053d04108e5a [^]

Fixed 17796, Fixed 17810: Speed up model loading
- part one: read tables on oracle faster
- part two: function/trigger standardization on pgsql faster

---
M src-db/database/lib/dbsourcemanager.jar
---
(0038637)
hgbot (developer)
2011-06-30 15:48

Repository: erp/devel/dbsm-main
Changeset: 9d15a8304226f6069cad17b461bcd319cd74da8c
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue Jun 28 13:55:44 2011 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/9d15a8304226f6069cad17b461bcd319cd74da8c [^]

Fixed 17810, Fixed 17811: Make pgsql function & trigger standardization faster
This removes a regex application which is not changing anything in the data so
can be removed without functional changes. Gains some 5-10s at runtime depending
on system.

---
M src/org/apache/ddlutils/platform/postgresql/PostgrePLSQLStandarization.java
---
(0038816)
hudsonbot (developer)
2011-07-06 02:41

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f1c481b1a146 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2011-06-28 13:53 shuehner New Issue
2011-06-28 13:53 shuehner Assigned To => shuehner
2011-06-28 13:53 shuehner Modules => Core
2011-06-28 13:53 shuehner Status new => scheduled
2011-06-28 13:53 shuehner fix_in_branch => pi
2011-06-28 15:37 hgbot Checkin
2011-06-28 15:37 hgbot Note Added: 0038561
2011-06-28 15:37 hgbot Status scheduled => resolved
2011-06-28 15:37 hgbot Resolution open => fixed
2011-06-28 15:37 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e1d5f2393ed8deaae82b028ce879053d04108e5a [^]
2011-06-30 15:48 hgbot Checkin
2011-06-30 15:48 hgbot Note Added: 0038637
2011-06-30 15:48 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/e1d5f2393ed8deaae82b028ce879053d04108e5a [^] => http://code.openbravo.com/erp/devel/dbsm-main/rev/9d15a8304226f6069cad17b461bcd319cd74da8c [^]
2011-07-01 12:25 shuehner Target Version => 3.0MP1
2011-07-01 12:25 shuehner fix_in_branch pi =>
2011-07-01 18:22 marvintm Status resolved => closed
2011-07-06 02:41 hudsonbot Checkin
2011-07-06 02:41 hudsonbot Note Added: 0038816


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker