Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0017810Openbravo ERPY. DBSourceManagerpublic2011-06-28 13:532011-07-06 02:41
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP1Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0017810: Function&Trigger-Standardization on pgsql could be made 5-10s faster
Descriptionby removing one translation regex which is not changing anything.


    append(new ByLineTranslation(new ReplacePatTranslation(
        "(.+?)(v_pesos|v_units|v_tens|v_hundreds|v_tenys|v_twentys)(\\[)(.+?)(\\])([^\\)]+?)$",
        "$1$2[$4]$6")));

This regex in the PostgrePLSQLStandardization does not do any changes to the string but takes some (accumulated) 5-10s at runtime (depending on system).

Steps To Reproducen/a
Proposed SolutionRemove the regex as it doesn't do any changes.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0017811 closed shuehner Function&Trigger-Standardization on pgsql could be made 5-10s faster 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-06-28 13:53shuehnerNew Issue
2011-06-28 13:53shuehnerAssigned To => shuehner
2011-06-28 13:53shuehnerModules => Core
2011-06-28 13:53shuehnerStatusnew => scheduled
2011-06-28 13:53shuehnerfix_in_branch => pi
2011-06-28 15:37hgbotCheckin
2011-06-28 15:37hgbotNote Added: 0038561
2011-06-28 15:37hgbotStatusscheduled => resolved
2011-06-28 15:37hgbotResolutionopen => fixed
2011-06-28 15:37hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e1d5f2393ed8deaae82b028ce879053d04108e5a [^]
2011-06-30 15:48hgbotCheckin
2011-06-30 15:48hgbotNote Added: 0038637
2011-06-30 15:48hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/e1d5f2393ed8deaae82b028ce879053d04108e5a [^] => http://code.openbravo.com/erp/devel/dbsm-main/rev/9d15a8304226f6069cad17b461bcd319cd74da8c [^]
2011-07-01 12:25shuehnerTarget Version => 3.0MP1
2011-07-01 12:25shuehnerfix_in_branchpi =>
2011-07-01 18:22marvintmStatusresolved => closed
2011-07-06 02:41hudsonbotCheckin
2011-07-06 02:41hudsonbotNote Added: 0038816

Notes
(0038561)
hgbot   
2011-06-28 15:37   
Repository: erp/devel/pi
Changeset: e1d5f2393ed8deaae82b028ce879053d04108e5a
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue Jun 28 14:07:26 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e1d5f2393ed8deaae82b028ce879053d04108e5a [^]

Fixed 17796, Fixed 17810: Speed up model loading
- part one: read tables on oracle faster
- part two: function/trigger standardization on pgsql faster

---
M src-db/database/lib/dbsourcemanager.jar
---
(0038637)
hgbot   
2011-06-30 15:48   
Repository: erp/devel/dbsm-main
Changeset: 9d15a8304226f6069cad17b461bcd319cd74da8c
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue Jun 28 13:55:44 2011 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/9d15a8304226f6069cad17b461bcd319cd74da8c [^]

Fixed 17810, Fixed 17811: Make pgsql function & trigger standardization faster
This removes a regex application which is not changing anything in the data so
can be removed without functional changes. Gains some 5-10s at runtime depending
on system.

---
M src/org/apache/ddlutils/platform/postgresql/PostgrePLSQLStandarization.java
---
(0038816)
hudsonbot   
2011-07-06 02:41   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f1c481b1a146 [^]

Maturity status: Test