Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0017495
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Z. Otherscriticalhave not tried2011-06-04 16:082011-06-16 12:46
ReporterjecharriView Statuspublic 
Assigned Tojecharri 
PriorityimmediateResolutionfixedFixed in Version3.0MP0
StatusclosedFix in branchpiFixed in SCM revision363b15de0901
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0017495: try-2.50-api and try-api has failed because one column has been change

DescriptionDue to this issue,

- https://issues.openbravo.com/view.php?id=17283 [^]

y have to make an api change. This is the change:

- https://code.openbravo.com/erp/devel/try/rev/71d93958e6dc [^]

I have pushed the change to try, this is the failure:

- http://builds.openbravo.com/view/try/job/try-api/392/console [^]
- http://builds.openbravo.com/view/try-2.50/job/try-2.50-api/105/console [^]


- The change is the following:
The column "calccost" from MA_SEQUENCE_EMPLOYEE.CALCCOST, MA_SEQUENCE_IC.CALCCOST and MA_SEQUENCE_MACHINE.CALCCOST tables has been change from numeric(10,0) to numeric.So, now it is posible to put numbers with decimals.

- The change is needed due to the following reason:
This column is referenced to:
        MA_INDIRECT_COST_VALUE.COST
        MA_MACHINE_COST.COST
        MA_COST_CENTER_EMPLOYEE.QUANTITY
and all columns are numeric so it may content decimal values. So, we are losing precision when we use the "Calculate standard cost" process.

- The risk of this api change is very low because of the following reason:
I have only extended the posiblity of the values for this columns.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 00172833.0MP1 closedjecharri Column CALCCOST does not allow decimals 
depends on backport 0017532 closedjecharri try-2.50-api and try-api has failed because one column has been change 

-  Notes
(0038086)
iciordia (manager)
2011-06-07 09:40

Approved. Please confirm with a note in this issue that DAL methods to get/set these columns do not change.

Ismael
(0038104)
jecharri (developer)
2011-06-07 12:24

Checked that before and after the change, DAL attributes do have BigDecimal type.
(0038110)
hgbot (developer)
2011-06-07 12:31

Repository: erp/devel/api-checks
Changeset: 363b15de0901cc585efeb400f2d11962427873d0
Author: Javier Etxarri <javier.echarri <at> openbravo.com>
Date: Tue Jun 07 12:28:46 2011 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/363b15de0901cc585efeb400f2d11962427873d0 [^]

Fixes issue 17495.
Tested database model changed according to fix to issue 17283

---
M model/src-db/database/model/tables/MA_SEQUENCE_EMPLOYEE.xml
M model/src-db/database/model/tables/MA_SEQUENCE_IC.xml
M model/src-db/database/model/tables/MA_SEQUENCE_MACHINE.xml
---
(0038363)
hgbot (developer)
2011-06-16 12:46

Repository: erp/devel/api-checks
Changeset: fedd97c26dfbff6b1a7f86fe1caf787ac2f0e86d
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Thu Jun 16 12:43:52 2011 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/fedd97c26dfbff6b1a7f86fe1caf787ac2f0e86d [^]

Issue 17495: Reapply api-check commit 363b15de0901 after mp0 release

---
M model/src-db/database/model/tables/MA_SEQUENCE_EMPLOYEE.xml
M model/src-db/database/model/tables/MA_SEQUENCE_IC.xml
M model/src-db/database/model/tables/MA_SEQUENCE_MACHINE.xml
---

- Issue History
Date Modified Username Field Change
2011-06-04 16:08 jecharri New Issue
2011-06-04 16:08 jecharri Assigned To => iciordia
2011-06-04 16:08 jecharri Modules => Core
2011-06-06 14:33 jecharri Description Updated View Revisions
2011-06-07 09:40 iciordia Note Added: 0038086
2011-06-07 09:40 iciordia Assigned To iciordia => jecharri
2011-06-07 11:11 jecharri Relationship added related to 0017283
2011-06-07 11:16 jecharri Status new => scheduled
2011-06-07 11:16 jecharri fix_in_branch => pi
2011-06-07 12:24 jecharri Note Added: 0038104
2011-06-07 12:31 hgbot Checkin
2011-06-07 12:31 hgbot Note Added: 0038110
2011-06-07 12:31 hgbot Status scheduled => resolved
2011-06-07 12:31 hgbot Resolution open => fixed
2011-06-07 12:31 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/363b15de0901cc585efeb400f2d11962427873d0 [^]
2011-06-07 16:44 jecharri Status resolved => closed
2011-06-07 16:44 jecharri Fixed in Version => 3.0MP0
2011-06-16 12:46 hgbot Checkin
2011-06-16 12:46 hgbot Note Added: 0038363


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker