Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0017495Openbravo ERPZ. Otherspublic2011-06-04 16:082011-06-16 12:46
Reporterjecharri 
Assigned Tojecharri 
PriorityimmediateSeveritycriticalReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version3.0MP0 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0017495: try-2.50-api and try-api has failed because one column has been change
DescriptionDue to this issue,

- https://issues.openbravo.com/view.php?id=17283 [^]

y have to make an api change. This is the change:

- https://code.openbravo.com/erp/devel/try/rev/71d93958e6dc [^]

I have pushed the change to try, this is the failure:

- http://builds.openbravo.com/view/try/job/try-api/392/console [^]
- http://builds.openbravo.com/view/try-2.50/job/try-2.50-api/105/console [^]


- The change is the following:
The column "calccost" from MA_SEQUENCE_EMPLOYEE.CALCCOST, MA_SEQUENCE_IC.CALCCOST and MA_SEQUENCE_MACHINE.CALCCOST tables has been change from numeric(10,0) to numeric.So, now it is posible to put numbers with decimals.

- The change is needed due to the following reason:
This column is referenced to:
        MA_INDIRECT_COST_VALUE.COST
        MA_MACHINE_COST.COST
        MA_COST_CENTER_EMPLOYEE.QUANTITY
and all columns are numeric so it may content decimal values. So, we are losing precision when we use the "Calculate standard cost" process.

- The risk of this api change is very low because of the following reason:
I have only extended the posiblity of the values for this columns.
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00172833.0MP1 closed jecharri Column CALCCOST does not allow decimals 
depends on backport 0017532 closed jecharri try-2.50-api and try-api has failed because one column has been change 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-06-04 16:08jecharriNew Issue
2011-06-04 16:08jecharriAssigned To => iciordia
2011-06-04 16:08jecharriModules => Core
2011-06-04 16:08jecharriOBNetwork customer => No
2011-06-06 14:33jecharriDescription Updatedbug_revision_view_page.php?rev_id=2178#r2178
2011-06-07 09:40iciordiaNote Added: 0038086
2011-06-07 09:40iciordiaAssigned Toiciordia => jecharri
2011-06-07 11:11jecharriRelationship addedrelated to 0017283
2011-06-07 11:16jecharriStatusnew => scheduled
2011-06-07 11:16jecharrifix_in_branch => pi
2011-06-07 12:24jecharriNote Added: 0038104
2011-06-07 12:31hgbotCheckin
2011-06-07 12:31hgbotNote Added: 0038110
2011-06-07 12:31hgbotStatusscheduled => resolved
2011-06-07 12:31hgbotResolutionopen => fixed
2011-06-07 12:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/363b15de0901cc585efeb400f2d11962427873d0 [^]
2011-06-07 16:44jecharriStatusresolved => closed
2011-06-07 16:44jecharriFixed in Version => 3.0MP0
2011-06-16 12:46hgbotCheckin
2011-06-16 12:46hgbotNote Added: 0038363

Notes
(0038086)
iciordia   
2011-06-07 09:40   
Approved. Please confirm with a note in this issue that DAL methods to get/set these columns do not change.

Ismael
(0038104)
jecharri   
2011-06-07 12:24   
Checked that before and after the change, DAL attributes do have BigDecimal type.
(0038110)
hgbot   
2011-06-07 12:31   
Repository: erp/devel/api-checks
Changeset: 363b15de0901cc585efeb400f2d11962427873d0
Author: Javier Etxarri <javier.echarri <at> openbravo.com>
Date: Tue Jun 07 12:28:46 2011 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/363b15de0901cc585efeb400f2d11962427873d0 [^]

Fixes issue 17495.
Tested database model changed according to fix to issue 17283

---
M model/src-db/database/model/tables/MA_SEQUENCE_EMPLOYEE.xml
M model/src-db/database/model/tables/MA_SEQUENCE_IC.xml
M model/src-db/database/model/tables/MA_SEQUENCE_MACHINE.xml
---
(0038363)
hgbot   
2011-06-16 12:46   
Repository: erp/devel/api-checks
Changeset: fedd97c26dfbff6b1a7f86fe1caf787ac2f0e86d
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Thu Jun 16 12:43:52 2011 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/fedd97c26dfbff6b1a7f86fe1caf787ac2f0e86d [^]

Issue 17495: Reapply api-check commit 363b15de0901 after mp0 release

---
M model/src-db/database/model/tables/MA_SEQUENCE_EMPLOYEE.xml
M model/src-db/database/model/tables/MA_SEQUENCE_IC.xml
M model/src-db/database/model/tables/MA_SEQUENCE_MACHINE.xml
---