Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0017134
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajorhave not tried2011-05-12 11:102011-06-03 17:38
ReportermarvintmView Statuspublic 
Assigned Tomtaal 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisione001e3c8176c
ProjectionnoneETAnoneTarget Version3.0MP0
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0017134: The Datasource seems to be sending dates without correct time zone information

DescriptionThe Notes functionality uses a datasource to get information about the notes which a particular record has. Specifically, it gets the date the note was created through the datasource.

It seems that the date the datasource produces doesn't contain the time zone information, and this leads to wrong date calculation in the client. Specifically, the code which seems to be wrong is the DataToJsonConverter class, which does things like this:

        return xmlTimeFormat.format(value) + "+00:00";

and this:

        return xmlDateTimeFormat.format(value) + "+00:00";

Steps To ReproduceJust create a Note in any record. If your time zone is GMT+2, you will notice that the window will show bad date info:

"-120 minutes ago by Openbravo"
Proposed SolutionIf the datasource adds correct time zone information to the dates, this problem should no longer happen.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0037878)
hgbot (developer)
2011-06-01 12:02

 Repository: erp/devel/pi
Changeset: 3aee8491f0e86faf53c63c28c24e3d1059334433
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Jun 01 12:02:01 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/3aee8491f0e86faf53c63c28c24e3d1059334433 [^]

Fixes issue 17134: The Datasource seems to be sending dates without correct time zone information

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-utilities.js
---
(0037939)
mtaal (manager)
2011-06-02 19:01

 An alternative solution should be chosen, the fix causes issue 17189.
(0037946)
hgbot (developer)
2011-06-03 07:12

 Repository: erp/devel/pi
Changeset: e001e3c8176cbd08d1a0e061bc5d9d109131bd63
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Jun 03 07:11:12 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e001e3c8176cbd08d1a0e061bc5d9d109131bd63 [^]

Fixes issue 17134: The Datasource seems to be sending dates without correct time zone information, Fixes issue 17189: Time stamp attachment incorrect

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-time.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-utilities.js
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/TimeUIDefinition.java
M modules/org.openbravo.service.json/src/org/openbravo/service/json/DataToJsonConverter.java
M modules/org.openbravo.service.json/src/org/openbravo/service/json/JsonUtils.java
---
(0037982)
hudsonbot (developer)
2011-06-03 13:27

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2a05e66b60ca [^]

Maturity status: Test
(0038002)
hudsonbot (developer)
2011-06-03 13:27

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2a05e66b60ca [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2011-05-12 11:10 marvintm New Issue
2011-05-12 11:10 marvintm Assigned To => mtaal
2011-05-12 11:10 marvintm Modules => Core
2011-05-16 08:57 alostale Status new => scheduled
2011-05-16 08:57 alostale fix_in_branch => pi
2011-05-16 08:57 alostale Target Version => 3.0MP0
2011-05-16 08:57 alostale fix_in_branch pi =>
2011-05-23 20:01 dmitry_mezentsev Priority normal => urgent
2011-06-01 12:02 hgbot Checkin
2011-06-01 12:02 hgbot Note Added: 0037878
2011-06-01 12:02 hgbot Status scheduled => resolved
2011-06-01 12:02 hgbot Resolution open => fixed
2011-06-01 12:02 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/3aee8491f0e86faf53c63c28c24e3d1059334433 [^]
2011-06-02 19:01 mtaal Note Added: 0037939
2011-06-02 19:01 mtaal Status resolved => new
2011-06-02 19:01 mtaal Resolution fixed => open
2011-06-03 07:12 hgbot Checkin
2011-06-03 07:12 hgbot Note Added: 0037946
2011-06-03 07:12 hgbot Status new => resolved
2011-06-03 07:12 hgbot Resolution open => fixed
2011-06-03 07:12 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/3aee8491f0e86faf53c63c28c24e3d1059334433 [^] => http://code.openbravo.com/erp/devel/pi/rev/e001e3c8176cbd08d1a0e061bc5d9d109131bd63 [^]
2011-06-03 13:27 hudsonbot Checkin
2011-06-03 13:27 hudsonbot Note Added: 0037982
2011-06-03 13:27 hudsonbot Checkin
2011-06-03 13:27 hudsonbot Note Added: 0038002
2011-06-03 17:38 marvintm Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker