Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0017134Openbravo ERPA. Platformpublic2011-05-12 11:102011-06-03 17:38
marvintm 
mtaal 
urgentmajorhave not tried
closedfixed 
5
 
3.0MP0 
Core
No
0017134: The Datasource seems to be sending dates without correct time zone information
The Notes functionality uses a datasource to get information about the notes which a particular record has. Specifically, it gets the date the note was created through the datasource.

It seems that the date the datasource produces doesn't contain the time zone information, and this leads to wrong date calculation in the client. Specifically, the code which seems to be wrong is the DataToJsonConverter class, which does things like this:

        return xmlTimeFormat.format(value) + "+00:00";

and this:

        return xmlDateTimeFormat.format(value) + "+00:00";

Just create a Note in any record. If your time zone is GMT+2, you will notice that the window will show bad date info:

"-120 minutes ago by Openbravo"
If the datasource adds correct time zone information to the dates, this problem should no longer happen.
No tags attached.
Issue History
2011-05-12 11:10marvintmNew Issue
2011-05-12 11:10marvintmAssigned To => mtaal
2011-05-12 11:10marvintmModules => Core
2011-05-16 08:57alostaleStatusnew => scheduled
2011-05-16 08:57alostalefix_in_branch => pi
2011-05-16 08:57alostaleTarget Version => 3.0MP0
2011-05-16 08:57alostalefix_in_branchpi =>
2011-05-23 20:01dmitry_mezentsevPrioritynormal => urgent
2011-06-01 12:02hgbotCheckin
2011-06-01 12:02hgbotNote Added: 0037878
2011-06-01 12:02hgbotStatusscheduled => resolved
2011-06-01 12:02hgbotResolutionopen => fixed
2011-06-01 12:02hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/3aee8491f0e86faf53c63c28c24e3d1059334433 [^]
2011-06-02 19:01mtaalNote Added: 0037939
2011-06-02 19:01mtaalStatusresolved => new
2011-06-02 19:01mtaalResolutionfixed => open
2011-06-03 07:12hgbotCheckin
2011-06-03 07:12hgbotNote Added: 0037946
2011-06-03 07:12hgbotStatusnew => resolved
2011-06-03 07:12hgbotResolutionopen => fixed
2011-06-03 07:12hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/3aee8491f0e86faf53c63c28c24e3d1059334433 [^] => http://code.openbravo.com/erp/devel/pi/rev/e001e3c8176cbd08d1a0e061bc5d9d109131bd63 [^]
2011-06-03 13:27hudsonbotCheckin
2011-06-03 13:27hudsonbotNote Added: 0037982
2011-06-03 13:27hudsonbotCheckin
2011-06-03 13:27hudsonbotNote Added: 0038002
2011-06-03 17:38marvintmStatusresolved => closed

Notes
(0037878)
hgbot   
2011-06-01 12:02   
Repository: erp/devel/pi
Changeset: 3aee8491f0e86faf53c63c28c24e3d1059334433
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Jun 01 12:02:01 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/3aee8491f0e86faf53c63c28c24e3d1059334433 [^]

Fixes issue 17134: The Datasource seems to be sending dates without correct time zone information

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-utilities.js
---
(0037939)
mtaal   
2011-06-02 19:01   
An alternative solution should be chosen, the fix causes issue 17189.
(0037946)
hgbot   
2011-06-03 07:12   
Repository: erp/devel/pi
Changeset: e001e3c8176cbd08d1a0e061bc5d9d109131bd63
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Jun 03 07:11:12 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e001e3c8176cbd08d1a0e061bc5d9d109131bd63 [^]

Fixes issue 17134: The Datasource seems to be sending dates without correct time zone information, Fixes issue 17189: Time stamp attachment incorrect

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-time.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-utilities.js
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/TimeUIDefinition.java
M modules/org.openbravo.service.json/src/org/openbravo/service/json/DataToJsonConverter.java
M modules/org.openbravo.service.json/src/org/openbravo/service/json/JsonUtils.java
---
(0037982)
hudsonbot   
2011-06-03 13:27   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2a05e66b60ca [^]

Maturity status: Test
(0038002)
hudsonbot   
2011-06-03 13:27   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2a05e66b60ca [^]

Maturity status: Test