Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0016503
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajoralways2011-03-28 09:352011-05-13 10:19
ReporterrgorisView Statuspublic 
Assigned Topsarobe 
PriorityhighResolutionfixedFixed in Versionpi
StatusclosedFix in branchFixed in SCM revision66ef6ecb0b86
ProjectionnoneETAnoneTarget Version3.0RC6
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version3.0RC5SCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0016503: Unnecessary default tax code for a product in lines

DescriptionAs copied from Paolo´s comments based on his product demo:

Incorrect demo data: When you enter a sales order line in the US organization, the tax is initially defaulted to "Entregas IVA 16%", which is clearly incorrect. The right tax "NY Sales Tax" is then selected when you choose the product.
There is actually no reason to default a tax code before the product and this defaulting should be removed if possible.
If it is not possible to avoid a default, we should define a dummy tax rate with a name that is not country specific (for example: "Undertermined" - with the proper translation in every language installed in the demo) and use it as the default tax rate.
Steps To Reproducelive b uilds
quick create . sales order
click on bp dropdown and selefc moon restaurants
click on child level
click on the quicklink "Create new"
look at tax field Entregas
Proposed Solutionremove default tax code. if this is not possible, then use a neutral default such as "undetermined" in the proper language
TagsNo tags attached.
Attached Filespng file icon PJU-Default-Tax-Code.png [^] (397,982 bytes) 2011-03-28 09:35
png file icon default_tax.PNG [^] (75,368 bytes) 2011-03-28 15:48


png file icon tax-default.png [^] (165,946 bytes) 2011-03-28 16:16

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0035270)
psarobe (manager)
2011-03-28 15:48

I cannot reproduce. See my attach
(0035273)
rgoris (developer)
2011-03-28 16:15

I can. Live builds today, postgre. see image.
(0035489)
psarobe (manager)
2011-04-01 21:26

The problem is not with the default taxes but with the demo data itself. The taxes are defined in * and this is wrong.

Spanish taxes must be defined in Spain org
USA taxes in US organization

Then the solution is to change all of this.
(0035490)
hgbot (developer)
2011-04-01 21:45

Repository: erp/devel/pi
Changeset: 5defe5fe3c5f44be86878727e3cfadb20cdfcfb5
Author: Pablo Sarobe <pablo.sarobe <at> openbravo.com>
Date: Fri Apr 01 21:44:30 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5defe5fe3c5f44be86878727e3cfadb20cdfcfb5 [^]

fixes issue 16503: Taxes in demo were wrong. Change organizations

---
M referencedata/sampledata/F_B_International_Group.xml
---
(0035637)
rgoris (developer)
2011-04-06 09:01
edited on: 2011-04-06 09:02

Default tax is now CA Sales Tax which at least belongs to the organization F&B US, Inc.

Although better than before, it would be best to have a default tax rate, a neutral one, or none at all until you choose a product. Would that be possible?

(0035639)
psarobe (manager)
2011-04-06 10:05

That tax is for US since the Spanish ones were move to Spain, and it's not possible what you ask for that is "none at all until you chose a product". That would be a big change in the behaviour across the ERP. Currently when a combo field is mandatory then you cannot have a blank option. Please notice it happens the same for UOM combo box.
In any case what you ask for would be another issue

Tx
(0036891)
hgbot (developer)
2011-05-12 13:43

Repository: erp/devel/pi
Changeset: 66ef6ecb0b868d2f7fb32b848d8ebc2d2a3d45ef
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu May 12 11:25:13 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/66ef6ecb0b868d2f7fb32b848d8ebc2d2a3d45ef [^]

[cleanup] Reapplied changeset 5defe5fe3c5f
fixes issue 16503: Taxes in demo were wrong. Change organizations

---
M referencedata/sampledata/F_B_International_Group.xml
---
(0036933)
hudsonbot (developer)
2011-05-13 06:23

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d221ad9e329e [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2011-03-28 09:35 rgoris New Issue
2011-03-28 09:35 rgoris Assigned To => alostale
2011-03-28 09:35 rgoris File Added: PJU-Default-Tax-Code.png
2011-03-28 09:35 rgoris Modules => Core
2011-03-28 11:05 iciordia Assigned To alostale => psarobe
2011-03-28 15:48 psarobe Note Added: 0035270
2011-03-28 15:48 psarobe Status new => feedback
2011-03-28 15:48 psarobe File Added: default_tax.PNG
2011-03-28 16:15 rgoris Note Added: 0035273
2011-03-28 16:16 rgoris File Added: tax-default.png
2011-03-28 16:23 psarobe Assigned To psarobe => iperdomo
2011-03-28 16:23 psarobe Status feedback => scheduled
2011-03-28 16:28 rgoris Steps to Reproduce Updated View Revisions
2011-03-30 16:13 iperdomo Target Version 3.0 => 3.0RC6
2011-04-01 11:49 iperdomo Assigned To iperdomo => psarobe
2011-04-01 21:26 psarobe Note Added: 0035489
2011-04-01 21:45 hgbot Checkin
2011-04-01 21:45 hgbot Note Added: 0035490
2011-04-01 21:45 hgbot Status scheduled => resolved
2011-04-01 21:45 hgbot Resolution open => fixed
2011-04-01 21:45 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5defe5fe3c5f44be86878727e3cfadb20cdfcfb5 [^]
2011-04-06 09:01 rgoris Note Added: 0035637
2011-04-06 09:02 rgoris Note Edited: 0035637 View Revisions
2011-04-06 10:05 psarobe Note Added: 0035639
2011-04-06 10:07 rgoris Status resolved => closed
2011-04-06 10:07 rgoris Fixed in Version => pi
2011-04-07 00:00 anonymous sf_bug_id 0 => 3278056
2011-05-12 13:43 hgbot Checkin
2011-05-12 13:43 hgbot Note Added: 0036891
2011-05-12 13:43 hgbot Status closed => resolved
2011-05-12 13:43 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/5defe5fe3c5f44be86878727e3cfadb20cdfcfb5 [^] => http://code.openbravo.com/erp/devel/pi/rev/66ef6ecb0b868d2f7fb32b848d8ebc2d2a3d45ef [^]
2011-05-13 06:23 hudsonbot Checkin
2011-05-13 06:23 hudsonbot Note Added: 0036933
2011-05-13 10:19 rgoris Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker