Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0016503Openbravo ERPA. Platformpublic2011-03-28 09:352011-05-13 10:19
Reporterrgoris 
Assigned Topsarobe 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0RC5 
Target Version3.0RC6Fixed in Versionpi 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0016503: Unnecessary default tax code for a product in lines
DescriptionAs copied from Paolo´s comments based on his product demo:

Incorrect demo data: When you enter a sales order line in the US organization, the tax is initially defaulted to "Entregas IVA 16%", which is clearly incorrect. The right tax "NY Sales Tax" is then selected when you choose the product.
There is actually no reason to default a tax code before the product and this defaulting should be removed if possible.
If it is not possible to avoid a default, we should define a dummy tax rate with a name that is not country specific (for example: "Undertermined" - with the proper translation in every language installed in the demo) and use it as the default tax rate.
Steps To Reproducelive b uilds
quick create . sales order
click on bp dropdown and selefc moon restaurants
click on child level
click on the quicklink "Create new"
look at tax field Entregas
Proposed Solutionremove default tax code. if this is not possible, then use a neutral default such as "undetermined" in the proper language
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng PJU-Default-Tax-Code.png (397,982) 2011-03-28 09:35
https://issues.openbravo.com/file_download.php?file_id=3764&type=bug
png default_tax.PNG (75,368) 2011-03-28 15:48
https://issues.openbravo.com/file_download.php?file_id=3768&type=bug
png

png tax-default.png (165,946) 2011-03-28 16:16
https://issues.openbravo.com/file_download.php?file_id=3770&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2011-03-28 09:35rgorisNew Issue
2011-03-28 09:35rgorisAssigned To => alostale
2011-03-28 09:35rgorisFile Added: PJU-Default-Tax-Code.png
2011-03-28 09:35rgorisModules => Core
2011-03-28 11:05iciordiaAssigned Toalostale => psarobe
2011-03-28 15:48psarobeNote Added: 0035270
2011-03-28 15:48psarobeStatusnew => feedback
2011-03-28 15:48psarobeFile Added: default_tax.PNG
2011-03-28 16:15rgorisNote Added: 0035273
2011-03-28 16:16rgorisFile Added: tax-default.png
2011-03-28 16:23psarobeAssigned Topsarobe => iperdomo
2011-03-28 16:23psarobeStatusfeedback => scheduled
2011-03-28 16:28rgorisSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=1721#r1721
2011-03-30 16:13iperdomoTarget Version3.0 => 3.0RC6
2011-04-01 11:49iperdomoAssigned Toiperdomo => psarobe
2011-04-01 21:26psarobeNote Added: 0035489
2011-04-01 21:45hgbotCheckin
2011-04-01 21:45hgbotNote Added: 0035490
2011-04-01 21:45hgbotStatusscheduled => resolved
2011-04-01 21:45hgbotResolutionopen => fixed
2011-04-01 21:45hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5defe5fe3c5f44be86878727e3cfadb20cdfcfb5 [^]
2011-04-06 09:01rgorisNote Added: 0035637
2011-04-06 09:02rgorisNote Edited: 0035637bug_revision_view_page.php?bugnote_id=0035637#r1782
2011-04-06 10:05psarobeNote Added: 0035639
2011-04-06 10:07rgorisStatusresolved => closed
2011-04-06 10:07rgorisFixed in Version => pi
2011-04-07 00:00anonymoussf_bug_id0 => 3278056
2011-05-12 13:43hgbotCheckin
2011-05-12 13:43hgbotNote Added: 0036891
2011-05-12 13:43hgbotStatusclosed => resolved
2011-05-12 13:43hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/5defe5fe3c5f44be86878727e3cfadb20cdfcfb5 [^] => http://code.openbravo.com/erp/devel/pi/rev/66ef6ecb0b868d2f7fb32b848d8ebc2d2a3d45ef [^]
2011-05-13 06:23hudsonbotCheckin
2011-05-13 06:23hudsonbotNote Added: 0036933
2011-05-13 10:19rgorisStatusresolved => closed

Notes
(0035270)
psarobe   
2011-03-28 15:48   
I cannot reproduce. See my attach
(0035273)
rgoris   
2011-03-28 16:15   
I can. Live builds today, postgre. see image.
(0035489)
psarobe   
2011-04-01 21:26   
The problem is not with the default taxes but with the demo data itself. The taxes are defined in * and this is wrong.

Spanish taxes must be defined in Spain org
USA taxes in US organization

Then the solution is to change all of this.
(0035490)
hgbot   
2011-04-01 21:45   
Repository: erp/devel/pi
Changeset: 5defe5fe3c5f44be86878727e3cfadb20cdfcfb5
Author: Pablo Sarobe <pablo.sarobe <at> openbravo.com>
Date: Fri Apr 01 21:44:30 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5defe5fe3c5f44be86878727e3cfadb20cdfcfb5 [^]

fixes issue 16503: Taxes in demo were wrong. Change organizations

---
M referencedata/sampledata/F_B_International_Group.xml
---
(0035637)
rgoris   
2011-04-06 09:01   
(edited on: 2011-04-06 09:02)
Default tax is now CA Sales Tax which at least belongs to the organization F&B US, Inc.

Although better than before, it would be best to have a default tax rate, a neutral one, or none at all until you choose a product. Would that be possible?
(0035639)
psarobe   
2011-04-06 10:05   
That tax is for US since the Spanish ones were move to Spain, and it's not possible what you ask for that is "none at all until you chose a product". That would be a big change in the behaviour across the ERP. Currently when a combo field is mandatory then you cannot have a blank option. Please notice it happens the same for UOM combo box.
In any case what you ask for would be another issue

Tx
(0036891)
hgbot   
2011-05-12 13:43   
Repository: erp/devel/pi
Changeset: 66ef6ecb0b868d2f7fb32b848d8ebc2d2a3d45ef
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu May 12 11:25:13 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/66ef6ecb0b868d2f7fb32b848d8ebc2d2a3d45ef [^]

[cleanup] Reapplied changeset 5defe5fe3c5f
fixes issue 16503: Taxes in demo were wrong. Change organizations

---
M referencedata/sampledata/F_B_International_Group.xml
---
(0036933)
hudsonbot   
2011-05-13 06:23   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d221ad9e329e [^]

Maturity status: Test