Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0016484
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Localization Pack: Spain] CIF and NIF validatormajoralways2011-03-25 12:122011-05-31 18:56
ReporterpsanjuanView Statuspublic 
Assigned Tovmromanos 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisiona275c7c26a34
ProjectionnoneETAnoneTarget Version
OSLinux 32 bitDatabaseOracleJava version1.6
OS VersionUbuntu 8.04.1Database version11.1.0.6.0Ant version1.7.0
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Regression introduced in release
Summary

0016484: OB3 RC5 - SE_CIFNIF_Validator callout seems not to be working properly

DescriptionSE_CIFNIF_Validator callout seems not to be working properly
Steps To ReproduceSet Core and the module "CIF and NIF validator" as "In Development"
Save the changes
Go to Tables and Columns
and for the table Business Partner, assign the SE_CIFNIF_Validator call out to the column "Tax ID"
Save the changes
Compile the aplication

After that create a BP located in Spain.
Enter a wrong NIF such as 78545588
It is possible to save that record without any problem
The system does not provide any error/warning
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on defect 00164923.0RC7 closediperdomo Openbravo ERP It is not possible to use 'EXECUTE' command in callouts in Openbravo 3 
depends on defect 00172493.0MP0 closediperdomo Openbravo ERP Static JS created outside core (in modules) could not work 
related to defect 00174263.0MP0 closedmarvintm Openbravo ERP Support for all type of messages in a callout 

-  Notes
(0035264)
vmromanos (manager)
2011-03-28 11:56

 The same bug will be also reproducible in the Financial Account Validation
(0037172)
hgbot (developer)
2011-05-18 18:16

 Repository: erp/mods/org.openbravo.module.cifnifvalidator
Changeset: e00eac193106be1ed30a90f7969a39245545c568
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed May 18 18:17:54 2011 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.cifnifvalidator/rev/e00eac193106be1ed30a90f7969a39245545c568 [^]

Issue 16484: The CIF/NIF validator callout did not work on Openbravo 3

---
M src-db/database/sourcedata/AD_MODULE.xml
M src/org/openbravo/module/cifnifvalidator/erpCommon/ad_callouts/SE_CIFNIF_Validator.java
A src/org/openbravo/module/cifnifvalidator/CIFNIF_ApplicationProvider.java
A web/org.openbravo.module.cifnifvalidator/js/cifnif-utilities.js
---
(0037189)
hgbot (developer)
2011-05-19 09:44

 Repository: erp/mods/org.openbravo.module.finactvalidator.es
Changeset: a2eb0478d1ab23d0118cfb6d0ba186b3bf6be562
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu May 19 09:45:34 2011 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.finactvalidator.es/rev/a2eb0478d1ab23d0118cfb6d0ba186b3bf6be562 [^]

Issue 16484: The Bank Account validator callout didn't work on Openbravo 3

---
M src-db/database/sourcedata/AD_MODULE.xml
M src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M src/org/openbravo/module/finactvalidator/es/erpCommon/ad_callout/FNACTV_BPBankAccountValidation.java
M src/org/openbravo/module/finactvalidator/es/erpCommon/ad_callout/FNACTV_BankAccountValidation.java
A src-db/database/sourcedata/AD_MESSAGE.xml
A src/org/openbravo/module/finactvalidator/es/FNACTV_ApplicationProvider.java
A web/org.openbravo.module.finactvalidator.es/js/fnactv-utilities.js
---
(0037193)
vmromanos (manager)
2011-05-19 10:13

 This bug should be fixed in:
- CIF and NIF validator 1.0.2
- Validador de número de cuenta financiera 3.0.1

Take into account that 0017249 is currently blocking this one, so these modules could not work until this bug is fixed (> RC7)
(0037454)
iperdomo (reporter)
2011-05-25 18:33

 The way to report messages through callouts is using the 'MESSAGE' and not calling directly the JavaScript behind it.

There is no need to declare any static resource since you'll use the standard API.

http://wiki.openbravo.com/wiki/ERP/2.50/Developers_Guide/Concepts/AD/Data_Model#What_Callouts_can_do [^]

The 'MESSAGE' command is supported. So you can warn the user by just using it. INFO, WARNING, ERROR will be supported soon.

Sorry for the inconveniences.
(0037596)
hgbot (developer)
2011-05-26 13:47

 Repository: erp/mods/org.openbravo.module.cifnifvalidator
Changeset: a275c7c26a345244dd1fb54158e82e137e21e995
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu May 26 13:49:03 2011 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.cifnifvalidator/rev/a275c7c26a345244dd1fb54158e82e137e21e995 [^]

Fixed bug 16484: The CIF/NIF validator callout did not work on Openbravo 3
We use the "MESSAGE" API that currently works in OB3.
Take into account that in OB3 an INFO message will be shown, but in 2.50 we show a WARNING.
The reason is Warning messages currently does not work in OB3 (unless you directly depends on OB3
stuff, that is something we don't want as this module should also work in 2.50)

---
M src-db/database/sourcedata/AD_MODULE.xml
M src/org/openbravo/module/cifnifvalidator/erpCommon/ad_callouts/SE_CIFNIF_Validator.java
---
(0037597)
vmromanos (manager)
2011-05-26 13:57

 This bug should be fixed in:
- CIF and NIF validator 1.0.3
- Validador de número de cuenta financiera 3.0.1
(0037809)
psanjuan (manager)
2011-05-31 10:31
edited on: 2011-05-31 10:33

 seems not to be working properly.
A preference is created once more which makes I still see BP window "old" way.

Please take a look into the issue 17426.
Once that one is fixed we should fix this one.

- Issue History
Date Modified Username Field Change
2011-03-25 12:12 psanjuan New Issue
2011-03-25 12:12 psanjuan Assigned To => vmromanos
2011-03-25 12:16 psanjuan File Added: CIF&NIF_validator.png
2011-03-25 12:16 psanjuan File Added: Development.png
2011-03-25 12:57 psanjuan Summary OB3 GA - not possible to link the SE_CIFNIF_Validator callout to the Tax_ID field, Business Partner table => OB3 GA - SE_CIFNIF_Validator callout seems not to be working properly
2011-03-25 12:57 psanjuan Description Updated View Revisions
2011-03-25 12:57 psanjuan Steps to Reproduce Updated View Revisions
2011-03-25 12:58 psanjuan File Deleted: Development.png
2011-03-25 12:58 psanjuan File Deleted: CIF&NIF_validator.png
2011-03-25 12:58 psanjuan Steps to Reproduce Updated View Revisions
2011-03-28 11:56 vmromanos Note Added: 0035264
2011-03-28 11:56 vmromanos Relationship added depends on 0016492
2011-03-28 12:25 psanjuan Summary OB3 GA - SE_CIFNIF_Validator callout seems not to be working properly => OB3 RC5 - SE_CIFNIF_Validator callout seems not to be working properly
2011-05-18 16:20 vmromanos Status new => scheduled
2011-05-18 16:20 vmromanos fix_in_branch => pi
2011-05-18 17:01 vmromanos Relationship added depends on 0017249
2011-05-18 18:16 hgbot Checkin
2011-05-18 18:16 hgbot Note Added: 0037172
2011-05-19 09:44 hgbot Checkin
2011-05-19 09:44 hgbot Note Added: 0037189
2011-05-19 10:13 vmromanos Note Added: 0037193
2011-05-25 18:33 iperdomo Note Added: 0037454
2011-05-26 13:47 hgbot Checkin
2011-05-26 13:47 hgbot Note Added: 0037596
2011-05-26 13:47 hgbot Status scheduled => resolved
2011-05-26 13:47 hgbot Resolution open => fixed
2011-05-26 13:47 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/mods/org.openbravo.module.cifnifvalidator/rev/a275c7c26a345244dd1fb54158e82e137e21e995 [^]
2011-05-26 13:57 vmromanos Note Added: 0037597
2011-05-31 09:46 iperdomo Relationship added related to 0017426
2011-05-31 10:31 psanjuan Note Added: 0037809
2011-05-31 10:31 psanjuan Status resolved => new
2011-05-31 10:31 psanjuan fix_in_branch pi =>
2011-05-31 10:33 psanjuan Note Edited: 0037809 View Revisions
2011-05-31 18:55 psanjuan Status new => scheduled
2011-05-31 18:55 psanjuan Status scheduled => resolved
2011-05-31 18:56 psanjuan Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker