Openbravo Issue Tracking System - Localization Pack: Spain
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0016484Localization Pack: SpainCIF and NIF validatorpublic2011-03-25 12:122011-05-31 18:56
Reporterpsanjuan 
Assigned Tovmromanos 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionUbuntu 8.04.1
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket
OBNetwork customerNo
Regression introduced in release
Summary0016484: OB3 RC5 - SE_CIFNIF_Validator callout seems not to be working properly
DescriptionSE_CIFNIF_Validator callout seems not to be working properly
Steps To ReproduceSet Core and the module "CIF and NIF validator" as "In Development"
Save the changes
Go to Tables and Columns
and for the table Business Partner, assign the SE_CIFNIF_Validator call out to the column "Tax ID"
Save the changes
Compile the aplication

After that create a BP located in Spain.
Enter a wrong NIF such as 78545588
It is possible to save that record without any problem
The system does not provide any error/warning
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on defect 00164923.0RC7 closed iperdomo Openbravo ERP It is not possible to use 'EXECUTE' command in callouts in Openbravo 3 
depends on defect 00172493.0MP0 closed iperdomo Openbravo ERP Static JS created outside core (in modules) could not work 
related to defect 00174263.0MP0 closed marvintm Openbravo ERP Support for all type of messages in a callout 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-03-25 12:12psanjuanNew Issue
2011-03-25 12:12psanjuanAssigned To => vmromanos
2011-03-25 12:12psanjuanOBNetwork customer => No
2011-03-25 12:16psanjuanFile Added: CIF&NIF_validator.png
2011-03-25 12:16psanjuanFile Added: Development.png
2011-03-25 12:57psanjuanSummaryOB3 GA - not possible to link the SE_CIFNIF_Validator callout to the Tax_ID field, Business Partner table => OB3 GA - SE_CIFNIF_Validator callout seems not to be working properly
2011-03-25 12:57psanjuanDescription Updatedbug_revision_view_page.php?rev_id=1710#r1710
2011-03-25 12:57psanjuanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=1712#r1712
2011-03-25 12:58psanjuanFile Deleted: Development.png
2011-03-25 12:58psanjuanFile Deleted: CIF&NIF_validator.png
2011-03-25 12:58psanjuanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=1713#r1713
2011-03-28 11:56vmromanosNote Added: 0035264
2011-03-28 11:56vmromanosRelationship addeddepends on 0016492
2011-03-28 12:25psanjuanSummaryOB3 GA - SE_CIFNIF_Validator callout seems not to be working properly => OB3 RC5 - SE_CIFNIF_Validator callout seems not to be working properly
2011-05-18 16:20vmromanosStatusnew => scheduled
2011-05-18 16:20vmromanosfix_in_branch => pi
2011-05-18 17:01vmromanosRelationship addeddepends on 0017249
2011-05-18 18:16hgbotCheckin
2011-05-18 18:16hgbotNote Added: 0037172
2011-05-19 09:44hgbotCheckin
2011-05-19 09:44hgbotNote Added: 0037189
2011-05-19 10:13vmromanosNote Added: 0037193
2011-05-25 18:33iperdomoNote Added: 0037454
2011-05-26 13:47hgbotCheckin
2011-05-26 13:47hgbotNote Added: 0037596
2011-05-26 13:47hgbotStatusscheduled => resolved
2011-05-26 13:47hgbotResolutionopen => fixed
2011-05-26 13:47hgbotFixed in SCM revision => http://code.openbravo.com/erp/mods/org.openbravo.module.cifnifvalidator/rev/a275c7c26a345244dd1fb54158e82e137e21e995 [^]
2011-05-26 13:57vmromanosNote Added: 0037597
2011-05-31 09:46iperdomoRelationship addedrelated to 0017426
2011-05-31 10:31psanjuanNote Added: 0037809
2011-05-31 10:31psanjuanStatusresolved => new
2011-05-31 10:31psanjuanfix_in_branchpi =>
2011-05-31 10:33psanjuanNote Edited: 0037809bug_revision_view_page.php?bugnote_id=0037809#r2150
2011-05-31 18:55psanjuanStatusnew => scheduled
2011-05-31 18:55psanjuanStatusscheduled => resolved
2011-05-31 18:56psanjuanStatusresolved => closed

Notes
(0035264)
vmromanos   
2011-03-28 11:56   
The same bug will be also reproducible in the Financial Account Validation
(0037172)
hgbot   
2011-05-18 18:16   
Repository: erp/mods/org.openbravo.module.cifnifvalidator
Changeset: e00eac193106be1ed30a90f7969a39245545c568
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed May 18 18:17:54 2011 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.cifnifvalidator/rev/e00eac193106be1ed30a90f7969a39245545c568 [^]

Issue 16484: The CIF/NIF validator callout did not work on Openbravo 3

---
M src-db/database/sourcedata/AD_MODULE.xml
M src/org/openbravo/module/cifnifvalidator/erpCommon/ad_callouts/SE_CIFNIF_Validator.java
A src/org/openbravo/module/cifnifvalidator/CIFNIF_ApplicationProvider.java
A web/org.openbravo.module.cifnifvalidator/js/cifnif-utilities.js
---
(0037189)
hgbot   
2011-05-19 09:44   
Repository: erp/mods/org.openbravo.module.finactvalidator.es
Changeset: a2eb0478d1ab23d0118cfb6d0ba186b3bf6be562
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu May 19 09:45:34 2011 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.finactvalidator.es/rev/a2eb0478d1ab23d0118cfb6d0ba186b3bf6be562 [^]

Issue 16484: The Bank Account validator callout didn't work on Openbravo 3

---
M src-db/database/sourcedata/AD_MODULE.xml
M src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M src/org/openbravo/module/finactvalidator/es/erpCommon/ad_callout/FNACTV_BPBankAccountValidation.java
M src/org/openbravo/module/finactvalidator/es/erpCommon/ad_callout/FNACTV_BankAccountValidation.java
A src-db/database/sourcedata/AD_MESSAGE.xml
A src/org/openbravo/module/finactvalidator/es/FNACTV_ApplicationProvider.java
A web/org.openbravo.module.finactvalidator.es/js/fnactv-utilities.js
---
(0037193)
vmromanos   
2011-05-19 10:13   
This bug should be fixed in:
- CIF and NIF validator 1.0.2
- Validador de número de cuenta financiera 3.0.1

Take into account that 0017249 is currently blocking this one, so these modules could not work until this bug is fixed (> RC7)
(0037454)
iperdomo   
2011-05-25 18:33   
The way to report messages through callouts is using the 'MESSAGE' and not calling directly the JavaScript behind it.

There is no need to declare any static resource since you'll use the standard API.

http://wiki.openbravo.com/wiki/ERP/2.50/Developers_Guide/Concepts/AD/Data_Model#What_Callouts_can_do [^]

The 'MESSAGE' command is supported. So you can warn the user by just using it. INFO, WARNING, ERROR will be supported soon.

Sorry for the inconveniences.
(0037596)
hgbot   
2011-05-26 13:47   
Repository: erp/mods/org.openbravo.module.cifnifvalidator
Changeset: a275c7c26a345244dd1fb54158e82e137e21e995
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu May 26 13:49:03 2011 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.cifnifvalidator/rev/a275c7c26a345244dd1fb54158e82e137e21e995 [^]

Fixed bug 16484: The CIF/NIF validator callout did not work on Openbravo 3
We use the "MESSAGE" API that currently works in OB3.
Take into account that in OB3 an INFO message will be shown, but in 2.50 we show a WARNING.
The reason is Warning messages currently does not work in OB3 (unless you directly depends on OB3
stuff, that is something we don't want as this module should also work in 2.50)

---
M src-db/database/sourcedata/AD_MODULE.xml
M src/org/openbravo/module/cifnifvalidator/erpCommon/ad_callouts/SE_CIFNIF_Validator.java
---
(0037597)
vmromanos   
2011-05-26 13:57   
This bug should be fixed in:
- CIF and NIF validator 1.0.3
- Validador de número de cuenta financiera 3.0.1
(0037809)
psanjuan   
2011-05-31 10:31   
(edited on: 2011-05-31 10:33)
seems not to be working properly.
A preference is created once more which makes I still see BP window "old" way.

Please take a look into the issue 17426.
Once that one is fixed we should fix this one.