Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0015463 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | have not tried | 2010-12-16 17:11 | 2010-12-30 13:14 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | pi | Fixed in SCM revision | ffab787bf3a9 | |||
| Projection | none | ETA | none | Target Version | 2.50MP25 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0015463: excludeFilter for modulescripts & modules/*/src-wad in compileSqlc task is not working | |||||||
| Description | which leads to the classes of src-wad in a module not being excluded and being present in their current version in the normal classpath. When now a module is updated which has an 'internal' abi-change (like java and its xsql file in selector 1.0.12 -> 1.0.13) then Wad-call (using big project.class.path) will encounter the old class file from the wrong location, mixing it with the new class file for the xsql file and the whole update/compile willl fail. | |||||||
| Steps To Reproduce | Using i.e. mp21 Try to update from selector version 1.0.11 or 1.0.12 to 1.0.13 (not yet released) | |||||||
| Proposed Solution | a.) fix exclude in compileSqlc b.) define minimal classpath for Wad so it does not pickup random other classfiles from various locations. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0033246) hgbot (developer) 2010-12-16 17:46 |
Repository: erp/devel/pi Changeset: ffab787bf3a9b5a3a48f14e81c3a3396b45ac782 Author: Stefan Hühner <stefan.huehner <at> openbravo.com> Date: Thu Dec 16 17:42:21 2010 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/ffab787bf3a9b5a3a48f14e81c3a3396b45ac782 [^] Fixed 15463: Fix updating modules having src-wad parts with internal changes The excludeFilter for the src-wad parts of a module did not work correctly so when updating a module having a src-wad which did changes its 'internal' api between i.e. a xsql-file and a java class calling this the update process failed it was mixing the old java class with the new version of the xsql file. Fixed by: - fixing exclude filter in compileSqlc task to really not module src-wad part of a module in normal compile - define a new minimal classpath for Wad invcocation during compilation to not pickup those unwanted .class file even if they do exist. - Along the way also fix excludeFilter in same location for src-util (moduleScripts) as it was also broken --- M build.xml M src/build.xml --- |
|
(0033254) marvintm (developer) 2010-12-16 19:52 |
Works fine. |
|
(0033453) hudsonbot (developer) 2010-12-30 13:14 |
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated: Changeset: http://code.openbravo.com/erp/devel/main/rev/ffab787bf3a9 [^] Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/7d7e5eebcc62 [^] Tests: http://builds.openbravo.com/view/int/ [^] OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.19448.obx [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2010-12-16 17:11 | shuehner | New Issue | |
| 2010-12-16 17:11 | shuehner | Assigned To | => shuehner |
| 2010-12-16 17:11 | shuehner | Modules | => Core |
| 2010-12-16 17:11 | shuehner | Status | new => scheduled |
| 2010-12-16 17:11 | shuehner | fix_in_branch | => pi |
| 2010-12-16 17:46 | hgbot | Checkin | |
| 2010-12-16 17:46 | hgbot | Note Added: 0033246 | |
| 2010-12-16 17:46 | hgbot | Status | scheduled => resolved |
| 2010-12-16 17:46 | hgbot | Resolution | open => fixed |
| 2010-12-16 17:46 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/ffab787bf3a9b5a3a48f14e81c3a3396b45ac782 [^] |
| 2010-12-16 19:52 | marvintm | Note Added: 0033254 | |
| 2010-12-16 19:52 | marvintm | Status | resolved => closed |
| 2010-12-16 22:16 | anonymous | sf_bug_id | 0 => 3138808 |
| 2010-12-30 13:14 | hudsonbot | Checkin | |
| 2010-12-30 13:14 | hudsonbot | Note Added: 0033453 | |
| 2011-01-13 16:02 | shuehner | Relationship added | has duplicate 0013626 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |