Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0015463Openbravo ERPA. Platformpublic2010-12-16 17:112010-12-30 13:14
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version2.50MP25Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0015463: excludeFilter for modulescripts & modules/*/src-wad in compileSqlc task is not working
Descriptionwhich leads to the classes of src-wad in a module not being excluded and being present in their current version in the normal classpath.

When now a module is updated which has an 'internal' abi-change (like java and its xsql file in selector 1.0.12 -> 1.0.13) then Wad-call (using big project.class.path) will encounter the old class file from the wrong location, mixing it with the new class file for the xsql file and the whole update/compile willl fail.
Steps To ReproduceUsing i.e. mp21
Try to update from selector version 1.0.11 or 1.0.12 to 1.0.13 (not yet released)
Proposed Solutiona.) fix exclude in compileSqlc
b.) define minimal classpath for Wad so it does not pickup random other classfiles from various locations.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00154642.50MP25 closed shuehner excludeFilter for modulescripts & modules/*/src-wad in compileSqlc task is not working 
has duplicate defect 0013626pi closed marvintm ant compile saves compiled classes for module script java code in build folder at root level 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-12-16 17:11shuehnerNew Issue
2010-12-16 17:11shuehnerAssigned To => shuehner
2010-12-16 17:11shuehnerModules => Core
2010-12-16 17:11shuehnerStatusnew => scheduled
2010-12-16 17:11shuehnerfix_in_branch => pi
2010-12-16 17:46hgbotCheckin
2010-12-16 17:46hgbotNote Added: 0033246
2010-12-16 17:46hgbotStatusscheduled => resolved
2010-12-16 17:46hgbotResolutionopen => fixed
2010-12-16 17:46hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ffab787bf3a9b5a3a48f14e81c3a3396b45ac782 [^]
2010-12-16 19:52marvintmNote Added: 0033254
2010-12-16 19:52marvintmStatusresolved => closed
2010-12-16 22:16anonymoussf_bug_id0 => 3138808
2010-12-30 13:14hudsonbotCheckin
2010-12-30 13:14hudsonbotNote Added: 0033453
2011-01-13 16:02shuehnerRelationship addedhas duplicate 0013626

Notes
(0033246)
hgbot   
2010-12-16 17:46   
Repository: erp/devel/pi
Changeset: ffab787bf3a9b5a3a48f14e81c3a3396b45ac782
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Thu Dec 16 17:42:21 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ffab787bf3a9b5a3a48f14e81c3a3396b45ac782 [^]

Fixed 15463: Fix updating modules having src-wad parts with internal changes
The excludeFilter for the src-wad parts of a module did not work correctly so
when updating a module having a src-wad which did changes its 'internal' api
between i.e. a xsql-file and a java class calling this the update process
failed it was mixing the old java class with the new version of the xsql file.
Fixed by:
- fixing exclude filter in compileSqlc task to really not module src-wad part
  of a module in normal compile
- define a new minimal classpath for Wad invcocation during compilation to not
  pickup those unwanted .class file even if they do exist.
- Along the way also fix excludeFilter in same location for src-util
  (moduleScripts) as it was also broken

---
M build.xml
M src/build.xml
---
(0033254)
marvintm   
2010-12-16 19:52   
Works fine.
(0033453)
hudsonbot   
2010-12-30 13:14   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/ffab787bf3a9 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/7d7e5eebcc62 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.19448.obx [^]