Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0015374 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | major | have not tried | 2010-12-07 18:43 | 2010-12-16 22:16 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | ee0cf8460654 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0015374: api-check does not detect change in column from required=false to required=true | |||||||
| Description | The code testing that change has a slight bug and thus will not detect this change. | |||||||
| Steps To Reproduce | Take an existing table (i.e. AD_TABLE), edit the coresponding xml file in src-db/database/model/tables/AD_TABLE.xml change the required flag to true for some column which is not required (i.e. DESCCRIPTION) run the api-check (model-part). IT should raise an error for that change as the description column does not have a default or onCreateDefault clause set. Notice that no error is raised. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0033056) hgbot (developer) 2010-12-07 19:26 |
Repository: erp/devel/dbsm-main Changeset: b0f9d19da0b0643b58e505a32d7fe47be789a1f9 Author: Stefan Hühner <stefan.huehner <at> openbravo.com> Date: Tue Dec 07 19:26:00 2010 +0100 URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/b0f9d19da0b0643b58e505a32d7fe47be789a1f9 [^] Fixed 15374: Fix ColumnRequiredChange test of api-check This check was wrong as it assumed getChangedColumn referred to the new column when it in fact refers to the old column. And thus was testing old column agains itself instead old column against new column --- M src/org/openbravo/ddlutils/util/ValidateAPIModel.java --- |
|
(0033057) hgbot (developer) 2010-12-07 19:31 |
Repository: erp/devel/pi Changeset: ee0cf8460654801423f0eb6cf9ddd617652236c1 Author: Stefan Hühner <stefan.huehner <at> openbravo.com> Date: Tue Dec 07 19:30:39 2010 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/ee0cf8460654801423f0eb6cf9ddd617652236c1 [^] Fixed 15374: update dbsourcemanager.jar in pi to include fix done in api-check --- M src-db/database/lib/dbsourcemanager.jar --- |
|
(0033063) hudsonbot (developer) 2010-12-08 07:40 |
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated: Changeset: http://code.openbravo.com/erp/devel/main/rev/ee0cf8460654 [^] Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/5f011dfcb6cd [^] Tests: http://builds.openbravo.com/view/int/ [^] OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.19069.obx [^] |
|
(0033130) marvintm (developer) 2010-12-13 15:44 |
Tested that indeed the api check fails after a column is changed from required=false to required=true |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2010-12-07 18:43 | shuehner | New Issue | |
| 2010-12-07 18:43 | shuehner | Assigned To | => alostale |
| 2010-12-07 18:43 | shuehner | Modules | => Core |
| 2010-12-07 18:43 | shuehner | Assigned To | alostale => shuehner |
| 2010-12-07 19:26 | hgbot | Checkin | |
| 2010-12-07 19:26 | hgbot | Note Added: 0033056 | |
| 2010-12-07 19:26 | hgbot | Status | new => resolved |
| 2010-12-07 19:26 | hgbot | Resolution | open => fixed |
| 2010-12-07 19:26 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/dbsm-main/rev/b0f9d19da0b0643b58e505a32d7fe47be789a1f9 [^] |
| 2010-12-07 19:31 | hgbot | Checkin | |
| 2010-12-07 19:31 | hgbot | Note Added: 0033057 | |
| 2010-12-07 19:31 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/devel/dbsm-main/rev/b0f9d19da0b0643b58e505a32d7fe47be789a1f9 [^] => http://code.openbravo.com/erp/devel/pi/rev/ee0cf8460654801423f0eb6cf9ddd617652236c1 [^] |
| 2010-12-08 07:40 | hudsonbot | Checkin | |
| 2010-12-08 07:40 | hudsonbot | Note Added: 0033063 | |
| 2010-12-13 15:44 | marvintm | Note Added: 0033130 | |
| 2010-12-13 15:44 | marvintm | Status | resolved => closed |
| 2010-12-16 22:16 | anonymous | sf_bug_id | 0 => 3138806 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |