Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0015374Openbravo ERPA. Platformpublic2010-12-07 18:432010-12-16 22:16
Reportershuehner 
Assigned Toshuehner 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0015374: api-check does not detect change in column from required=false to required=true
DescriptionThe code testing that change has a slight bug and thus will not detect this change.
Steps To ReproduceTake an existing table (i.e. AD_TABLE), edit the coresponding xml file in src-db/database/model/tables/AD_TABLE.xml change the required flag to true for some column which is not required (i.e. DESCCRIPTION) run the api-check (model-part). IT should raise an error for that change as the description column does not have a default or onCreateDefault clause set.
Notice that no error is raised.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-12-07 18:43shuehnerNew Issue
2010-12-07 18:43shuehnerAssigned To => alostale
2010-12-07 18:43shuehnerModules => Core
2010-12-07 18:43shuehnerAssigned Toalostale => shuehner
2010-12-07 19:26hgbotCheckin
2010-12-07 19:26hgbotNote Added: 0033056
2010-12-07 19:26hgbotStatusnew => resolved
2010-12-07 19:26hgbotResolutionopen => fixed
2010-12-07 19:26hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/dbsm-main/rev/b0f9d19da0b0643b58e505a32d7fe47be789a1f9 [^]
2010-12-07 19:31hgbotCheckin
2010-12-07 19:31hgbotNote Added: 0033057
2010-12-07 19:31hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/dbsm-main/rev/b0f9d19da0b0643b58e505a32d7fe47be789a1f9 [^] => http://code.openbravo.com/erp/devel/pi/rev/ee0cf8460654801423f0eb6cf9ddd617652236c1 [^]
2010-12-08 07:40hudsonbotCheckin
2010-12-08 07:40hudsonbotNote Added: 0033063
2010-12-13 15:44marvintmNote Added: 0033130
2010-12-13 15:44marvintmStatusresolved => closed
2010-12-16 22:16anonymoussf_bug_id0 => 3138806

Notes
(0033056)
hgbot   
2010-12-07 19:26   
Repository: erp/devel/dbsm-main
Changeset: b0f9d19da0b0643b58e505a32d7fe47be789a1f9
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue Dec 07 19:26:00 2010 +0100
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/b0f9d19da0b0643b58e505a32d7fe47be789a1f9 [^]

Fixed 15374: Fix ColumnRequiredChange test of api-check
This check was wrong as it assumed getChangedColumn referred to the new column
when it in fact refers to the old column. And thus was testing old column agains
itself instead old column against new column

---
M src/org/openbravo/ddlutils/util/ValidateAPIModel.java
---
(0033057)
hgbot   
2010-12-07 19:31   
Repository: erp/devel/pi
Changeset: ee0cf8460654801423f0eb6cf9ddd617652236c1
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue Dec 07 19:30:39 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ee0cf8460654801423f0eb6cf9ddd617652236c1 [^]

Fixed 15374: update dbsourcemanager.jar in pi to include fix done in api-check

---
M src-db/database/lib/dbsourcemanager.jar
---
(0033063)
hudsonbot   
2010-12-08 07:40   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/ee0cf8460654 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/5f011dfcb6cd [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.19069.obx [^]
(0033130)
marvintm   
2010-12-13 15:44   
Tested that indeed the api check fails after a column is changed from required=false to required=true