Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0015247 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] 00. Application dictionary | minor | have not tried | 2010-11-19 13:08 | 2012-05-28 09:02 | |||
| Reporter | gorkaion | View Status | public | |||||
| Assigned To | guilleaer | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0MP12 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | fbb7883e896b | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Linux 32 bit | Database | Oracle | Java version | 1.5.0_15 | |||
| OS Version | Gentoo | Database version | 11g | Ant version | 1.7.0 | |||
| Product Version | 3.0RC2 | SCM revision | ||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0015247: Some tab title is not translated when redirected from cloned ops popup | |||||||
| Description | On 3.0 layout, on some popups you are redirected to other pages where the tab title is hardcoded and not translated. Case 1) When the system detects that your Openbravo Professional Subscription instance has been cloned a popup is shown to the System Administrator role when it is logged. This popup asks to reactivate the instance to reset the purpose of the instance and redirect the user to the Instance Management window. Case 2) Trying to install a module with heartbeat deactivated. A popup appears that redirects you to the heartbeat configuration page. | |||||||
| Steps To Reproduce | Case 1) * Install a different language than English and set it as default. * Activate the instance. * Change in database the AD_Heartbeat_log.db_identifier column of the latest created record. * Log in a System Administrator, a cloned OPS instance should be detected. * Click on continue and check that the tab title of the window is not translated. Case 2) * Try to install a module with heartbeat deactivated. | |||||||
| Proposed Solution | 1) the two labels/texts have to be added as a message to the system, as they are related to core functionality I would put the messages in the client application module. 2) then in the javascript you have to do something like this: instead of: tabTitle: 'Heartbeat Configuration' do this: tabTitle: getFrame('LayoutMDI').OB.I18N.getLabel('OBUIAPP_HeartBeat_Configuration') | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0032736) mtaal (manager) 2010-11-19 13:15 |
These are the 2 places where the change needs to be made: https://code.openbravo.com/erp/devel/pi/file/901f680aa41b/src/org/openbravo/erpCommon/ad_process/HeartbeatRedirect.html#l36 [^] https://code.openbravo.com/erp/devel/pi/file/901f680aa41b/src/org/openbravo/erpCommon/ad_forms/InstancePurpose.html#l65 [^] |
|
(0048319) hgbot (developer) 2012-05-03 12:24 |
Repository: erp/devel/pi Changeset: c308742cad47903e474684c040cd7ec05bddd397 Author: Guillermo Álvarez de Eulate <guillermo.alvarez <at> openbravo.com> Date: Thu May 03 12:18:18 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/c308742cad47903e474684c040cd7ec05bddd397 [^] Fixed issue 15247: Tab title now is shown using the user language. Instead of create new messages, the tab title is generated using the window/form identifier. --- M src-db/database/sourcedata/AD_COLUMN.xml M src/org/openbravo/erpCommon/ad_forms/InstancePurpose.html M src/org/openbravo/erpCommon/ad_forms/InstancePurpose.java M src/org/openbravo/erpCommon/ad_forms/InstancePurpose.xml M src/org/openbravo/erpCommon/ad_process/HeartbeatRedirect.html M src/org/openbravo/erpCommon/ad_process/HeartbeatRedirect.xml M src/org/openbravo/erpCommon/ad_process/TestHeartbeat.java --- |
|
(0048355) guilleaer (developer) 2012-05-03 17:24 |
Test plan: case 1: Follow the steps defined in steps to reproduce for the case 1. The title of the new tab should appears with the selected language. case 2: Unable to reproduce. It seems that the behavior of the heartbeat pop up in the module management window has changed since the issue was reported because now it doesn't open a new tab. This fix is not risky. |
|
(0048356) guilleaer (developer) 2012-05-03 17:32 |
Although case 2 never happens, a fix has been pushed. If in any case this part of code is executed, the tab title will be drawn using the selected language. src/org/openbravo/erpCommon/ad_process/HeartbeatRedirect.html src/org/openbravo/erpCommon/ad_process/HeartbeatRedirect.xml src/org/openbravo/erpCommon/ad_process/TestHeartbeat.java |
|
(0048674) alostale (manager) 2012-05-16 08:47 edited on: 2012-05-16 09:01 |
Code reviewed on pi@d4ef642f1e2a. Because of the way title variable is set, it will fail in case the translation contains invalid characters (such as "). |
|
(0048746) hgbot (developer) 2012-05-17 18:19 |
Repository: erp/devel/pi Changeset: c22edc2575342d7b4436eab054a843e4a661563f Author: Guillermo Álvarez de Eulate <guillermo.alvarez <at> openbravo.com> Date: Thu May 17 18:18:54 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/c22edc2575342d7b4436eab054a843e4a661563f [^] Fixed issue 15247: escaping problematics characters to include title in js code --- M src/org/openbravo/erpCommon/ad_forms/InstancePurpose.java M src/org/openbravo/erpCommon/ad_process/TestHeartbeat.java --- |
|
(0048747) hgbot (developer) 2012-05-17 18:24 |
Repository: erp/devel/pi Changeset: fbb7883e896b9262080d797e923de1b1edde21ec Author: Guillermo Álvarez de Eulate <guillermo.alvarez <at> openbravo.com> Date: Thu May 17 18:24:05 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/fbb7883e896b9262080d797e923de1b1edde21ec [^] Fixed issue 15247: removing line break --- M src/org/openbravo/erpCommon/ad_process/TestHeartbeat.java --- |
|
(0048749) hgbot (developer) 2012-05-17 19:43 |
Repository: erp/devel/pi Changeset: e2957cd09cc5caaf04a252869df250fd76a88933 Author: Guillermo Álvarez de Eulate <guillermo.alvarez <at> openbravo.com> Date: Thu May 17 19:42:09 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/e2957cd09cc5caaf04a252869df250fd76a88933 [^] Related to issue 15247: 'import static' statement has been removed --- M src/org/openbravo/erpCommon/ad_forms/InstancePurpose.java M src/org/openbravo/erpCommon/ad_process/TestHeartbeat.java --- |
|
(0048775) hgbot (developer) 2012-05-18 15:55 |
Repository: erp/devel/pi Changeset: e398c925655e40eb35f8c0fa0d06bed23d1cb50d Author: Guillermo Álvarez de Eulate <guillermo.alvarez <at> openbravo.com> Date: Fri May 18 15:54:13 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/e398c925655e40eb35f8c0fa0d06bed23d1cb50d [^] Related to issue 15247: 'import' statement added and function call corrected --- M src/org/openbravo/erpCommon/ad_forms/InstancePurpose.java M src/org/openbravo/erpCommon/ad_process/TestHeartbeat.java --- |
|
(0049000) hudsonbot (developer) 2012-05-25 12:09 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^] Maturity status: Test |
|
(0049160) hudsonbot (developer) 2012-05-25 12:12 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^] Maturity status: Test |
|
(0049161) hudsonbot (developer) 2012-05-25 12:12 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^] Maturity status: Test |
|
(0049162) hudsonbot (developer) 2012-05-25 12:12 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^] Maturity status: Test |
|
(0049168) hudsonbot (developer) 2012-05-25 12:13 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^] Maturity status: Test |
|
(0049330) alostale (manager) 2012-05-28 09:02 |
code reviewed and verified on pi@87f24231e3f1 |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2010-11-19 13:08 | gorkaion | New Issue | |
| 2010-11-19 13:08 | gorkaion | Assigned To | => alostale |
| 2010-11-19 13:15 | mtaal | Note Added: 0032736 | |
| 2010-11-22 08:35 | alostale | Status | new => scheduled |
| 2012-04-26 15:26 | alostale | Relationship added | related to 0019362 |
| 2012-04-26 15:26 | alostale | Assigned To | alostale => guilleaer |
| 2012-05-03 12:24 | hgbot | Checkin | |
| 2012-05-03 12:24 | hgbot | Note Added: 0048319 | |
| 2012-05-03 12:24 | hgbot | Status | scheduled => resolved |
| 2012-05-03 12:24 | hgbot | Resolution | open => fixed |
| 2012-05-03 12:24 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/c308742cad47903e474684c040cd7ec05bddd397 [^] |
| 2012-05-03 17:24 | guilleaer | Note Added: 0048355 | |
| 2012-05-03 17:32 | guilleaer | Note Added: 0048356 | |
| 2012-05-16 08:47 | alostale | Note Added: 0048674 | |
| 2012-05-16 08:47 | alostale | Status | resolved => closed |
| 2012-05-16 08:47 | alostale | Fixed in Version | => 3.0MP12 |
| 2012-05-16 09:00 | alostale | Status | closed => new |
| 2012-05-16 09:00 | alostale | Resolution | fixed => open |
| 2012-05-16 09:00 | alostale | Fixed in Version | 3.0MP12 => |
| 2012-05-16 09:01 | alostale | Note Edited: 0048674 | View Revisions |
| 2012-05-17 18:19 | hgbot | Checkin | |
| 2012-05-17 18:19 | hgbot | Note Added: 0048746 | |
| 2012-05-17 18:19 | hgbot | Status | new => resolved |
| 2012-05-17 18:19 | hgbot | Resolution | open => fixed |
| 2012-05-17 18:19 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/devel/pi/rev/c308742cad47903e474684c040cd7ec05bddd397 [^] => http://code.openbravo.com/erp/devel/pi/rev/c22edc2575342d7b4436eab054a843e4a661563f [^] |
| 2012-05-17 18:24 | hgbot | Checkin | |
| 2012-05-17 18:24 | hgbot | Note Added: 0048747 | |
| 2012-05-17 18:24 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/devel/pi/rev/c22edc2575342d7b4436eab054a843e4a661563f [^] => http://code.openbravo.com/erp/devel/pi/rev/fbb7883e896b9262080d797e923de1b1edde21ec [^] |
| 2012-05-17 19:43 | hgbot | Checkin | |
| 2012-05-17 19:43 | hgbot | Note Added: 0048749 | |
| 2012-05-18 15:55 | hgbot | Checkin | |
| 2012-05-18 15:55 | hgbot | Note Added: 0048775 | |
| 2012-05-25 12:09 | hudsonbot | Checkin | |
| 2012-05-25 12:09 | hudsonbot | Note Added: 0049000 | |
| 2012-05-25 12:12 | hudsonbot | Checkin | |
| 2012-05-25 12:12 | hudsonbot | Note Added: 0049160 | |
| 2012-05-25 12:12 | hudsonbot | Checkin | |
| 2012-05-25 12:12 | hudsonbot | Note Added: 0049161 | |
| 2012-05-25 12:12 | hudsonbot | Checkin | |
| 2012-05-25 12:12 | hudsonbot | Note Added: 0049162 | |
| 2012-05-25 12:13 | hudsonbot | Checkin | |
| 2012-05-25 12:13 | hudsonbot | Note Added: 0049168 | |
| 2012-05-28 09:02 | alostale | Note Added: 0049330 | |
| 2012-05-28 09:02 | alostale | Status | resolved => closed |
| 2012-05-28 09:02 | alostale | Fixed in Version | => 3.0MP12 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |