Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0015247Openbravo ERP00. Application dictionarypublic2010-11-19 13:082012-05-28 09:02
gorkaion 
guilleaer 
normalminorhave not tried
closedfixed 
20Gentoo
3.0RC2 
3.0MP12 
Core
No
0015247: Some tab title is not translated when redirected from cloned ops popup
On 3.0 layout, on some popups you are redirected to other pages where the tab title is hardcoded and not translated.

Case 1)
When the system detects that your Openbravo Professional Subscription instance has been cloned a popup is shown to the System Administrator role when it is logged.

This popup asks to reactivate the instance to reset the purpose of the instance and redirect the user to the Instance Management window.

Case 2)
Trying to install a module with heartbeat deactivated. A popup appears that redirects you to the heartbeat configuration page.
Case 1)
* Install a different language than English and set it as default.
* Activate the instance.
* Change in database the AD_Heartbeat_log.db_identifier column of the latest created record.
* Log in a System Administrator, a cloned OPS instance should be detected.
* Click on continue and check that the tab title of the window is not translated.

Case 2)
* Try to install a module with heartbeat deactivated.
1) the two labels/texts have to be added as a message to the system, as they are related to core functionality I would put the messages in the client application module.
2) then in the javascript you have to do something like this:
instead of:

tabTitle: 'Heartbeat Configuration'

do this:
tabTitle: getFrame('LayoutMDI').OB.I18N.getLabel('OBUIAPP_HeartBeat_Configuration')
No tags attached.
related to defect 0019362 closed guilleaer Name of the tab is not correct when the tab is opened due to a button action 
Issue History
2010-11-19 13:08gorkaionNew Issue
2010-11-19 13:08gorkaionAssigned To => alostale
2010-11-19 13:15mtaalNote Added: 0032736
2010-11-22 08:35alostaleStatusnew => scheduled
2012-04-26 15:26alostaleRelationship addedrelated to 0019362
2012-04-26 15:26alostaleAssigned Toalostale => guilleaer
2012-05-03 12:24hgbotCheckin
2012-05-03 12:24hgbotNote Added: 0048319
2012-05-03 12:24hgbotStatusscheduled => resolved
2012-05-03 12:24hgbotResolutionopen => fixed
2012-05-03 12:24hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c308742cad47903e474684c040cd7ec05bddd397 [^]
2012-05-03 17:24guilleaerNote Added: 0048355
2012-05-03 17:32guilleaerNote Added: 0048356
2012-05-16 08:47alostaleNote Added: 0048674
2012-05-16 08:47alostaleStatusresolved => closed
2012-05-16 08:47alostaleFixed in Version => 3.0MP12
2012-05-16 09:00alostaleStatusclosed => new
2012-05-16 09:00alostaleResolutionfixed => open
2012-05-16 09:00alostaleFixed in Version3.0MP12 =>
2012-05-16 09:01alostaleNote Edited: 0048674bug_revision_view_page.php?bugnote_id=0048674#r3467
2012-05-17 18:19hgbotCheckin
2012-05-17 18:19hgbotNote Added: 0048746
2012-05-17 18:19hgbotStatusnew => resolved
2012-05-17 18:19hgbotResolutionopen => fixed
2012-05-17 18:19hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/c308742cad47903e474684c040cd7ec05bddd397 [^] => http://code.openbravo.com/erp/devel/pi/rev/c22edc2575342d7b4436eab054a843e4a661563f [^]
2012-05-17 18:24hgbotCheckin
2012-05-17 18:24hgbotNote Added: 0048747
2012-05-17 18:24hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/c22edc2575342d7b4436eab054a843e4a661563f [^] => http://code.openbravo.com/erp/devel/pi/rev/fbb7883e896b9262080d797e923de1b1edde21ec [^]
2012-05-17 19:43hgbotCheckin
2012-05-17 19:43hgbotNote Added: 0048749
2012-05-18 15:55hgbotCheckin
2012-05-18 15:55hgbotNote Added: 0048775
2012-05-25 12:09hudsonbotCheckin
2012-05-25 12:09hudsonbotNote Added: 0049000
2012-05-25 12:12hudsonbotCheckin
2012-05-25 12:12hudsonbotNote Added: 0049160
2012-05-25 12:12hudsonbotCheckin
2012-05-25 12:12hudsonbotNote Added: 0049161
2012-05-25 12:12hudsonbotCheckin
2012-05-25 12:12hudsonbotNote Added: 0049162
2012-05-25 12:13hudsonbotCheckin
2012-05-25 12:13hudsonbotNote Added: 0049168
2012-05-28 09:02alostaleNote Added: 0049330
2012-05-28 09:02alostaleStatusresolved => closed
2012-05-28 09:02alostaleFixed in Version => 3.0MP12

Notes
(0032736)
mtaal   
2010-11-19 13:15   
These are the 2 places where the change needs to be made:

https://code.openbravo.com/erp/devel/pi/file/901f680aa41b/src/org/openbravo/erpCommon/ad_process/HeartbeatRedirect.html#l36 [^]

https://code.openbravo.com/erp/devel/pi/file/901f680aa41b/src/org/openbravo/erpCommon/ad_forms/InstancePurpose.html#l65 [^]
(0048319)
hgbot   
2012-05-03 12:24   
Repository: erp/devel/pi
Changeset: c308742cad47903e474684c040cd7ec05bddd397
Author: Guillermo Álvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Thu May 03 12:18:18 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c308742cad47903e474684c040cd7ec05bddd397 [^]

Fixed issue 15247: Tab title now is shown using the user language.

Instead of create new messages, the tab title is generated using the window/form identifier.

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src/org/openbravo/erpCommon/ad_forms/InstancePurpose.html
M src/org/openbravo/erpCommon/ad_forms/InstancePurpose.java
M src/org/openbravo/erpCommon/ad_forms/InstancePurpose.xml
M src/org/openbravo/erpCommon/ad_process/HeartbeatRedirect.html
M src/org/openbravo/erpCommon/ad_process/HeartbeatRedirect.xml
M src/org/openbravo/erpCommon/ad_process/TestHeartbeat.java
---
(0048355)
guilleaer   
2012-05-03 17:24   
Test plan:

case 1:
Follow the steps defined in steps to reproduce for the case 1. The title of the new tab should appears with the selected language.

case 2:
Unable to reproduce. It seems that the behavior of the heartbeat pop up in the module management window has changed since the issue was reported because now it doesn't open a new tab.

This fix is not risky.
(0048356)
guilleaer   
2012-05-03 17:32   
Although case 2 never happens, a fix has been pushed. If in any case this part of code is executed, the tab title will be drawn using the selected language.

src/org/openbravo/erpCommon/ad_process/HeartbeatRedirect.html
src/org/openbravo/erpCommon/ad_process/HeartbeatRedirect.xml
src/org/openbravo/erpCommon/ad_process/TestHeartbeat.java
(0048674)
alostale   
2012-05-16 08:47   
(edited on: 2012-05-16 09:01)
Code reviewed on pi@d4ef642f1e2a.

Because of the way title variable is set, it will fail in case the translation contains invalid characters (such as ").

(0048746)
hgbot   
2012-05-17 18:19   
Repository: erp/devel/pi
Changeset: c22edc2575342d7b4436eab054a843e4a661563f
Author: Guillermo Álvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Thu May 17 18:18:54 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c22edc2575342d7b4436eab054a843e4a661563f [^]

Fixed issue 15247: escaping problematics characters to include title in js code

---
M src/org/openbravo/erpCommon/ad_forms/InstancePurpose.java
M src/org/openbravo/erpCommon/ad_process/TestHeartbeat.java
---
(0048747)
hgbot   
2012-05-17 18:24   
Repository: erp/devel/pi
Changeset: fbb7883e896b9262080d797e923de1b1edde21ec
Author: Guillermo Álvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Thu May 17 18:24:05 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/fbb7883e896b9262080d797e923de1b1edde21ec [^]

Fixed issue 15247: removing line break

---
M src/org/openbravo/erpCommon/ad_process/TestHeartbeat.java
---
(0048749)
hgbot   
2012-05-17 19:43   
Repository: erp/devel/pi
Changeset: e2957cd09cc5caaf04a252869df250fd76a88933
Author: Guillermo Álvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Thu May 17 19:42:09 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e2957cd09cc5caaf04a252869df250fd76a88933 [^]

Related to issue 15247: 'import static' statement has been removed

---
M src/org/openbravo/erpCommon/ad_forms/InstancePurpose.java
M src/org/openbravo/erpCommon/ad_process/TestHeartbeat.java
---
(0048775)
hgbot   
2012-05-18 15:55   
Repository: erp/devel/pi
Changeset: e398c925655e40eb35f8c0fa0d06bed23d1cb50d
Author: Guillermo Álvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Fri May 18 15:54:13 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e398c925655e40eb35f8c0fa0d06bed23d1cb50d [^]

Related to issue 15247: 'import' statement added and function call corrected

---
M src/org/openbravo/erpCommon/ad_forms/InstancePurpose.java
M src/org/openbravo/erpCommon/ad_process/TestHeartbeat.java
---
(0049000)
hudsonbot   
2012-05-25 12:09   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^]

Maturity status: Test
(0049160)
hudsonbot   
2012-05-25 12:12   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^]

Maturity status: Test
(0049161)
hudsonbot   
2012-05-25 12:12   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^]

Maturity status: Test
(0049162)
hudsonbot   
2012-05-25 12:12   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^]

Maturity status: Test
(0049168)
hudsonbot   
2012-05-25 12:13   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^]

Maturity status: Test
(0049330)
alostale   
2012-05-28 09:02   
code reviewed and verified on pi@87f24231e3f1