Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0015200 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | have not tried | 2010-11-16 11:54 | 2012-05-29 13:15 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | guilleaer | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0MP12 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 3cbbf8aaac00 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0015200: Check and remove the duplicated hardcoded english texts from Login.java | |||||||
| Description | in Login.java several messages shown to the user are read from AD_MESSAGE to be able to translate them as usual. However there's some extra code checking for null/empty message and then use another hardcoded english version of those texts inside the java sourcecode. This looks like not needed and should be cleaned up. (note: two copies for those even now in the servlet (after mp24) one for the 2.50 and another for the 3.0 codepath... | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0048353) hgbot (developer) 2012-05-03 17:07 |
Repository: erp/devel/pi Changeset: 3cbbf8aaac006011454154f2007f2d7e58687f12 Author: Guillermo Álvarez de Eulate <guillermo.alvarez <at> openbravo.com> Date: Thu May 03 17:04:16 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/3cbbf8aaac006011454154f2007f2d7e58687f12 [^] fixed issue 15200: hardcoded texts have been removed from login.java. --- M src/org/openbravo/erpCommon/security/Login.java --- |
|
(0048358) guilleaer (viewer) 2012-05-03 18:01 |
Code cleaned, deleting checks for null/empty messages. The behavior of the login window doesn't changes. If messages which are got from DB are null -> "null" will be shown instead of the hardcoded message. |
|
(0049016) hudsonbot (viewer) 2012-05-25 12:09 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2010-11-16 11:54 | shuehner | New Issue | |
| 2010-11-16 11:54 | shuehner | Assigned To | => alostale |
| 2010-11-16 11:54 | shuehner | OBNetwork customer | => No |
| 2010-11-22 08:35 | alostale | Status | new => scheduled |
| 2010-12-14 10:15 | alostale | Target Version | 2.50MP25 => 2.50MP26 |
| 2011-02-07 08:33 | alostale | Target Version | 2.50MP26 => |
| 2012-04-26 17:24 | alostale | Assigned To | alostale => guilleaer |
| 2012-05-03 17:07 | hgbot | Checkin | |
| 2012-05-03 17:07 | hgbot | Note Added: 0048353 | |
| 2012-05-03 17:07 | hgbot | Status | scheduled => resolved |
| 2012-05-03 17:07 | hgbot | Resolution | open => fixed |
| 2012-05-03 17:07 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/3cbbf8aaac006011454154f2007f2d7e58687f12 [^] |
| 2012-05-03 18:01 | guilleaer | Note Added: 0048358 | |
| 2012-05-25 12:09 | hudsonbot | Checkin | |
| 2012-05-25 12:09 | hudsonbot | Note Added: 0049016 | |
| 2012-05-29 13:15 | marvintm | Status | resolved => closed |
| 2012-05-29 13:15 | marvintm | Fixed in Version | => 3.0MP12 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |