Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0015200Openbravo ERPA. Platformpublic2010-11-16 11:542012-05-29 13:15
Reportershuehner 
Assigned Toguilleaer 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0MP12 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0015200: Check and remove the duplicated hardcoded english texts from Login.java
Descriptionin Login.java several messages shown to the user are read from AD_MESSAGE to be able to translate them as usual.

However there's some extra code checking for null/empty message and then use another hardcoded english version of those texts inside the java sourcecode.

This looks like not needed and should be cleaned up. (note: two copies for those even now in the servlet (after mp24) one for the 2.50 and another for the 3.0 codepath...
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-11-16 11:54shuehnerNew Issue
2010-11-16 11:54shuehnerAssigned To => alostale
2010-11-22 08:35alostaleStatusnew => scheduled
2010-12-14 10:15alostaleTarget Version2.50MP25 => 2.50MP26
2011-02-07 08:33alostaleTarget Version2.50MP26 =>
2012-04-26 17:24alostaleAssigned Toalostale => guilleaer
2012-05-03 17:07hgbotCheckin
2012-05-03 17:07hgbotNote Added: 0048353
2012-05-03 17:07hgbotStatusscheduled => resolved
2012-05-03 17:07hgbotResolutionopen => fixed
2012-05-03 17:07hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/3cbbf8aaac006011454154f2007f2d7e58687f12 [^]
2012-05-03 18:01guilleaerNote Added: 0048358
2012-05-25 12:09hudsonbotCheckin
2012-05-25 12:09hudsonbotNote Added: 0049016
2012-05-29 13:15marvintmStatusresolved => closed
2012-05-29 13:15marvintmFixed in Version => 3.0MP12

Notes
(0048353)
hgbot   
2012-05-03 17:07   
Repository: erp/devel/pi
Changeset: 3cbbf8aaac006011454154f2007f2d7e58687f12
Author: Guillermo Álvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Thu May 03 17:04:16 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/3cbbf8aaac006011454154f2007f2d7e58687f12 [^]

fixed issue 15200: hardcoded texts have been removed from login.java.

---
M src/org/openbravo/erpCommon/security/Login.java
---
(0048358)
guilleaer   
2012-05-03 18:01   
Code cleaned, deleting checks for null/empty messages.

The behavior of the login window doesn't changes.

If messages which are got from DB are null -> "null" will be shown instead of the hardcoded message.
(0049016)
hudsonbot   
2012-05-25 12:09   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^]

Maturity status: Test