Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0015026
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2010-10-25 17:412010-11-09 22:46
ReportershuehnerView Statuspublic 
Assigned Togorkaion 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision42f4be6cf1f8
ProjectionnoneETAnoneTarget Version2.50MP24
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0015026: http request for community branding should be done with http/https depending on how the conn to the erp is...

Description.. as otherwise it leads to security warnings in the browser about unsafe content if the erp is used with ssl.

Note that this is already implement properly to load the ob-utils.js (testing js) but not for the community branding request itself).

If the redirects done in the butler servlet are relative this local change in Home.java should be all which is needed to fix the issue.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0032252)
hgbot (developer)
2010-10-27 12:23

 Repository: erp/devel/pi
Changeset: 42f4be6cf1f8327bbf32deac7e4b8259f1fe03c6
Author: Gorka Ion Damián <gorkaion.damian <at> openbravo.com>
Date: Wed Oct 27 12:22:53 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/42f4be6cf1f8327bbf32deac7e4b8259f1fe03c6 [^]

Fixed issue 15026.Use document.location.protocol on community branding requests to butler.

---
M src/org/openbravo/erpCommon/utility/Home.html
M src/org/openbravo/erpCommon/utility/Home.java
---
(0032426)
hudsonbot (viewer)
2010-11-05 12:44

 A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/42f4be6cf1f8 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/f2cf138fa03c [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18797.obx [^]
(0032513)
shuehner (administrator)
2010-11-09 18:18

 Note: the html content in butler does use several static http requests which then lead to the same problem of mixed http/https in the browser... should probably be redesigned to use only relative links
(0032514)
shuehner (administrator)
2010-11-09 18:22

 Reviewed and tested in pi/pgsql using classic layout working fine. However the community branding html pages need to be adapted to use relative links only otherwise they trigger the same issue again.

- Issue History
Date Modified Username Field Change
2010-10-25 17:41 shuehner New Issue
2010-10-25 17:41 shuehner Assigned To => gorkaion
2010-10-25 17:41 shuehner OBNetwork customer => No
2010-10-26 17:04 shuehner Target Version => 2.50MP24
2010-10-27 12:23 hgbot Checkin
2010-10-27 12:23 hgbot Note Added: 0032252
2010-10-27 12:23 hgbot Status new => resolved
2010-10-27 12:23 hgbot Resolution open => fixed
2010-10-27 12:23 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/42f4be6cf1f8327bbf32deac7e4b8259f1fe03c6 [^]
2010-11-05 12:44 hudsonbot Checkin
2010-11-05 12:44 hudsonbot Note Added: 0032426
2010-11-09 18:18 shuehner Note Added: 0032513
2010-11-09 18:22 shuehner Note Added: 0032514
2010-11-09 18:22 shuehner Status resolved => closed
2010-11-09 22:46 anonymous sf_bug_id 0 => 3106263

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker