Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0015026Openbravo ERPA. Platformpublic2010-10-25 17:412010-11-09 22:46
Reportershuehner 
Assigned Togorkaion 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version2.50MP24Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0015026: http request for community branding should be done with http/https depending on how the conn to the erp is...
Description.. as otherwise it leads to security warnings in the browser about unsafe content if the erp is used with ssl.

Note that this is already implement properly to load the ob-utils.js (testing js) but not for the community branding request itself).

If the redirects done in the butler servlet are relative this local change in Home.java should be all which is needed to fix the issue.
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-10-25 17:41shuehnerNew Issue
2010-10-25 17:41shuehnerAssigned To => gorkaion
2010-10-25 17:41shuehnerOBNetwork customer => No
2010-10-26 17:04shuehnerTarget Version => 2.50MP24
2010-10-27 12:23hgbotCheckin
2010-10-27 12:23hgbotNote Added: 0032252
2010-10-27 12:23hgbotStatusnew => resolved
2010-10-27 12:23hgbotResolutionopen => fixed
2010-10-27 12:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/42f4be6cf1f8327bbf32deac7e4b8259f1fe03c6 [^]
2010-11-05 12:44hudsonbotCheckin
2010-11-05 12:44hudsonbotNote Added: 0032426
2010-11-09 18:18shuehnerNote Added: 0032513
2010-11-09 18:22shuehnerNote Added: 0032514
2010-11-09 18:22shuehnerStatusresolved => closed
2010-11-09 22:46anonymoussf_bug_id0 => 3106263

Notes
(0032252)
hgbot   
2010-10-27 12:23   
Repository: erp/devel/pi
Changeset: 42f4be6cf1f8327bbf32deac7e4b8259f1fe03c6
Author: Gorka Ion Damián <gorkaion.damian <at> openbravo.com>
Date: Wed Oct 27 12:22:53 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/42f4be6cf1f8327bbf32deac7e4b8259f1fe03c6 [^]

Fixed issue 15026.Use document.location.protocol on community branding requests to butler.

---
M src/org/openbravo/erpCommon/utility/Home.html
M src/org/openbravo/erpCommon/utility/Home.java
---
(0032426)
hudsonbot   
2010-11-05 12:44   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/42f4be6cf1f8 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/f2cf138fa03c [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18797.obx [^]
(0032513)
shuehner   
2010-11-09 18:18   
Note: the html content in butler does use several static http requests which then lead to the same problem of mixed http/https in the browser... should probably be redesigned to use only relative links
(0032514)
shuehner   
2010-11-09 18:22   
Reviewed and tested in pi/pgsql using classic layout working fine. However the community branding html pages need to be adapted to use relative links only otherwise they trigger the same issue again.