Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0014923 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] 03. Procurement management | major | always | 2010-10-19 19:20 | 2010-10-30 11:24 | |||
| Reporter | psarobe | View Status | public | |||||
| Assigned To | dalsasua | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 6d605d17991c | ||||
| Projection | none | ETA | none | Target Version | 2.50MP23 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | 2.50MP22 | SCM revision | ||||||
| Merge Request Status | ||||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0014923: If there is not warehouse defined, taxes are not properly calculated | |||||||
| Description | If the ERP has no warehouse defined, I mean, there is any warehouse created then taxes are not calculated well | |||||||
| Steps To Reproduce | 1. Have a context running withou any warehouse 2. Go to Procurement->Transactions->Procurement invoice 3. Click new and select a bpartner 4. Move to lines tab and select a product. Notice that no tax is selected in the combo box when it has to | |||||||
| Proposed Solution | --- a/src/org/openbravo/erpCommon/ad_callouts/SL_Invoice_Product.java +++ b/src/org/openbravo/erpCommon/ad_callouts/SL_Invoice_Product.java @@ -75,12 +75,14 @@ .getOrganizationStructureProvider(vars.getClient()); if (!strADOrgID.equals(strWarehouseOrg)) { Organization org = OBDal.getInstance().get(Organization.class, strADOrgID); - Organization warehouseOrg = OBDal.getInstance().get(Organization.class, strWarehouseOrg); - if (!osp.isInNaturalTree(org, warehouseOrg) && !osp.isInNaturalTree(warehouseOrg, org)) - strWarehouseForOrg = SLOrderProductData.getWarehouseOfOrg(this, vars.getClient(), - strADOrgID); - if (!strWarehouseForOrg.equals("")) - strWharehouse = strWarehouseForOrg; + if (strWarehouseOrg != null) { + Organization warehouseOrg = OBDal.getInstance().get(Organization.class, strWarehouseOrg); + if (!osp.isInNaturalTree(org, warehouseOrg) && !osp.isInNaturalTree(warehouseOrg, org)) + strWarehouseForOrg = SLOrderProductData.getWarehouseOfOrg(this, vars.getClient(), + strADOrgID); + if (!strWarehouseForOrg.equals("")) + strWharehouse = strWarehouseForOrg; + } } String strTabId = vars.getStringParameter("inpTabId"); | |||||||
| Tags | Regression | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0031990) psarobe (viewer) 2010-10-19 19:21 edited on: 2010-10-19 19:22 |
This regression was introduced by this fix 14047 |
|
(0032006) hgbot (developer) 2010-10-20 12:57 |
Repository: erp/devel/pi Changeset: 6d605d17991c46ec97c15c68318a021e44c3b8bd Author: David Alsasua <david.alsasua <at> openbravo.com> Date: Wed Oct 20 12:56:48 2010 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/6d605d17991c46ec97c15c68318a021e44c3b8bd [^] Fixes issue 14923: If there is not warehouse defined, taxes are not properly calculated --- M src/org/openbravo/erpCommon/ad_callouts/SL_Invoice_Product.java --- |
|
(0032031) hudsonbot (viewer) 2010-10-20 23:44 |
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated: Changeset: http://code.openbravo.com/erp/devel/main/rev/6d605d17991c [^] Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/580d14a11e98 [^] Tests: http://builds.openbravo.com/view/int/ [^] OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18576.obx [^] |
|
(0032088) sureshbabu (viewer) 2010-10-22 04:03 |
verified in oracle context |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2010-10-19 19:20 | psarobe | New Issue | |
| 2010-10-19 19:20 | psarobe | Assigned To | => dalsasua |
| 2010-10-19 19:20 | psarobe | OBNetwork customer | => No |
| 2010-10-19 19:20 | psarobe | Tag Attached: Regression | |
| 2010-10-19 19:20 | psarobe | Status | new => scheduled |
| 2010-10-19 19:20 | psarobe | fix_in_branch | => pi |
| 2010-10-19 19:21 | psarobe | Note Added: 0031990 | |
| 2010-10-19 19:22 | psarobe | Relationship added | related to 0014047 |
| 2010-10-19 19:22 | psarobe | Note Edited: 0031990 | View Revisions |
| 2010-10-20 12:24 | dalsasua | fix_in_branch | pi => |
| 2010-10-20 12:24 | dalsasua | Proposed Solution updated | |
| 2010-10-20 12:57 | hgbot | Checkin | |
| 2010-10-20 12:57 | hgbot | Note Added: 0032006 | |
| 2010-10-20 12:57 | hgbot | Status | scheduled => resolved |
| 2010-10-20 12:57 | hgbot | Resolution | open => fixed |
| 2010-10-20 12:57 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/6d605d17991c46ec97c15c68318a021e44c3b8bd [^] |
| 2010-10-20 23:44 | hudsonbot | Checkin | |
| 2010-10-20 23:44 | hudsonbot | Note Added: 0032031 | |
| 2010-10-22 04:03 | sureshbabu | Status | resolved => closed |
| 2010-10-22 04:03 | sureshbabu | Note Added: 0032088 | |
| 2010-10-30 11:24 | anonymous | sf_bug_id | 0 => 3098750 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |