0014923: If there is not warehouse defined, taxes are not properly calculated

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0014923

Openbravo ERP

03. Procurement management

public

2010-10-19 19:20

2010-10-30 11:24

Reporter

psarobe

Assigned To

dalsasua

Priority

immediate

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

2.50MP22

Target Version

2.50MP23

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0014923: If there is not warehouse defined, taxes are not properly calculated

Description

If the ERP has no warehouse defined, I mean, there is any warehouse created then taxes are not calculated well

Steps To Reproduce

1. Have a context running withou any warehouse
2. Go to Procurement->Transactions->Procurement invoice
3. Click new and select a bpartner
4. Move to lines tab and select a product. Notice that no tax is selected in the combo box when it has to

Proposed Solution

--- a/src/org/openbravo/erpCommon/ad_callouts/SL_Invoice_Product.java
+++ b/src/org/openbravo/erpCommon/ad_callouts/SL_Invoice_Product.java
@@ -75,12 +75,14 @@
           .getOrganizationStructureProvider(vars.getClient());
       if (!strADOrgID.equals(strWarehouseOrg)) {
         Organization org = OBDal.getInstance().get(Organization.class, strADOrgID);
- Organization warehouseOrg = OBDal.getInstance().get(Organization.class, strWarehouseOrg);
- if (!osp.isInNaturalTree(org, warehouseOrg) && !osp.isInNaturalTree(warehouseOrg, org))
- strWarehouseForOrg = SLOrderProductData.getWarehouseOfOrg(this, vars.getClient(),
- strADOrgID);
- if (!strWarehouseForOrg.equals(""))
- strWharehouse = strWarehouseForOrg;
+ if (strWarehouseOrg != null) {
+ Organization warehouseOrg = OBDal.getInstance().get(Organization.class, strWarehouseOrg);
+ if (!osp.isInNaturalTree(org, warehouseOrg) && !osp.isInNaturalTree(warehouseOrg, org))
+ strWarehouseForOrg = SLOrderProductData.getWarehouseOfOrg(this, vars.getClient(),
+ strADOrgID);
+ if (!strWarehouseForOrg.equals(""))
+ strWharehouse = strWarehouseForOrg;
+ }
       }
       String strTabId = vars.getStringParameter("inpTabId");

Additional Information