Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0014859
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Openbravo ERP] A. Platformminorhave not tried2010-10-12 13:582010-10-30 11:24
ReportershuehnerView Statuspublic 
Assigned Tomtaal 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision0fbf88fbd3e9
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0014859: Add feature for REST delete request to select entities via HQL in URI instead of xml-document in request body

DescriptionSo far the dal implementation of a rest delete request supports:

- deleting individual entities via adressing them via URI only (no request body with an xml document needed)
- deleting multiple entities by specifying them via an xml-document in a request body).

At least the commons-httpclient implementation does not support specifying an request body for a HTTP delete-request. (and rfc 2616 does not talk about any request body either for a delete request).

So a third say of selecting entities could be via:

- URI with an hql where clause similar to the dal-rest get request and not using a request body in that case.
TagsNo tags attached.
Attached Filesdiff file icon 14859.diff [^] (2,563 bytes) 2010-10-12 14:33 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0031779)
shuehner (administrator)
2010-10-12 13:58

Attaching proposed implementation provided by shadow.
(0031881)
hgbot (developer)
2010-10-15 15:44

Repository: erp/devel/pi
Changeset: 0fbf88fbd3e91438cb75a98d166d3bdd7e850720
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Oct 15 15:44:15 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/0fbf88fbd3e91438cb75a98d166d3bdd7e850720 [^]

Fixes issue 14859: Add feature for REST delete request to select entities via HQL in URI instead of xml-document in request body

---
M src-test/org/openbravo/test/AllWebserviceTests.java
M src-test/org/openbravo/test/webservice/WSUpdateTest.java
M src/org/openbravo/dal/core/DalUtil.java
M src/org/openbravo/dal/service/OBQuery.java
M src/org/openbravo/service/rest/DalWebService.java
---
(0031933)
hudsonbot (developer)
2010-10-18 17:39

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/0fbf88fbd3e9 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/e1c7df1ae349 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18559.obx [^]
(0032074)
marvintm (developer)
2010-10-21 17:43

Tested that deletion works when executing the delete request with a whereclause.

- Issue History
Date Modified Username Field Change
2010-10-12 13:58 shuehner New Issue
2010-10-12 13:58 shuehner Assigned To => mtaal
2010-10-12 13:58 shuehner Note Added: 0031779
2010-10-12 13:59 shuehner File Added: 14859.diff
2010-10-12 14:33 shuehner File Deleted: 14859.diff
2010-10-12 14:33 shuehner File Added: 14859.diff
2010-10-12 14:42 sgue0065 Issue Monitored: sgue0065
2010-10-15 15:44 hgbot Checkin
2010-10-15 15:44 hgbot Note Added: 0031881
2010-10-15 15:44 hgbot Status new => resolved
2010-10-15 15:44 hgbot Resolution open => fixed
2010-10-15 15:44 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0fbf88fbd3e91438cb75a98d166d3bdd7e850720 [^]
2010-10-18 17:39 hudsonbot Checkin
2010-10-18 17:39 hudsonbot Note Added: 0031933
2010-10-21 17:43 marvintm Note Added: 0032074
2010-10-21 17:43 marvintm Status resolved => closed
2010-10-30 11:24 anonymous sf_bug_id 0 => 3098746


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker