Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0014859Openbravo ERPA. Platformpublic2010-10-12 13:582010-10-30 11:24
Reportershuehner 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0014859: Add feature for REST delete request to select entities via HQL in URI instead of xml-document in request body
DescriptionSo far the dal implementation of a rest delete request supports:

- deleting individual entities via adressing them via URI only (no request body with an xml document needed)
- deleting multiple entities by specifying them via an xml-document in a request body).

At least the commons-httpclient implementation does not support specifying an request body for a HTTP delete-request. (and rfc 2616 does not talk about any request body either for a delete request).

So a third say of selecting entities could be via:

- URI with an hql where clause similar to the dal-rest get request and not using a request body in that case.
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff 14859.diff (2,563) 2010-10-12 14:33
https://issues.openbravo.com/file_download.php?file_id=3218&type=bug
Issue History
Date ModifiedUsernameFieldChange
2010-10-12 13:58shuehnerNew Issue
2010-10-12 13:58shuehnerAssigned To => mtaal
2010-10-12 13:58shuehnerOBNetwork customer => No
2010-10-12 13:58shuehnerNote Added: 0031779
2010-10-12 13:59shuehnerFile Added: 14859.diff
2010-10-12 14:33shuehnerFile Deleted: 14859.diff
2010-10-12 14:33shuehnerFile Added: 14859.diff
2010-10-12 14:42sgue0065Issue Monitored: sgue0065
2010-10-15 15:44hgbotCheckin
2010-10-15 15:44hgbotNote Added: 0031881
2010-10-15 15:44hgbotStatusnew => resolved
2010-10-15 15:44hgbotResolutionopen => fixed
2010-10-15 15:44hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0fbf88fbd3e91438cb75a98d166d3bdd7e850720 [^]
2010-10-18 17:39hudsonbotCheckin
2010-10-18 17:39hudsonbotNote Added: 0031933
2010-10-21 17:43marvintmNote Added: 0032074
2010-10-21 17:43marvintmStatusresolved => closed
2010-10-30 11:24anonymoussf_bug_id0 => 3098746

Notes
(0031779)
shuehner   
2010-10-12 13:58   
Attaching proposed implementation provided by shadow.
(0031881)
hgbot   
2010-10-15 15:44   
Repository: erp/devel/pi
Changeset: 0fbf88fbd3e91438cb75a98d166d3bdd7e850720
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Oct 15 15:44:15 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/0fbf88fbd3e91438cb75a98d166d3bdd7e850720 [^]

Fixes issue 14859: Add feature for REST delete request to select entities via HQL in URI instead of xml-document in request body

---
M src-test/org/openbravo/test/AllWebserviceTests.java
M src-test/org/openbravo/test/webservice/WSUpdateTest.java
M src/org/openbravo/dal/core/DalUtil.java
M src/org/openbravo/dal/service/OBQuery.java
M src/org/openbravo/service/rest/DalWebService.java
---
(0031933)
hudsonbot   
2010-10-18 17:39   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/0fbf88fbd3e9 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/e1c7df1ae349 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18559.obx [^]
(0032074)
marvintm   
2010-10-21 17:43   
Tested that deletion works when executing the delete request with a whereclause.