Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0014817
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Z. Othersmajorhave not tried2010-10-07 14:082011-05-24 10:57
ReportershuehnerView Statuspublic 
Assigned Tomirurita 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchpiFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version2.50SCM revision 
Review Assigned To
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0014817: This module contains incorrect ad_column definitions for some of its views

DescriptionThis module contains a few views for which ad_table/ad_column entries are shipped in the module.

Some of those ad_column entries contain incorrect reference definitions (i.e. column c_locto_id with reference tabledir, but no c_locto table exists).

Starting from >MP22 dal does also support views which means those wrong references generate warnings/errors on each dal-startup (i.e. generate.entities or tomcat startup).

Those reference should be fixed.

Note that the error/warning display in core will also be 'improved' to be not so verbose as the severity of those warnings (when coming from views) is low, as no code could have been using them up to now.
Steps To ReproduceUse pi or main >MP22 install org.openbravo.advpaymentmngt module. See compilation log for i.e. generate.entities step.
TagsclosingMay2011
Attached Filestxt file icon generate.entities.txt [^] (55,834 bytes) 2010-10-07 14:09 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 00148182.50MP23 closedmtaal Check for views on each dal-startup are to 'verbose' 

-  Notes
(0031646)
mirurita (developer)
2010-10-07 16:33

 Fixed in revision 627:0ce4317b52d5 (30th Sept)
https://code.openbravo.com/erp/pmods/org.openbravo.advpaymentmngt/rev/0ce4317b52d5 [^]

With this commit in core we are forcing all the modules which have views (probably not well defined) to update the dependency to MP23 and publish a new version.
If not, when MP23 will published they will fail in the installation.

Can we understand it as a regression? because for example APRM installed successfully in MP22 and it will fail in a MP23.
(0031650)
shuehner (administrator)
2010-10-07 17:16

 Thx for the pointer... has not using the latest version of your module by accident so missed this commit which already fixes the issue/wrong definitions in your module.

About regression: At most regression-qa as this has not yet been released, correct issue to mark as such would be 14818.

However not yet sure if it is as afaik your module should be install but show some long/scary error messages (and should work fine i think).
And in 14818 it is planned to change those error message to be non-scary so that all module owners to NOT need to update all their modules immediately but just get a warning and can fix it when they want.

Also the ad_column definition was wrong forever just the system didn't care so in theory the module was broken just this is visible now and wasn't before..

But fine to tag the 14818 as regression-qa for me no need for big dicussion of pro/con this ;)
(0031651)
shuehner (administrator)
2010-10-07 17:17

 Note: i don't really understand your part 'With this commit' as the mentioned commit from your is not from core... and also not sure why modules need to update their dep to mp23 to be able to fix their own definition. Is that really needed?
(0031653)
mirurita (developer)
2010-10-07 17:26

 The changeset 8448:d61bca59af84 in core was not allowing to install a module with views (not well-formed) in a theoretical MP23.
Eduardo faced this problem and he fixed the views definition to allow installing the module.
(0031655)
shuehner (administrator)
2010-10-07 17:30

 Ok clearer now. However only outcome i noticed with that change (so far) is that if you have a unfixed module (like older advpaymentmngt already installed) then on next dal-startup having that dal change you get lots of error-message shown. Which however on cmd-line didn't stop the process. Will recheck with eduardo for details.

- Issue History
Date Modified Username Field Change
2010-10-07 14:08 shuehner New Issue
2010-10-07 14:08 shuehner Assigned To => mirurita
2010-10-07 14:09 shuehner File Added: generate.entities.txt
2010-10-07 14:15 shuehner Relationship added related to 0014818
2010-10-07 16:28 mirurita Issue Monitored: mirurita
2010-10-07 16:28 mirurita Issue End Monitor: mirurita
2010-10-07 16:28 mirurita Status new => scheduled
2010-10-07 16:28 mirurita fix_in_branch => pi
2010-10-07 16:33 mirurita Note Added: 0031646
2010-10-07 16:33 mirurita Status scheduled => resolved
2010-10-07 16:33 mirurita Resolution open => fixed
2010-10-07 17:16 shuehner Note Added: 0031650
2010-10-07 17:17 shuehner Note Added: 0031651
2010-10-07 17:26 mirurita Note Added: 0031653
2010-10-07 17:30 shuehner Note Added: 0031655
2011-05-24 09:59 dalsasua Tag Attached: closingMay2011
2011-05-24 10:57 dalsasua Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker