Anonymous | Login
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajorhave not tried2010-10-07 14:142010-10-20 00:00
ReportershuehnerView Statuspublic 
Assigned Tomtaal 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchpiFixed in SCM revision8f1e3114223e
ProjectionnoneETAnoneTarget Version2.50MP23
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo

0014818: Check for views on each dal-startup are to 'verbose'

DescriptionNow that DAL supports views the ad_column definition for views needs to conform to the usual rules (i.e. for a column named ad_client_id a table named ad_client) needs to exist.

Some modules contain incorrect definitions for their views as up to now and could get away with it as i.e. those might be in an ad_column entry which is not used (example used by an not display ad_field record only).

As module owners cannot be expected to fix this for all modules immediately and may need some month (and no urgency for them, if they don't use their views via dal (which they couldn't so far)) the warning display needs to be not so intrusive like it is now.

I.e. use the 'usual' policy of 'warning' developers and 'not scaring' users.
Steps To Reproduceon current pi
install org.openbravo.advpaymentmngt module (i.e. latest hg)
see output of any dal-startup (tomcat startup, generate.entities)
Proposed SolutionChange logging output to be not so intrusive (i.e. no stacktrace if they don't give a benefit (i.e. BaseForeignKeyDomainType:51 perhaps) and downgrade loglevels for the other errors perhaps (warning or info or nothing (perhaps only for views as for normal tables those checks should probably stay at level error like they are now))
TagsNo tags attached.
Attached Filestxt file icon generate.entities.txt [^] (55,834 bytes) 2010-10-07 14:15 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0014817 closedmirurita This module contains incorrect ad_column definitions for some of its views 

-  Notes
shuehner (administrator)
2010-10-07 17:25

Note: The example module used in the description did already fix the issue a week ago. To reproduce it use a hg version not including the changeset below:

Fixed in revision 627:0ce4317b52d5 (30th Sept) [^]
hgbot (developer)
2010-10-14 19:34

Repository: erp/devel/pi
Changeset: 8f1e3114223e139c894ec23a272731dc9398ee34
Author: Martin Taal <martin.taal <at>>
Date: Thu Oct 14 19:34:11 2010 +0200
URL: [^]

fixes issue 14818: Check for views on each dal-startup are to 'verbose'

M src/build.xml
M src/org/openbravo/base/gen/
M src/org/openbravo/base/gen/
M src/org/openbravo/base/gen/gen_entity.oaw
M src/org/openbravo/base/model/
M src/org/openbravo/base/model/
M src/org/openbravo/base/model/domaintype/
M src/org/openbravo/base/session/
hudsonbot (developer)
2010-10-18 17:39

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: [^]
Merge Changeset: [^]
Tests: [^]
OBX: [^]
marvintm (developer)
2010-10-19 10:27

Checked that when installing an old version of the module which still doesn't have the fixes for the views issue, no warnings or errors were raised on the rebuild window.

- Issue History
Date Modified Username Field Change
2010-10-07 14:14 shuehner New Issue
2010-10-07 14:14 shuehner Assigned To => alostale
2010-10-07 14:15 shuehner Assigned To alostale => mtaal
2010-10-07 14:15 shuehner Relationship added related to 0014817
2010-10-07 14:15 shuehner File Added: generate.entities.txt
2010-10-07 17:25 shuehner Note Added: 0031652
2010-10-11 08:57 alostale Status new => scheduled
2010-10-11 08:57 alostale fix_in_branch => pi
2010-10-14 19:34 hgbot Checkin
2010-10-14 19:34 hgbot Note Added: 0031860
2010-10-14 19:34 hgbot Status scheduled => resolved
2010-10-14 19:34 hgbot Resolution open => fixed
2010-10-14 19:34 hgbot Fixed in SCM revision => [^]
2010-10-18 17:39 hudsonbot Checkin
2010-10-18 17:39 hudsonbot Note Added: 0031929
2010-10-19 10:27 marvintm Note Added: 0031955
2010-10-19 10:27 marvintm Status resolved => closed
2010-10-20 00:00 anonymous sf_bug_id 0 => 3090872

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker