Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0014811

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Openbravo ERP] Z. Others

minor

have not tried

2010-10-07 12:32

2011-05-24 10:57

Reporter

eintelau

View Status

public

Assigned To

dbaz

Priority

normal

Resolution

fixed

Fixed in Version

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Linux 32 bit

Database

PostgreSQL

Java version

1.6

OS Version

5.2

Database version

8.3

Ant version

1.7

Product Version

2.50

SCM revision

Review Assigned To

Web browser

Modules

User Interface Application

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0014811: Javascript errors validating OBNumberItem result in selector popup failing

Description

I struck this problem when reconciling a financial account with an imported bank statement. When I clicked the find link in the reconcile window the selector would start loading then hang.

The hang was caused by a javascript error in ob_formitem_widgets.js:
"this.OBNumberItemElement is null" on line 530
(error messages paraphrased from memory)

After fixing that error I had another one on line 579:
"number.match is not a method"

That one was occuring because number was a integer (I assume because the value had been set from the JSON response not the UI), not a string and hence didn't have a match method.

I was able to fix the issue, but am not sure why the validation method was being called on the selector load. Especially since the error seems to be occurring on the lineNo field which is not displayed by that selector

Proposed Solution

1) Set this.OBNumberItemElement from the form parameter in the OBNumberItem validate method

2) Ensure number parameter is a string before performing regex check in validateNumber method

Tags

14811.patch [^] (1,156 bytes) 2010-10-07 12:48 [Show Content] [Hide Content]

# HG changeset patch
# User Ben Sommerville <ben.sommerville@eintel.com.au>
# Date 1286447698 -39600
# Node ID 6fc61acac85f6878a78dec7cd9ba50881f6787a6
# Parent  920c904e01cef4c6398becbbe68d672164d1bbd0
Fixes issue 14811: Set OBNumberItemElement in validate method and ensure number value is a string before performing regex validation

diff -r 920c904e01ce -r 6fc61acac85f web/org.openbravo.client.application/js/ob_formitem_widgets.js
--- a/web/org.openbravo.client.application/js/ob_formitem_widgets.js	Thu Oct 07 12:09:22 2010 +0200
+++ b/web/org.openbravo.client.application/js/ob_formitem_widgets.js	Thu Oct 07 21:34:58 2010 +1100
@@ -555,7 +555,9 @@
     if (number === null || number === "" || typeof number === "undefined") {
       return true;
     }
-
+    if( typeof number != "string") {
+      number = "" + number;
+    }
     var bolNegative = true;
     if (maskNumeric.indexOf("+") === 0) {
       bolNegative = false;
@@ -643,6 +645,7 @@
   validators : [{
     type : "custom",
     condition : function (form, item, value) {
+      OBNumberItem.OBNumberItemElement=form;
       return OBNumberItem.validateNumber(value);
     }
   }]

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0031638) eintelau (developer) 2010-10-07 12:49	Patch with suggested fix is attached I'm not comfortable pushing a fix directly into the repository as I don't understand this code well enough.

(0031663) dbaz (developer) 2010-10-07 19:01	Thank you very much eintelau I am going to fix the issue in a slightly different way. Please check if you are still experiencing the issue. Regards and thanks again!

(0031664) hgbot (developer) 2010-10-07 19:02	Repository: erp/mods/org.openbravo.client.application Changeset: ec6bb1d177460661dce3e2b26067c81ce4fc8fab Author: David Baz Fayos <david.baz <at> openbravo.com> Date: Thu Oct 07 19:02:11 2010 +0200 URL: http://code.openbravo.com/erp/mods/org.openbravo.client.application/rev/ec6bb1d177460661dce3e2b26067c81ce4fc8fab [^] Fixed issue 14811: Removed JS errors in OBNumberItem --- M web/org.openbravo.client.application/js/ob_formitem_widgets.js ---

(0031723) eintelau (developer) 2010-10-11 05:03	Hi David, I have just tested the fix that you committed and I still get a javascript error "this.OBNumberItemElement is null" on the line "maskNumeric = this.OBNumberItemElement.maskNumeric;" within the validateNumber function. regards Ben

Issue History
Date Modified	Username	Field	Change
2010-10-07 12:32	eintelau	New Issue
2010-10-07 12:32	eintelau	Assigned To	=> mtaal
2010-10-07 12:41	mtaal	Assigned To	mtaal => dbaz
2010-10-07 12:48	eintelau	File Added: 14811.patch
2010-10-07 12:49	eintelau	Note Added: 0031638
2010-10-07 12:49	eintelau	Issue Monitored: eintelau
2010-10-07 19:01	dbaz	Note Added: 0031663
2010-10-07 19:02	hgbot	Checkin
2010-10-07 19:02	hgbot	Note Added: 0031664
2010-10-07 19:02	hgbot	Status	new => resolved
2010-10-07 19:02	hgbot	Resolution	open => fixed
2010-10-07 19:02	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/mods/org.openbravo.client.application/rev/ec6bb1d177460661dce3e2b26067c81ce4fc8fab [^]
2010-10-11 05:03	eintelau	Note Added: 0031723
2011-05-24 09:59	dalsasua	Tag Attached: closingMay2011
2011-05-24 10:57	dalsasua	Status	resolved => closed

Copyright © 2000 - 2009 MantisBT Group