Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0014811 | Openbravo ERP | Z. Others | public | 2010-10-07 12:32 | 2011-05-24 10:57 |
|
| Reporter | eintelau | |
| Assigned To | dbaz | |
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 20 | OS Version | 5.2 |
| Product Version | 2.50 | |
| Target Version | | Fixed in Version | | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Web browser | |
| Modules | User Interface Application |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0014811: Javascript errors validating OBNumberItem result in selector popup failing |
| Description | I struck this problem when reconciling a financial account with an imported bank statement. When I clicked the find link in the reconcile window the selector would start loading then hang.
The hang was caused by a javascript error in ob_formitem_widgets.js:
"this.OBNumberItemElement is null" on line 530
(error messages paraphrased from memory)
After fixing that error I had another one on line 579:
"number.match is not a method"
That one was occuring because number was a integer (I assume because the value had been set from the JSON response not the UI), not a string and hence didn't have a match method.
I was able to fix the issue, but am not sure why the validation method was being called on the selector load. Especially since the error seems to be occurring on the lineNo field which is not displayed by that selector
|
| Steps To Reproduce | |
| Proposed Solution | 1) Set this.OBNumberItemElement from the form parameter in the OBNumberItem validate method
2) Ensure number parameter is a string before performing regex check in validateNumber method |
| Additional Information | |
| Tags | closingMay2011 |
| Relationships | |
| Attached Files |  14811.patch (1,156) 2010-10-07 12:48
https://issues.openbravo.com/file_download.php?file_id=3185&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2010-10-07 12:32 | eintelau | New Issue | |
| 2010-10-07 12:32 | eintelau | Assigned To | => mtaal |
| 2010-10-07 12:41 | mtaal | Assigned To | mtaal => dbaz |
| 2010-10-07 12:48 | eintelau | File Added: 14811.patch | |
| 2010-10-07 12:49 | eintelau | Note Added: 0031638 | |
| 2010-10-07 12:49 | eintelau | Issue Monitored: eintelau | |
| 2010-10-07 19:01 | dbaz | Note Added: 0031663 | |
| 2010-10-07 19:02 | hgbot | Checkin | |
| 2010-10-07 19:02 | hgbot | Note Added: 0031664 | |
| 2010-10-07 19:02 | hgbot | Status | new => resolved |
| 2010-10-07 19:02 | hgbot | Resolution | open => fixed |
| 2010-10-07 19:02 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/mods/org.openbravo.client.application/rev/ec6bb1d177460661dce3e2b26067c81ce4fc8fab [^] |
| 2010-10-11 05:03 | eintelau | Note Added: 0031723 | |
| 2011-05-24 09:59 | dalsasua | Tag Attached: closingMay2011 | |
| 2011-05-24 10:57 | dalsasua | Status | resolved => closed |
|
Notes |
|
|
|
Patch with suggested fix is attached
I'm not comfortable pushing a fix directly into the repository as I don't understand this code well enough. |
|
|
|
(0031663)
|
|
dbaz
|
|
2010-10-07 19:01
|
|
Thank you very much eintelau
I am going to fix the issue in a slightly different way.
Please check if you are still experiencing the issue.
Regards and thanks again! |
|
|
|
(0031664)
|
|
hgbot
|
|
2010-10-07 19:02
|
|
|
|
|
|
Hi David,
I have just tested the fix that you committed and I still get a javascript error
"this.OBNumberItemElement is null" on the line "maskNumeric = this.OBNumberItemElement.maskNumeric;" within the validateNumber function.
regards
Ben |
|