Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0014657
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementmajoralways2010-09-22 18:292010-10-30 11:24
ReporterpsanjuanView Statuspublic 
Assigned Tosathiyan 
PriorityimmediateResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisionc53d50bda831
ProjectionnoneETAnoneTarget Version
OSLinux 32 bitDatabaseOracleJava version1.6
OS VersionUbuntu 8.04.1Database version11.1.0.6.0Ant version1.7.0
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0014657: System should check in case a GL item with no accounting info is used while booking a financial invoice

DescriptionSystem should check in case a GL item with no accounting info is used while booking a financial invoice
Steps To ReproduceCreate a new GL Item, but do not add any row in Accounting sub-tab
Process and post a new invoice with that GLItem as account in a financial invoice line
Notice that "Cuenta de cuadre" is used because no accounting was present.
Proposed SolutionIn DocInvoice, change
  public boolean getDocumentConfirmation(ConnectionProvider conn, String strRecordId) {
    return true;
  }
with a code that checks:
- Is there any financial invoice line?
|-> No -> return true
|-> Yes -> is there ONE accounting sub-tab record in the G/L Item used?
---|-> Yes -> return true
---|-> No -> return error through these two lines of code:
                              setStatus(STATUS_Error);
                              return false;
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0031778)
sathiyan (reporter)
2010-10-12 10:24

Could you please add steps to reproducible, so that I come to know exactly where to do?
(0031797)
dalsasua (reporter)
2010-10-13 11:07

@Sathiyan: done
(0031850)
hgbot (developer)
2010-10-14 14:34

Repository: erp/devel/pi
Changeset: c53d50bda831818bd68db9bd085ac8f5a64d2b27
Author: Sathiyan Sivaprakasam <sathiyan.sivaprakasam <at> openbravo.com>
Date: Thu Oct 14 18:03:26 2010 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/c53d50bda831818bd68db9bd085ac8f5a64d2b27 [^]

Fixes Issue 14657: System should check in case a GL item with no accounting info is used

---
M src/org/openbravo/erpCommon/ad_forms/DocInvoice.java
M src/org/openbravo/erpCommon/ad_forms/DocInvoice_data.xsql
---
(0031867)
hudsonbot (developer)
2010-10-14 22:29

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/c53d50bda831 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/d7ad2f964c30 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18536.obx [^]
(0032094)
sureshbabu (reporter)
2010-10-22 09:10

verified, now system not allowing the user to post the invoice, when GL item is defined with "Enable in Financial Invoices" checkbox checked and there is no accounting entries defined

- Issue History
Date Modified Username Field Change
2010-09-22 18:29 psanjuan New Issue
2010-09-22 18:29 psanjuan Assigned To => vmromanos
2010-09-23 12:51 psarobe Project Modules => Openbravo ERP
2010-10-12 10:22 sathiyan Assigned To vmromanos => sathiyan
2010-10-12 10:24 sathiyan Note Added: 0031778
2010-10-12 10:24 sathiyan Status new => feedback
2010-10-13 11:06 dalsasua Category Asset Management => 00. Application dictionary
2010-10-13 11:06 dalsasua Steps to Reproduce Updated View Revisions
2010-10-13 11:06 dalsasua Proposed Solution updated
2010-10-13 11:06 dalsasua Status feedback => new
2010-10-13 11:07 dalsasua Note Added: 0031797
2010-10-14 13:54 sathiyan Status new => scheduled
2010-10-14 13:54 sathiyan fix_in_branch => pi
2010-10-14 14:34 hgbot Checkin
2010-10-14 14:34 hgbot Note Added: 0031850
2010-10-14 14:34 hgbot Status scheduled => resolved
2010-10-14 14:34 hgbot Resolution open => fixed
2010-10-14 14:34 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c53d50bda831818bd68db9bd085ac8f5a64d2b27 [^]
2010-10-14 15:51 psanjuan Category 00. Application dictionary => 09. Financial management
2010-10-14 15:51 psanjuan fix_in_branch pi =>
2010-10-14 22:29 hudsonbot Checkin
2010-10-14 22:29 hudsonbot Note Added: 0031867
2010-10-22 09:10 sureshbabu Note Added: 0032094
2010-10-22 09:10 sureshbabu Status resolved => closed
2010-10-30 11:24 anonymous sf_bug_id 0 => 3098736


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker