Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0014657Openbravo ERP09. Financial managementpublic2010-09-22 18:292010-10-30 11:24
psanjuan 
sathiyan 
immediatemajoralways
closedfixed 
20Ubuntu 8.04.1
 
 
Core
No
0014657: System should check in case a GL item with no accounting info is used while booking a financial invoice
System should check in case a GL item with no accounting info is used while booking a financial invoice
Create a new GL Item, but do not add any row in Accounting sub-tab
Process and post a new invoice with that GLItem as account in a financial invoice line
Notice that "Cuenta de cuadre" is used because no accounting was present.
In DocInvoice, change
  public boolean getDocumentConfirmation(ConnectionProvider conn, String strRecordId) {
    return true;
  }
with a code that checks:
- Is there any financial invoice line?
|-> No -> return true
|-> Yes -> is there ONE accounting sub-tab record in the G/L Item used?
---|-> Yes -> return true
---|-> No -> return error through these two lines of code:
                              setStatus(STATUS_Error);
                              return false;
No tags attached.
Issue History
2010-09-22 18:29psanjuanNew Issue
2010-09-22 18:29psanjuanAssigned To => vmromanos
2010-09-23 12:51psarobeProjectModules => Openbravo ERP
2010-10-12 10:22sathiyanAssigned Tovmromanos => sathiyan
2010-10-12 10:24sathiyanNote Added: 0031778
2010-10-12 10:24sathiyanStatusnew => feedback
2010-10-13 11:06dalsasuaCategoryAsset Management => 00. Application dictionary
2010-10-13 11:06dalsasuaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=1045#r1045
2010-10-13 11:06dalsasuaProposed Solution updated
2010-10-13 11:06dalsasuaStatusfeedback => new
2010-10-13 11:07dalsasuaNote Added: 0031797
2010-10-14 13:54sathiyanStatusnew => scheduled
2010-10-14 13:54sathiyanfix_in_branch => pi
2010-10-14 14:34hgbotCheckin
2010-10-14 14:34hgbotNote Added: 0031850
2010-10-14 14:34hgbotStatusscheduled => resolved
2010-10-14 14:34hgbotResolutionopen => fixed
2010-10-14 14:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c53d50bda831818bd68db9bd085ac8f5a64d2b27 [^]
2010-10-14 15:51psanjuanCategory00. Application dictionary => 09. Financial management
2010-10-14 15:51psanjuanfix_in_branchpi =>
2010-10-14 22:29hudsonbotCheckin
2010-10-14 22:29hudsonbotNote Added: 0031867
2010-10-22 09:10sureshbabuNote Added: 0032094
2010-10-22 09:10sureshbabuStatusresolved => closed
2010-10-30 11:24anonymoussf_bug_id0 => 3098736

Notes
(0031778)
sathiyan   
2010-10-12 10:24   
Could you please add steps to reproducible, so that I come to know exactly where to do?
(0031797)
dalsasua   
2010-10-13 11:07   
@Sathiyan: done
(0031850)
hgbot   
2010-10-14 14:34   
Repository: erp/devel/pi
Changeset: c53d50bda831818bd68db9bd085ac8f5a64d2b27
Author: Sathiyan Sivaprakasam <sathiyan.sivaprakasam <at> openbravo.com>
Date: Thu Oct 14 18:03:26 2010 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/c53d50bda831818bd68db9bd085ac8f5a64d2b27 [^]

Fixes Issue 14657: System should check in case a GL item with no accounting info is used

---
M src/org/openbravo/erpCommon/ad_forms/DocInvoice.java
M src/org/openbravo/erpCommon/ad_forms/DocInvoice_data.xsql
---
(0031867)
hudsonbot   
2010-10-14 22:29   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/c53d50bda831 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/d7ad2f964c30 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18536.obx [^]
(0032094)
sureshbabu   
2010-10-22 09:10   
verified, now system not allowing the user to post the invoice, when GL item is defined with "Enable in Financial Invoices" checkbox checked and there is no accounting entries defined