Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0014501 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Openbravo ERP] A. Platform | major | have not tried | 2010-09-09 15:59 | 2010-09-21 03:41 | |||
Reporter | shuehner | View Status | public | |||||
Assigned To | alostale | |||||||
Priority | urgent | Resolution | fixed | Fixed in Version | ||||
Status | closed | Fix in branch | Fixed in SCM revision | f26df97fe120 | ||||
Projection | none | ETA | none | Target Version | 2.50MP22 | |||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Merge Request Status | ||||||||
Review Assigned To | ||||||||
OBNetwork customer | No | |||||||
Web browser | ||||||||
Modules | Core | |||||||
Support ticket | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0014501: ActivationKey load from <source.path>/config/licenseRestrictions which breaks erp running without sources | |||||||
Description | When trying to run an erp instance with i.e. just the war-file + database and without sources available on the server then this is no longer possible after the new License Manager project was merged to pi. As this code does load from source.path/config/licenseRestrictions. This needs to be refactored to get back to the old state in which erp runs fine without source.path as long as some special areas are not used: - dataset import/export - mmc Other note: config/ is not the best location as there's nothing the user can configure in that file. | |||||||
Steps To Reproduce | I.e. point source.path to a wrong location and try to login & use the application -> fails as file licenseRestrcitions cannot be found | |||||||
Proposed Solution | Several: a.) move from file to db-content as its shipped with core b.) move file to a normal source folder (i.e. inside the package of the ActivationKey class) and copy that file to WebContent and load from there Version a.) would be consistent with how we handle the license-data. | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
![]() |
|
![]() |
|
(0030920) alostale (viewer) 2010-09-10 09:14 |
Following approach b. Currently there is not table in AD dataset where this info could suit. The most appropriate ones would be the ad_system* ones, but for this it would be required to import this info with as reference data. |
(0030921) hgbot (developer) 2010-09-10 09:17 |
Repository: erp/devel/pi Changeset: 224a37b46fd961a58d5481f9ec631abe91293191 Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Fri Sep 10 09:16:41 2010 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/224a37b46fd961a58d5481f9ec631abe91293191 [^] fixed bug 14501: licenseRestrictions is loaded from <source.path> directory Now license restrictions is in the same package directory as ActivationKey class is. --- M src/build.xml M src/org/openbravo/erpCommon/obps/ActivationKey.java A src/org/openbravo/erpCommon/obps/licenseRestrictions R config/licenseRestrictions --- |
(0030922) alostale (viewer) 2010-09-10 09:17 |
Tested with the three existent deploy modes: none, class and war. |
(0030952) hudsonbot (viewer) 2010-09-10 18:59 |
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated: Changeset: http://code.openbravo.com/erp/devel/main/rev/224a37b46fd9 [^] Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/f6779ed6c074 [^] Tests: http://builds.openbravo.com/view/int/ [^] OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18365.obx [^] |
(0030978) gorkaion (viewer) 2010-09-13 11:44 |
When the system is compiled using Eclipse's "build all" feature the licenseRestrictions file is deleted from the build folder so it is not possible to log in into the application successfully. |
(0030985) hgbot (developer) 2010-09-13 12:54 |
Repository: erp/devel/pi Changeset: f26df97fe120eb871b2f27a9c1adaad3b26d2627 Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Mon Sep 13 12:54:01 2010 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/f26df97fe120eb871b2f27a9c1adaad3b26d2627 [^] fixed bug 14501 License restrictions file is copied to design directory so eclipse does not delete it when rebuilding. --- M src/build.xml M src/org/openbravo/erpCommon/obps/ActivationKey.java --- |
(0031016) hudsonbot (viewer) 2010-09-13 22:28 |
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated: Changeset: http://code.openbravo.com/erp/devel/main/rev/f26df97fe120 [^] Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/f49fef579783 [^] Tests: http://builds.openbravo.com/view/int/ [^] OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18374.obx [^] |
(0031059) shuehner (administrator) 2010-09-14 18:11 |
Reviewed and test on pi/pgsql and upgrade via mmc/obx-file from MP21 appliance to pi,obx-file including the changes. Upgrade working fine. New code now works without needed the file in <source.path>/config anymore. Note that the config/licenseRestrictions file will not be deleted from the config/ folder, but will remain there but will no longer be used. |
(0031247) xeonn (viewer) 2010-09-21 03:41 |
Same error appear with OpenbravoERP3.0RC2. |
![]() |
|||
Date Modified | Username | Field | Change |
2010-09-09 15:59 | shuehner | New Issue | |
2010-09-09 15:59 | shuehner | Assigned To | => alostale |
2010-09-09 15:59 | shuehner | OBNetwork customer | => No |
2010-09-10 09:14 | alostale | Note Added: 0030920 | |
2010-09-10 09:17 | hgbot | Checkin | |
2010-09-10 09:17 | hgbot | Note Added: 0030921 | |
2010-09-10 09:17 | hgbot | Status | new => resolved |
2010-09-10 09:17 | hgbot | Resolution | open => fixed |
2010-09-10 09:17 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/224a37b46fd961a58d5481f9ec631abe91293191 [^] |
2010-09-10 09:17 | alostale | Note Added: 0030922 | |
2010-09-10 18:59 | hudsonbot | Checkin | |
2010-09-10 18:59 | hudsonbot | Note Added: 0030952 | |
2010-09-13 11:44 | gorkaion | Note Added: 0030978 | |
2010-09-13 11:44 | gorkaion | Status | resolved => new |
2010-09-13 11:44 | gorkaion | Resolution | fixed => open |
2010-09-13 12:54 | hgbot | Checkin | |
2010-09-13 12:54 | hgbot | Note Added: 0030985 | |
2010-09-13 12:54 | hgbot | Status | new => resolved |
2010-09-13 12:54 | hgbot | Resolution | open => fixed |
2010-09-13 12:54 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/devel/pi/rev/224a37b46fd961a58d5481f9ec631abe91293191 [^] => http://code.openbravo.com/erp/devel/pi/rev/f26df97fe120eb871b2f27a9c1adaad3b26d2627 [^] |
2010-09-13 22:28 | hudsonbot | Checkin | |
2010-09-13 22:28 | hudsonbot | Note Added: 0031016 | |
2010-09-14 18:11 | shuehner | Note Added: 0031059 | |
2010-09-14 18:11 | shuehner | Status | resolved => closed |
2010-09-15 00:00 | anonymous | sf_bug_id | 0 => 3066292 |
2010-09-21 03:41 | xeonn | Note Added: 0031247 |
Copyright © 2000 - 2009 MantisBT Group |