Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0014501Openbravo ERPA. Platformpublic2010-09-09 15:592010-09-21 03:41
Reportershuehner 
Assigned Toalostale 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version2.50MP22Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0014501: ActivationKey load from <source.path>/config/licenseRestrictions which breaks erp running without sources
DescriptionWhen trying to run an erp instance with i.e. just the war-file + database and without sources available on the server then this is no longer possible after the new License Manager project was merged to pi. As this code does load from source.path/config/licenseRestrictions.

This needs to be refactored to get back to the old state in which erp runs fine without source.path as long as some special areas are not used:
- dataset import/export
- mmc

Other note: config/ is not the best location as there's nothing the user can configure in that file.
Steps To ReproduceI.e. point source.path to a wrong location and try to login & use the application -> fails as file licenseRestrcitions cannot be found
Proposed SolutionSeveral:
a.) move from file to db-content as its shipped with core
b.) move file to a normal source folder (i.e. inside the package of the ActivationKey class) and copy that file to WebContent and load from there

Version a.) would be consistent with how we handle the license-data.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-09-09 15:59shuehnerNew Issue
2010-09-09 15:59shuehnerAssigned To => alostale
2010-09-09 15:59shuehnerOBNetwork customer => No
2010-09-10 09:14alostaleNote Added: 0030920
2010-09-10 09:17hgbotCheckin
2010-09-10 09:17hgbotNote Added: 0030921
2010-09-10 09:17hgbotStatusnew => resolved
2010-09-10 09:17hgbotResolutionopen => fixed
2010-09-10 09:17hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/224a37b46fd961a58d5481f9ec631abe91293191 [^]
2010-09-10 09:17alostaleNote Added: 0030922
2010-09-10 18:59hudsonbotCheckin
2010-09-10 18:59hudsonbotNote Added: 0030952
2010-09-13 11:44gorkaionNote Added: 0030978
2010-09-13 11:44gorkaionStatusresolved => new
2010-09-13 11:44gorkaionResolutionfixed => open
2010-09-13 12:54hgbotCheckin
2010-09-13 12:54hgbotNote Added: 0030985
2010-09-13 12:54hgbotStatusnew => resolved
2010-09-13 12:54hgbotResolutionopen => fixed
2010-09-13 12:54hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/224a37b46fd961a58d5481f9ec631abe91293191 [^] => http://code.openbravo.com/erp/devel/pi/rev/f26df97fe120eb871b2f27a9c1adaad3b26d2627 [^]
2010-09-13 22:28hudsonbotCheckin
2010-09-13 22:28hudsonbotNote Added: 0031016
2010-09-14 18:11shuehnerNote Added: 0031059
2010-09-14 18:11shuehnerStatusresolved => closed
2010-09-15 00:00anonymoussf_bug_id0 => 3066292
2010-09-21 03:41xeonnNote Added: 0031247

Notes
(0030920)
alostale   
2010-09-10 09:14   
Following approach b.

Currently there is not table in AD dataset where this info could suit. The most appropriate ones would be the ad_system* ones, but for this it would be required to import this info with as reference data.
(0030921)
hgbot   
2010-09-10 09:17   
Repository: erp/devel/pi
Changeset: 224a37b46fd961a58d5481f9ec631abe91293191
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Sep 10 09:16:41 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/224a37b46fd961a58d5481f9ec631abe91293191 [^]

fixed bug 14501: licenseRestrictions is loaded from <source.path> directory

  Now license restrictions is in the same package directory as ActivationKey class is.

---
M src/build.xml
M src/org/openbravo/erpCommon/obps/ActivationKey.java
A src/org/openbravo/erpCommon/obps/licenseRestrictions
R config/licenseRestrictions
---
(0030922)
alostale   
2010-09-10 09:17   
Tested with the three existent deploy modes: none, class and war.
(0030952)
hudsonbot   
2010-09-10 18:59   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/224a37b46fd9 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/f6779ed6c074 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18365.obx [^]
(0030978)
gorkaion   
2010-09-13 11:44   
When the system is compiled using Eclipse's "build all" feature the licenseRestrictions file is deleted from the build folder so it is not possible to log in into the application successfully.
(0030985)
hgbot   
2010-09-13 12:54   
Repository: erp/devel/pi
Changeset: f26df97fe120eb871b2f27a9c1adaad3b26d2627
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Sep 13 12:54:01 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f26df97fe120eb871b2f27a9c1adaad3b26d2627 [^]

fixed bug 14501
  License restrictions file is copied to design directory so eclipse
  does not delete it when rebuilding.

---
M src/build.xml
M src/org/openbravo/erpCommon/obps/ActivationKey.java
---
(0031016)
hudsonbot   
2010-09-13 22:28   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/f26df97fe120 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/f49fef579783 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18374.obx [^]
(0031059)
shuehner   
2010-09-14 18:11   
Reviewed and test on pi/pgsql and upgrade via mmc/obx-file from MP21 appliance to pi,obx-file including the changes. Upgrade working fine. New code now works without needed the file in <source.path>/config anymore. Note that the config/licenseRestrictions file will not be deleted from the config/ folder, but will remain there but will no longer be used.
(0031247)
xeonn   
2010-09-21 03:41   
Same error appear with OpenbravoERP3.0RC2.