Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0014156 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] Z. Others | minor | always | 2010-08-10 11:49 | 2010-12-09 16:04 | |||
| Reporter | iperdomo | View Status | public | |||||
| Assigned To | iperdomo | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | 2.50 | |||
| Status | closed | Fix in branch | pi | Fixed in SCM revision | 57434ba9b9a6 | |||
| Projection | none | ETA | none | Target Version | ||||
| OS | Linux 32 bit | Database | PostgreSQL | Java version | 1.6.0_15 | |||
| OS Version | 2.6.30-gentoo-r5 | Database version | 8.3.8 | Ant version | 1.7.1 | |||
| Product Version | 2.50 | SCM revision | ||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | User Interface Application | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0014156: Fix JS files based on JSLint suggestions | |||||||
| Description | There are missing semicolons, wrong line break, etc Fix the JavaScript files based on JSLint suggestions. | |||||||
| Steps To Reproduce | * Check all .js files in the module for any error/warning with JSLint | |||||||
| Proposed Solution | The only non fixed code is the use of eval() | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0029868) hgbot (developer) 2010-08-10 11:54 |
Repository: erp/mods/org.openbravo.client.application Changeset: 57434ba9b9a69494e40c4672d2bc6716c8b3217d Author: Iván Perdomo <ivan.perdomo <at> openbravo.com> Date: Tue Aug 10 11:53:45 2010 +0200 URL: http://code.openbravo.com/erp/mods/org.openbravo.client.application/rev/57434ba9b9a69494e40c4672d2bc6716c8b3217d [^] Fixes issue 14156: Fixes JSLint warnings - Added missing semicolons - Fixed wrong line breaks - Simplified some code by using the or (||) operator - Removed the loadingMessage memeber since is not supported by SmartClient when using contentType:'page' - Change ISC.eval() to native eval() makes no sense to add an extra function if is calling the native eval --- M web/org.openbravo.client.application/js/classic-ob-compatibility.js M web/org.openbravo.client.application/js/classic-ob-window.js M web/org.openbravo.client.application/js/test/ui-test.js M web/org.openbravo.client.application/js/view-manager.js --- |
|
(0030555) mtaal (manager) 2010-09-01 10:04 |
static js files are now checked at runtime also. Closing issue |
|
(0030598) hgbot (developer) 2010-09-03 14:37 |
Repository: erp/mods/org.openbravo.client.application-new-activation Changeset: 57434ba9b9a69494e40c4672d2bc6716c8b3217d Author: Iván Perdomo <ivan.perdomo <at> openbravo.com> Date: Tue Aug 10 11:53:45 2010 +0200 URL: http://code.openbravo.com/erp/mods/org.openbravo.client.application-new-activation/rev/57434ba9b9a69494e40c4672d2bc6716c8b3217d [^] Fixes issue 14156: Fixes JSLint warnings - Added missing semicolons - Fixed wrong line breaks - Simplified some code by using the or (||) operator - Removed the loadingMessage memeber since is not supported by SmartClient when using contentType:'page' - Change ISC.eval() to native eval() makes no sense to add an extra function if is calling the native eval --- M web/org.openbravo.client.application/js/classic-ob-compatibility.js M web/org.openbravo.client.application/js/classic-ob-window.js M web/org.openbravo.client.application/js/test/ui-test.js M web/org.openbravo.client.application/js/view-manager.js --- |
|
(0030613) mtaal (manager) 2010-09-04 20:01 |
also static javascript files are now jslint checked, they currently do not show errors. |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2010-08-10 11:49 | iperdomo | New Issue | |
| 2010-08-10 11:49 | iperdomo | Assigned To | => iperdomo |
| 2010-08-10 11:50 | iperdomo | Status | new => scheduled |
| 2010-08-10 11:50 | iperdomo | fix_in_branch | => pi |
| 2010-08-10 11:54 | hgbot | Checkin | |
| 2010-08-10 11:54 | hgbot | Note Added: 0029868 | |
| 2010-08-10 11:54 | hgbot | Status | scheduled => resolved |
| 2010-08-10 11:54 | hgbot | Resolution | open => fixed |
| 2010-08-10 11:54 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/mods/org.openbravo.client.application/rev/57434ba9b9a69494e40c4672d2bc6716c8b3217d [^] |
| 2010-09-01 10:04 | mtaal | Note Added: 0030555 | |
| 2010-09-01 10:04 | mtaal | Status | resolved => closed |
| 2010-09-03 14:37 | hgbot | Checkin | |
| 2010-09-03 14:37 | hgbot | Note Added: 0030598 | |
| 2010-09-03 14:37 | hgbot | Status | closed => resolved |
| 2010-09-03 14:37 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/mods/org.openbravo.client.application/rev/57434ba9b9a69494e40c4672d2bc6716c8b3217d [^] => http://code.openbravo.com/erp/mods/org.openbravo.client.application-new-activation/rev/57434ba9b9a69494e40c4672d2bc6716c8b3217d [^] |
| 2010-09-04 20:01 | mtaal | Note Added: 0030613 | |
| 2010-09-04 20:01 | mtaal | Status | resolved => closed |
| 2010-09-04 20:01 | mtaal | Fixed in Version | => 2.50 |
| 2010-12-09 16:04 | anonymous | sf_bug_id | 0 => 3133354 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |