Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0014156Openbravo ERPZ. Otherspublic2010-08-10 11:492010-12-09 16:04
Reporteriperdomo 
Assigned Toiperdomo 
PriorityurgentSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS Version2.6.30-gentoo-r5
Product Version2.50 
Target VersionFixed in Version2.50 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesUser Interface Application
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0014156: Fix JS files based on JSLint suggestions
DescriptionThere are missing semicolons, wrong line break, etc
Fix the JavaScript files based on JSLint suggestions.
Steps To Reproduce* Check all .js files in the module for any error/warning with JSLint
Proposed SolutionThe only non fixed code is the use of eval()
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-08-10 11:49iperdomoNew Issue
2010-08-10 11:49iperdomoAssigned To => iperdomo
2010-08-10 11:50iperdomoStatusnew => scheduled
2010-08-10 11:50iperdomofix_in_branch => pi
2010-08-10 11:54hgbotCheckin
2010-08-10 11:54hgbotNote Added: 0029868
2010-08-10 11:54hgbotStatusscheduled => resolved
2010-08-10 11:54hgbotResolutionopen => fixed
2010-08-10 11:54hgbotFixed in SCM revision => http://code.openbravo.com/erp/mods/org.openbravo.client.application/rev/57434ba9b9a69494e40c4672d2bc6716c8b3217d [^]
2010-09-01 10:04mtaalNote Added: 0030555
2010-09-01 10:04mtaalStatusresolved => closed
2010-09-03 14:37hgbotCheckin
2010-09-03 14:37hgbotNote Added: 0030598
2010-09-03 14:37hgbotStatusclosed => resolved
2010-09-03 14:37hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/mods/org.openbravo.client.application/rev/57434ba9b9a69494e40c4672d2bc6716c8b3217d [^] => http://code.openbravo.com/erp/mods/org.openbravo.client.application-new-activation/rev/57434ba9b9a69494e40c4672d2bc6716c8b3217d [^]
2010-09-04 20:01mtaalNote Added: 0030613
2010-09-04 20:01mtaalStatusresolved => closed
2010-09-04 20:01mtaalFixed in Version => 2.50
2010-12-09 16:04anonymoussf_bug_id0 => 3133354

Notes
(0029868)
hgbot   
2010-08-10 11:54   
Repository: erp/mods/org.openbravo.client.application
Changeset: 57434ba9b9a69494e40c4672d2bc6716c8b3217d
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Tue Aug 10 11:53:45 2010 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.client.application/rev/57434ba9b9a69494e40c4672d2bc6716c8b3217d [^]

Fixes issue 14156: Fixes JSLint warnings
- Added missing semicolons
- Fixed wrong line breaks
- Simplified some code by using the or (||) operator
- Removed the loadingMessage memeber since is not supported by SmartClient
  when using contentType:'page'
- Change ISC.eval() to native eval() makes no sense to add an extra function
  if is calling the native eval

---
M web/org.openbravo.client.application/js/classic-ob-compatibility.js
M web/org.openbravo.client.application/js/classic-ob-window.js
M web/org.openbravo.client.application/js/test/ui-test.js
M web/org.openbravo.client.application/js/view-manager.js
---
(0030555)
mtaal   
2010-09-01 10:04   
static js files are now checked at runtime also.

Closing issue
(0030598)
hgbot   
2010-09-03 14:37   
Repository: erp/mods/org.openbravo.client.application-new-activation
Changeset: 57434ba9b9a69494e40c4672d2bc6716c8b3217d
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Tue Aug 10 11:53:45 2010 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.client.application-new-activation/rev/57434ba9b9a69494e40c4672d2bc6716c8b3217d [^]

Fixes issue 14156: Fixes JSLint warnings
- Added missing semicolons
- Fixed wrong line breaks
- Simplified some code by using the or (||) operator
- Removed the loadingMessage memeber since is not supported by SmartClient
  when using contentType:'page'
- Change ISC.eval() to native eval() makes no sense to add an extra function
  if is calling the native eval

---
M web/org.openbravo.client.application/js/classic-ob-compatibility.js
M web/org.openbravo.client.application/js/classic-ob-window.js
M web/org.openbravo.client.application/js/test/ui-test.js
M web/org.openbravo.client.application/js/view-manager.js
---
(0030613)
mtaal   
2010-09-04 20:01   
also static javascript files are now jslint checked, they currently do not show errors.