Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0014143
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajorhave not tried2010-08-06 17:242010-08-19 00:00
ReporternetworkbView Statuspublic 
Assigned Toalostale 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisionbe6925f7d4e7
ProjectionnoneETAnoneTarget Version2.50MP21
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version2.50MP20SCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0014143: You can create two modules with the same package_name

DescriptionYou can create two modules with the same package_name.
Steps To Reproduce-create one module with packagename= org.openbravo.aa
-create a differente mdoule with package name= org.openbravo.aa
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0014162 closedadrianromero api check build 301 fails 
related to feature request 0014233 scheduledTriage Platform Base Add extra check on install module to avoid problems with two modules having the same java-package. 

-  Notes
(0029900)
hgbot (developer)
2010-08-12 09:02

 Repository: erp/devel/pi
Changeset: be6925f7d4e7506ad9c8562b2d121778819b90bc
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Aug 12 09:01:48 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/be6925f7d4e7506ad9c8562b2d121778819b90bc [^]

fixed issue 14143: You can create two modules with the same package_name

  *Added unique contraint on ad_module.javapackage column
  *Added build validation to check all modules installed in the instance have different javapackage

---
M src-db/database/model/tables/AD_MODULE.xml
A src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/DuplicatedJavaPackage.class
A src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/DuplicatedJavaPackageData.class
A src-util/buildvalidation/src/org/openbravo/buildvalidation/DuplicatedJavaPackage.java
A src-util/buildvalidation/src/org/openbravo/buildvalidation/DuplicatedJavaPackage_data.xsql
---
(0029928)
hudsonbot (developer)
2010-08-12 21:12

 A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/be6925f7d4e7 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/dd00ba1c00c6 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18116.obx [^]
(0030116)
shuehner (administrator)
2010-08-18 13:19

 Tested on pi/pgsql working fine now. The new constraint rejects creating a new module with a duplicate java package and the build-validation does stop an update to MP21 if such wrong data already exists in some instance.
Additionally there is already an existing check in the CR which prevents registering a new module with the same java-package than some existing module.

- Issue History
Date Modified Username Field Change
2010-08-06 17:24 networkb New Issue
2010-08-06 17:24 networkb Assigned To => alostale
2010-08-09 08:03 alostale Status new => scheduled
2010-08-12 09:02 hgbot Checkin
2010-08-12 09:02 hgbot Note Added: 0029900
2010-08-12 09:02 hgbot Status scheduled => resolved
2010-08-12 09:02 hgbot Resolution open => fixed
2010-08-12 09:02 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/be6925f7d4e7506ad9c8562b2d121778819b90bc [^]
2010-08-12 10:03 alostale Relationship added related to 0014162
2010-08-12 21:12 hudsonbot Checkin
2010-08-12 21:12 hudsonbot Note Added: 0029928
2010-08-18 13:18 shuehner Relationship added related to 0014233
2010-08-18 13:19 shuehner Note Added: 0030116
2010-08-18 13:19 shuehner Status resolved => closed
2010-08-19 00:00 anonymous sf_bug_id 0 => 3048131

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker