Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0014143Openbravo ERPA. Platformpublic2010-08-06 17:242010-08-19 00:00
Reporternetworkb 
Assigned Toalostale 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.50MP20 
Target Version2.50MP21Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0014143: You can create two modules with the same package_name
DescriptionYou can create two modules with the same package_name.
Steps To Reproduce-create one module with packagename= org.openbravo.aa
-create a differente mdoule with package name= org.openbravo.aa
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0014162 closed adrianromero api check build 301 fails 
related to feature request 0014233 scheduled Triage Platform Base Add extra check on install module to avoid problems with two modules having the same java-package. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-08-06 17:24networkbNew Issue
2010-08-06 17:24networkbAssigned To => alostale
2010-08-09 08:03alostaleStatusnew => scheduled
2010-08-12 09:02hgbotCheckin
2010-08-12 09:02hgbotNote Added: 0029900
2010-08-12 09:02hgbotStatusscheduled => resolved
2010-08-12 09:02hgbotResolutionopen => fixed
2010-08-12 09:02hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/be6925f7d4e7506ad9c8562b2d121778819b90bc [^]
2010-08-12 10:03alostaleRelationship addedrelated to 0014162
2010-08-12 21:12hudsonbotCheckin
2010-08-12 21:12hudsonbotNote Added: 0029928
2010-08-18 13:18shuehnerRelationship addedrelated to 0014233
2010-08-18 13:19shuehnerNote Added: 0030116
2010-08-18 13:19shuehnerStatusresolved => closed
2010-08-19 00:00anonymoussf_bug_id0 => 3048131

Notes
(0029900)
hgbot   
2010-08-12 09:02   
Repository: erp/devel/pi
Changeset: be6925f7d4e7506ad9c8562b2d121778819b90bc
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Aug 12 09:01:48 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/be6925f7d4e7506ad9c8562b2d121778819b90bc [^]

fixed issue 14143: You can create two modules with the same package_name

  *Added unique contraint on ad_module.javapackage column
  *Added build validation to check all modules installed in the instance have different javapackage

---
M src-db/database/model/tables/AD_MODULE.xml
A src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/DuplicatedJavaPackage.class
A src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/DuplicatedJavaPackageData.class
A src-util/buildvalidation/src/org/openbravo/buildvalidation/DuplicatedJavaPackage.java
A src-util/buildvalidation/src/org/openbravo/buildvalidation/DuplicatedJavaPackage_data.xsql
---
(0029928)
hudsonbot   
2010-08-12 21:12   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/be6925f7d4e7 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/dd00ba1c00c6 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18116.obx [^]
(0030116)
shuehner   
2010-08-18 13:19   
Tested on pi/pgsql working fine now. The new constraint rejects creating a new module with a duplicate java package and the build-validation does stop an update to MP21 if such wrong data already exists in some instance.
Additionally there is already an existing check in the CR which prevents registering a new module with the same java-package than some existing module.