Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0013760 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] Z. Others | major | always | 2010-06-24 10:21 | 2010-12-09 16:03 | |||
| Reporter | iperdomo | View Status | public | |||||
| Assigned To | alostale | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 814ac050e91d | ||||
| Projection | none | ETA | none | Target Version | 2.50 | |||
| OS | Linux 32 bit | Database | PostgreSQL | Java version | 1.6.0_15 | |||
| OS Version | 2.6.30-gentoo-r5 | Database version | 8.3.8 | Ant version | 1.7.1 | |||
| Product Version | 2.50 | SCM revision | ||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Smartclient | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0013760: Order of included resources is not preserved | |||||||
| Description | The WADSelector has these two lines in the initialize method: addImport("SetSmartClientSkinLocation", "../../../../../web/org.openbravo.userinterface.selector/js/classic-skin-variable.js"); addImport("StaticResources", "../../../../../web/../org.openbravo.client.kernel/OBCLKER_Kernel/StaticResources"); The order of these two lines is important, meaning that the classic-skin-variable.js should be placed before the StaticResources in the html. However, apparently there are cases where the order is changed. NOTE: It seems that the problem is that the imports are stored in a Properties object instead of a data structure that preserves the order (ArrayList, Vector) https://code.openbravo.com/erp/devel/pi/file/f7b9678ebb10/src-wad/src/org/openbravo/wad/Wad.java#l3792 [^] | |||||||
| Steps To Reproduce | * Install the following modules from the code repository: org.openbravo.base.seam org.openbravo.client.freemarker org.openbravo.client.kernel org.openbravo.examples.userinterface.selector org.openbravo.selectors org.openbravo.service.datasource org.openbravo.service.json org.openbravo.userinterface.selector org.openbravo.userinterface.smartclient * Execute the process to change the Business Partner selector in all windows * Do a full compilation * Visit a common window like: Purchase Order * You'll see the error in the skin of the selector | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0028745) hgbot (developer) 2010-06-24 15:43 |
Repository: erp/devel/pi Changeset: 814ac050e91dba3e499a93f07c6b590d1afb735a Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Thu Jun 24 15:41:33 2010 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/814ac050e91dba3e499a93f07c6b590d1afb735a [^] fixed bug 13760: Order of included resources is not preserved Use ArrayList<String> instead of Properties in order to preserve the originally defined order in the html imports. Note that this change affects to all generated windows by altering the order of the imports. --- M src-wad/src/org/openbravo/wad/Wad.java --- |
|
(0028904) hudsonbot (developer) 2010-06-30 12:17 |
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated: Changeset: http://code.openbravo.com/erp/devel/main/rev/814ac050e91d [^] Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/0670375d782d [^] Tests: http://builds.openbravo.com/view/int/ [^] OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17726.obx [^] |
|
(0029263) shuehner (administrator) 2010-07-13 13:54 |
Tested on pi, rev:c358c1e82f10. changeset reviewed, implements a better predictible ordering of js-includes. Now order by appearances in the different wad-control instead of hash-code of name used in the wad-control. Testing done on ff + ie (by developer and me) to verify that the changed js include order is working fine. |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2010-06-24 10:21 | iperdomo | New Issue | |
| 2010-06-24 10:21 | iperdomo | Assigned To | => alostale |
| 2010-06-24 10:22 | iperdomo | Steps to Reproduce Updated | View Revisions |
| 2010-06-24 10:22 | iperdomo | Status | new => scheduled |
| 2010-06-24 10:22 | iperdomo | fix_in_branch | => pi |
| 2010-06-24 10:25 | iperdomo | fix_in_branch | pi => |
| 2010-06-24 10:25 | iperdomo | Steps to Reproduce Updated | View Revisions |
| 2010-06-24 15:43 | hgbot | Checkin | |
| 2010-06-24 15:43 | hgbot | Note Added: 0028745 | |
| 2010-06-24 15:43 | hgbot | Status | scheduled => resolved |
| 2010-06-24 15:43 | hgbot | Resolution | open => fixed |
| 2010-06-24 15:43 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/814ac050e91dba3e499a93f07c6b590d1afb735a [^] |
| 2010-06-30 12:17 | hudsonbot | Checkin | |
| 2010-06-30 12:17 | hudsonbot | Note Added: 0028904 | |
| 2010-07-13 13:54 | shuehner | Note Added: 0029263 | |
| 2010-07-13 13:54 | shuehner | Status | resolved => closed |
| 2010-12-09 16:03 | anonymous | sf_bug_id | 0 => 3133267 |
| 2010-12-10 17:15 | shuehner | Relationship added | related to 0015403 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |