Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013760Openbravo ERPZ. Otherspublic2010-06-24 10:212010-12-09 16:03
Reporteriperdomo 
Assigned Toalostale 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS Version2.6.30-gentoo-r5
Product Version2.50 
Target Version2.50Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesSmartclient
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0013760: Order of included resources is not preserved
DescriptionThe WADSelector has these two lines in the initialize method:
    addImport("SetSmartClientSkinLocation",
        
"../../../../../web/org.openbravo.userinterface.selector/js/classic-skin-variable.js");

    addImport("StaticResources",
        
"../../../../../web/../org.openbravo.client.kernel/OBCLKER_Kernel/StaticResources");

The order of these two lines is important, meaning that the
classic-skin-variable.js should be placed before the StaticResources in
the html. However, apparently there are cases where the order is changed.


NOTE: It seems that the problem is that the imports are stored in a Properties object instead of a data structure that preserves the order (ArrayList, Vector)

https://code.openbravo.com/erp/devel/pi/file/f7b9678ebb10/src-wad/src/org/openbravo/wad/Wad.java#l3792 [^]
Steps To Reproduce* Install the following modules from the code repository:

org.openbravo.base.seam
org.openbravo.client.freemarker
org.openbravo.client.kernel
org.openbravo.examples.userinterface.selector
org.openbravo.selectors
org.openbravo.service.datasource
org.openbravo.service.json
org.openbravo.userinterface.selector
org.openbravo.userinterface.smartclient

* Execute the process to change the Business Partner selector in all windows
* Do a full compilation
* Visit a common window like: Purchase Order
* You'll see the error in the skin of the selector
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0015403 acknowledged Triage Platform Base Order of included resources is not preserved (in WadActionButton code) 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-06-24 10:21iperdomoNew Issue
2010-06-24 10:21iperdomoAssigned To => alostale
2010-06-24 10:21iperdomoOBNetwork customer => No
2010-06-24 10:22iperdomoSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=528#r528
2010-06-24 10:22iperdomoStatusnew => scheduled
2010-06-24 10:22iperdomofix_in_branch => pi
2010-06-24 10:25iperdomofix_in_branchpi =>
2010-06-24 10:25iperdomoSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=529#r529
2010-06-24 15:43hgbotCheckin
2010-06-24 15:43hgbotNote Added: 0028745
2010-06-24 15:43hgbotStatusscheduled => resolved
2010-06-24 15:43hgbotResolutionopen => fixed
2010-06-24 15:43hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/814ac050e91dba3e499a93f07c6b590d1afb735a [^]
2010-06-30 12:17hudsonbotCheckin
2010-06-30 12:17hudsonbotNote Added: 0028904
2010-07-13 13:54shuehnerNote Added: 0029263
2010-07-13 13:54shuehnerStatusresolved => closed
2010-12-09 16:03anonymoussf_bug_id0 => 3133267
2010-12-10 17:15shuehnerRelationship addedrelated to 0015403

Notes
(0028745)
hgbot   
2010-06-24 15:43   
Repository: erp/devel/pi
Changeset: 814ac050e91dba3e499a93f07c6b590d1afb735a
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Jun 24 15:41:33 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/814ac050e91dba3e499a93f07c6b590d1afb735a [^]

fixed bug 13760: Order of included resources is not preserved

   Use ArrayList<String> instead of Properties in order to preserve the originally defined
   order in the html imports.

   Note that this change affects to all generated windows by altering the order of the imports.

---
M src-wad/src/org/openbravo/wad/Wad.java
---
(0028904)
hudsonbot   
2010-06-30 12:17   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/814ac050e91d [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/0670375d782d [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17726.obx [^]
(0029263)
shuehner   
2010-07-13 13:54   
Tested on pi, rev:c358c1e82f10. changeset reviewed, implements a better predictible ordering of js-includes. Now order by appearances in the different wad-control instead of hash-code of name used in the wad-control.
Testing done on ff + ie (by developer and me) to verify that the changed js include order is working fine.