Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0013733 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] Z. Others | major | have not tried | 2010-06-22 17:14 | 2010-12-09 16:03 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | iperdomo | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | pi | Fixed in SCM revision | d3ea2f000938 | |||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | 2.50 | SCM revision | ||||||
| Merge Request Status | ||||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | User Interface Selector | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0013733: Out columns in wad window have wrong behavior with empty columns => putting 'undefined' used as value | |||||||
| Description | When using an out-column and the selector field of the selected row does not have any value (no value shown in the selector column). Then the string 'undefined' is literally placed into the tab's field. | |||||||
| Steps To Reproduce | Use steps to reproduce from issue 13726 and pick a row in the selector which does not have any content for the description column. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0028686) hgbot (developer) 2010-06-22 19:31 |
Repository: erp/mods/org.openbravo.userinterface.selector Changeset: 73ed51d6f778f5dedd4acfcb8ead6b0a90ee61f5 Author: Iván Perdomo <ivan.perdomo <at> openbravo.com> Date: Tue Jun 22 19:30:53 2010 +0200 URL: http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/73ed51d6f778f5dedd4acfcb8ead6b0a90ee61f5 [^] Fixes issue 13733: Added extra check to set a value on a field --- M web/org.openbravo.userinterface.selector/js/ob_selector_widget.js --- |
|
(0028707) shuehner (administrator) 2010-06-23 17:38 |
Note: Needs discussion/definition of wanted behavior. Scenario: new selector on a field product, second field in the tab named description gets filled from m_product.description via out-fields mechanism. Now assume product field: productA description field: description of product A Now use selector to change product field to: productB (which does not have any description) Current behavior: description field in tab is not changed or emptied (continues to contain: description of productB) Possible alternate behavior: description field will be emptied, as product B does not have a description Related topic: if product field+description have a value. Then description field is manually changed Then selector is opened, and same row selected again: Should the description be updated again with the product description? or as same row selected again -> now change? |
|
(0028713) shuehner (administrator) 2010-06-23 19:05 |
After discussion following is planned behavior: first scenario: Selecting a row which has no value for a column defined as out-column should empty the corresponding field in the tab Selecting the same row in a selector should refill/overwrite all fields (incl. out-fields) which the values coming from the selector. |
|
(0028714) shuehner (administrator) 2010-06-23 19:05 |
Reopening as per result of dicussion. Following behavior-change is needed: If a out-field value is empty/undefined -> empty the corresponding tab-field instead of not touching it. |
|
(0028739) hgbot (developer) 2010-06-24 14:18 |
Repository: erp/mods/org.openbravo.userinterface.selector Changeset: d3ea2f000938420ff583d102958dab07353850a6 Author: Iván Perdomo <ivan.perdomo <at> openbravo.com> Date: Thu Jun 24 14:17:45 2010 +0200 URL: http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/d3ea2f000938420ff583d102958dab07353850a6 [^] Fixes issue 13733: Changed evaluation of the value to assign The previous version was checking if the target existis and if the value is a truthy one, meaning that null, undefined and empty string will be skipped. Now we explicit check for null and undefined and assign an empty string. --- M web/org.openbravo.userinterface.selector/js/ob_selector_widget.js --- |
|
(0028741) shuehner (administrator) 2010-06-24 15:11 |
Reviewed+tested using pi,rev:effc222a5857+, Selector module, hg-rev: d3ea2f000938 Working fine. Now when a selector row is selected having no value for some out-column the corresponding form-field is correctly emptied. |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2010-06-22 17:14 | shuehner | New Issue | |
| 2010-06-22 17:14 | shuehner | Assigned To | => iperdomo |
| 2010-06-22 17:14 | shuehner | OBNetwork customer | => No |
| 2010-06-22 18:45 | iperdomo | Status | new => scheduled |
| 2010-06-22 18:45 | iperdomo | fix_in_branch | => pi |
| 2010-06-22 19:31 | hgbot | Checkin | |
| 2010-06-22 19:31 | hgbot | Note Added: 0028686 | |
| 2010-06-22 19:31 | hgbot | Status | scheduled => resolved |
| 2010-06-22 19:31 | hgbot | Resolution | open => fixed |
| 2010-06-22 19:31 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/73ed51d6f778f5dedd4acfcb8ead6b0a90ee61f5 [^] |
| 2010-06-23 17:38 | shuehner | Note Added: 0028707 | |
| 2010-06-23 19:05 | shuehner | Note Added: 0028713 | |
| 2010-06-23 19:05 | shuehner | Note Added: 0028714 | |
| 2010-06-23 19:05 | shuehner | Status | resolved => new |
| 2010-06-23 19:05 | shuehner | Resolution | fixed => open |
| 2010-06-23 19:07 | shuehner | Relationship added | related to 0013756 |
| 2010-06-24 14:01 | iperdomo | Status | new => scheduled |
| 2010-06-24 14:18 | hgbot | Checkin | |
| 2010-06-24 14:18 | hgbot | Note Added: 0028739 | |
| 2010-06-24 14:18 | hgbot | Status | scheduled => resolved |
| 2010-06-24 14:18 | hgbot | Resolution | open => fixed |
| 2010-06-24 14:18 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/73ed51d6f778f5dedd4acfcb8ead6b0a90ee61f5 [^] => http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/d3ea2f000938420ff583d102958dab07353850a6 [^] |
| 2010-06-24 15:11 | shuehner | Note Added: 0028741 | |
| 2010-06-24 15:11 | shuehner | Status | resolved => closed |
| 2010-12-09 16:03 | anonymous | sf_bug_id | 0 => 3133262 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |