Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013733Openbravo ERPZ. Otherspublic2010-06-22 17:142010-12-09 16:03
Reportershuehner 
Assigned Toiperdomo 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.50 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesUser Interface Selector
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0013733: Out columns in wad window have wrong behavior with empty columns => putting 'undefined' used as value
DescriptionWhen using an out-column and the selector field of the selected row does not have any value (no value shown in the selector column). Then the string 'undefined' is literally placed into the tab's field.
Steps To ReproduceUse steps to reproduce from issue 13726 and pick a row in the selector which does not have any content for the description column.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0013756 closed iperdomo Re-selecting the same row in a selector should re-fill/overwrite all out-columns fields in the tab. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-06-22 17:14shuehnerNew Issue
2010-06-22 17:14shuehnerAssigned To => iperdomo
2010-06-22 17:14shuehnerOBNetwork customer => No
2010-06-22 18:45iperdomoStatusnew => scheduled
2010-06-22 18:45iperdomofix_in_branch => pi
2010-06-22 19:31hgbotCheckin
2010-06-22 19:31hgbotNote Added: 0028686
2010-06-22 19:31hgbotStatusscheduled => resolved
2010-06-22 19:31hgbotResolutionopen => fixed
2010-06-22 19:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/73ed51d6f778f5dedd4acfcb8ead6b0a90ee61f5 [^]
2010-06-23 17:38shuehnerNote Added: 0028707
2010-06-23 19:05shuehnerNote Added: 0028713
2010-06-23 19:05shuehnerNote Added: 0028714
2010-06-23 19:05shuehnerStatusresolved => new
2010-06-23 19:05shuehnerResolutionfixed => open
2010-06-23 19:07shuehnerRelationship addedrelated to 0013756
2010-06-24 14:01iperdomoStatusnew => scheduled
2010-06-24 14:18hgbotCheckin
2010-06-24 14:18hgbotNote Added: 0028739
2010-06-24 14:18hgbotStatusscheduled => resolved
2010-06-24 14:18hgbotResolutionopen => fixed
2010-06-24 14:18hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/73ed51d6f778f5dedd4acfcb8ead6b0a90ee61f5 [^] => http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/d3ea2f000938420ff583d102958dab07353850a6 [^]
2010-06-24 15:11shuehnerNote Added: 0028741
2010-06-24 15:11shuehnerStatusresolved => closed
2010-12-09 16:03anonymoussf_bug_id0 => 3133262

Notes
(0028686)
hgbot   
2010-06-22 19:31   
Repository: erp/mods/org.openbravo.userinterface.selector
Changeset: 73ed51d6f778f5dedd4acfcb8ead6b0a90ee61f5
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Tue Jun 22 19:30:53 2010 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/73ed51d6f778f5dedd4acfcb8ead6b0a90ee61f5 [^]

Fixes issue 13733: Added extra check to set a value on a field

---
M web/org.openbravo.userinterface.selector/js/ob_selector_widget.js
---
(0028707)
shuehner   
2010-06-23 17:38   
Note: Needs discussion/definition of wanted behavior.

Scenario:
new selector on a field product, second field in the tab named description gets filled from m_product.description via out-fields mechanism.

Now assume
product field: productA
description field: description of product A

Now use selector to change product field to: productB (which does not have any description)

Current behavior: description field in tab is not changed or emptied (continues to contain: description of productB)

Possible alternate behavior:
description field will be emptied, as product B does not have a description

Related topic:
if product field+description have a value.
Then description field is manually changed
Then selector is opened, and same row selected again:
Should the description be updated again with the product description? or as same row selected again -> now change?
(0028713)
shuehner   
2010-06-23 19:05   
After discussion following is planned behavior:
first scenario:
Selecting a row which has no value for a column defined as out-column should empty the corresponding field in the tab

Selecting the same row in a selector should refill/overwrite all fields (incl. out-fields) which the values coming from the selector.
(0028714)
shuehner   
2010-06-23 19:05   
Reopening as per result of dicussion.
Following behavior-change is needed:
If a out-field value is empty/undefined -> empty the corresponding tab-field instead of not touching it.
(0028739)
hgbot   
2010-06-24 14:18   
Repository: erp/mods/org.openbravo.userinterface.selector
Changeset: d3ea2f000938420ff583d102958dab07353850a6
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Thu Jun 24 14:17:45 2010 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.userinterface.selector/rev/d3ea2f000938420ff583d102958dab07353850a6 [^]

Fixes issue 13733: Changed evaluation of the value to assign
The previous version was checking if the target existis and if the value is a
truthy one, meaning that null, undefined and empty string will be skipped. Now
we explicit check for null and undefined and assign an empty string.

---
M web/org.openbravo.userinterface.selector/js/ob_selector_widget.js
---
(0028741)
shuehner   
2010-06-24 15:11   
Reviewed+tested using pi,rev:effc222a5857+,
Selector module, hg-rev: d3ea2f000938
Working fine. Now when a selector row is selected having no value for some out-column the corresponding form-field is correctly emptied.